From nobody Sun Feb 8 11:40:55 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1652342164; cv=none; d=zohomail.com; s=zohoarc; b=IgbhBEQ5DghpDXuXKuUaZPDfYyNcztaWImcdDi9Lj13QRhj+2EIsro9yv6OkqnlEcONLC3jqRVcY6AsEgY/mrSlLXUpohtyK6wKonO0G2IHwuc1XqxudvGx+dJes4ZPytsMvJ+5aTX4ChfYQk0u8U0bzVeJc8djl4q2TcSlK3ps= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652342164; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=XYvGUhtOaEpMFY5y/T1zeSinJJffLiDeLg2Z9qtyUiM=; b=U8Y6rAU6TFnrunndJXqiMlylqHJFdvQsMWApERg5CEoSIOmV6EFJf4DLpx9DpurqoWMggBcqoSpJ3UF81OEnW+ct6777PEKv2olMS/Sxk7HLSqNtWiOQCKka7SnqWWBs9Tf1ncg8PRoazAl7tAl0m/XkPvXonPYeOx4/Sym9DlY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1652342164609792.4850425341591; Thu, 12 May 2022 00:56:04 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-668-ob8fPaIIPMKQM_sZOcbRYA-1; Thu, 12 May 2022 03:55:57 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7131090E983; Thu, 12 May 2022 07:55:55 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 58BACC28124; Thu, 12 May 2022 07:55:55 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 2A5901932218; Thu, 12 May 2022 07:55:54 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id D9E071947B88 for ; Thu, 12 May 2022 07:55:52 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id CABF356A16A; Thu, 12 May 2022 07:55:52 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C680456A169 for ; Thu, 12 May 2022 07:55:52 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A4F12803D46 for ; Thu, 12 May 2022 07:55:52 +0000 (UTC) Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-465-JjHdSfjaMV65GNhQWOy_DQ-1; Thu, 12 May 2022 03:55:51 -0400 Received: by mail-wr1-f70.google.com with SMTP id m8-20020adfc588000000b0020c4edd8a57so1746642wrg.10 for ; Thu, 12 May 2022 00:55:51 -0700 (PDT) Received: from wheatley.localdomain (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id o12-20020a05600c4fcc00b003942a244ec8sm1988515wmq.13.2022.05.12.00.55.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 May 2022 00:55:48 -0700 (PDT) Received: from wheatley.redhat.com (wheatley.k8r.cz [127.0.0.1]) by wheatley.localdomain (Postfix) with ESMTP id 4BB6F6D329A0 for ; Thu, 12 May 2022 09:55:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652342163; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=XYvGUhtOaEpMFY5y/T1zeSinJJffLiDeLg2Z9qtyUiM=; b=jNjWD+YrGOjlwc3Aa0vGV0OXh/wrIOd7OdjRPvI49BstbQ16QbQ2hu8fHzq87V5ek8JNIQ SSK63yvMTvyPvbcCzIZoMuf2n7eq93QdIhhxV0ZwgbdOoue5v1EU1llV4gRJw4ogPi0RNN 3kfx8eEJVX5DQSvuowPxwqByfptoBgk= X-MC-Unique: ob8fPaIIPMKQM_sZOcbRYA-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: JjHdSfjaMV65GNhQWOy_DQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XYvGUhtOaEpMFY5y/T1zeSinJJffLiDeLg2Z9qtyUiM=; b=ThDlQ89N9rP6l54ZsSnXirIHTsO5X5/c/aI4zLxc9uKM3kBEmaw57071T2JRcb5iPf A8HvfJS9Un6kV1ZHHcyiuxsJAn89Y/7kvJjxgU8T+Z+tBA/NY7R4g52dDicQkstPxxQU mQNSu+2qxLFJyqOqm0llh+NHp5S/lwsD5DFoSD1/A2LcTmKwZ/PsA08GA0a7hsUe1mJR 1H25HeVRuuTaIDq569AlScbZ6Aac0VFunRZyzgC9KdbdlKpnGHDVWn5J5oO89MFCJMS4 G1zFWjuOFT9Z9iSrHaDe3+vE8xFh3eRmlpOoPwHCaQX8CEjKByswrPwFunRxTpMRhkxk HmNw== X-Gm-Message-State: AOAM5307PAia7/GyANstfnO5mZGqzCF3lMARD8+Ygj3cEboRtGnlDrQB dd2WoUXyrovnzbyHR6QlX7annJUoc/UxQ6Eq1eLd2YLD1BUNzTyoeCLxSsXyc8up9/gqQyn+SOA dPvNd0AxopNTcXa86aU2Mb7JbhN64l44nsjYCNq7PT7YNOGgC6PgOTORTAAlAQ4yzJ0BqWt4= X-Received: by 2002:adf:f90d:0:b0:20c:de32:4d35 with SMTP id b13-20020adff90d000000b0020cde324d35mr5567679wrr.583.1652342150051; Thu, 12 May 2022 00:55:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxSfs4OsNNmQ2ioDvZjOtTE1SoCAEXMTMwEUgKQP4IZvd/llGuCDJcyezYAc/UyIWkVvmZETw== X-Received: by 2002:adf:f90d:0:b0:20c:de32:4d35 with SMTP id b13-20020adff90d000000b0020cde324d35mr5567656wrr.583.1652342149612; Thu, 12 May 2022 00:55:49 -0700 (PDT) From: Martin Kletzander To: libvir-list@redhat.com Subject: [libvirt PATCH 2/4] tests: Adjust for invalid qemu command combinations Date: Thu, 12 May 2022 09:55:46 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1652342166144100005 Content-Type: text/plain; charset="utf-8"; x-default="true" Everything spice is not supported (and does not make sense) without spice graphics. For some tests I also added cirrus VGA capability so that the XML stays simple and libvirt can guess a default video model rather than adding= too much of an irrelevant XML into the individual tests. Signed-off-by: Martin Kletzander --- .../audio-spice-best.x86_64-4.1.0.args | 3 +- .../audio-spice-best.x86_64-latest.args | 3 +- tests/qemuxml2argvdata/audio-spice-best.xml | 7 +++++ .../audio-spice-full.x86_64-latest.args | 3 +- tests/qemuxml2argvdata/audio-spice-full.xml | 7 +++++ .../audio-spice-minimal.x86_64-4.1.0.args | 3 +- .../audio-spice-minimal.x86_64-latest.args | 3 +- .../qemuxml2argvdata/audio-spice-minimal.xml | 7 +++++ .../channel-virtio-default.args | 9 +++--- .../channel-virtio-default.xml | 1 + .../smartcard-passthrough-spicevmc.args | 7 +++-- .../smartcard-passthrough-spicevmc.xml | 1 + tests/qemuxml2argvdata/usb-redir-boot.args | 7 +++-- tests/qemuxml2argvdata/usb-redir-boot.xml | 1 + .../usb-redir-filter-version.args | 7 +++-- .../usb-redir-filter-version.xml | 1 + tests/qemuxml2argvdata/usb-redir-filter.args | 7 +++-- tests/qemuxml2argvdata/usb-redir-filter.xml | 1 + tests/qemuxml2argvdata/usb-redir.args | 7 +++-- tests/qemuxml2argvdata/usb-redir.xml | 1 + tests/qemuxml2argvtest.c | 19 ++++++++---- .../smartcard-passthrough-spicevmc.xml | 11 +++++-- .../usb-redir-filter-version.xml | 11 +++++-- tests/qemuxml2xmloutdata/usb-redir-filter.xml | 11 +++++-- tests/qemuxml2xmloutdata/usb-redir.xml | 11 +++++-- tests/qemuxml2xmltest.c | 30 ++++++++++++++----- 26 files changed, 134 insertions(+), 45 deletions(-) diff --git a/tests/qemuxml2argvdata/audio-spice-best.x86_64-4.1.0.args b/te= sts/qemuxml2argvdata/audio-spice-best.x86_64-4.1.0.args index d5d42384b1b5..ca1d3ac4cef0 100644 --- a/tests/qemuxml2argvdata/audio-spice-best.x86_64-4.1.0.args +++ b/tests/qemuxml2argvdata/audio-spice-best.x86_64-4.1.0.args @@ -28,7 +28,6 @@ QEMU_AUDIO_DAC_FIXED_FMT=3Df32 \ -overcommit mem-lock=3Doff \ -smp 1,sockets=3D1,cores=3D1,threads=3D1 \ -uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \ --display none \ -no-user-config \ -nodefaults \ -chardev socket,id=3Dcharmonitor,fd=3D1729,server=3Don,wait=3Doff \ @@ -40,5 +39,7 @@ QEMU_AUDIO_DAC_FIXED_FMT=3Df32 \ -device piix3-usb-uhci,id=3Dusb,bus=3Dpci.0,addr=3D0x1.0x2 \ -drive file=3D/dev/cdrom,format=3Draw,if=3Dnone,id=3Ddrive-ide0-1-0,readon= ly=3Don \ -device ide-cd,bus=3Dide.1,unit=3D0,drive=3Ddrive-ide0-1-0,id=3Dide0-1-0,b= ootindex=3D1 \ +-spice port=3D0,seamless-migration=3Don \ +-device cirrus-vga,id=3Dvideo0,bus=3Dpci.0,addr=3D0x2 \ -sandbox on,obsolete=3Ddeny,elevateprivileges=3Ddeny,spawn=3Ddeny,resource= control=3Ddeny \ -msg timestamp=3Don diff --git a/tests/qemuxml2argvdata/audio-spice-best.x86_64-latest.args b/t= ests/qemuxml2argvdata/audio-spice-best.x86_64-latest.args index b0d69916e2cc..4fa37d994afb 100644 --- a/tests/qemuxml2argvdata/audio-spice-best.x86_64-latest.args +++ b/tests/qemuxml2argvdata/audio-spice-best.x86_64-latest.args @@ -18,7 +18,6 @@ XDG_CONFIG_HOME=3D/tmp/lib/domain--1-QEMUGuest1/.config \ -overcommit mem-lock=3Doff \ -smp 1,sockets=3D1,cores=3D1,threads=3D1 \ -uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \ --display none \ -no-user-config \ -nodefaults \ -chardev socket,id=3Dcharmonitor,fd=3D1729,server=3Don,wait=3Doff \ @@ -32,5 +31,7 @@ XDG_CONFIG_HOME=3D/tmp/lib/domain--1-QEMUGuest1/.config \ -blockdev '{"node-name":"libvirt-1-format","read-only":true,"driver":"raw"= ,"file":"libvirt-1-storage"}' \ -device '{"driver":"ide-cd","bus":"ide.1","unit":0,"drive":"libvirt-1-form= at","id":"ide0-1-0","bootindex":1}' \ -audiodev '{"id":"audio1","driver":"spice","timer-period":50,"in":{"mixing= -engine":true,"fixed-settings":true,"voices":1,"frequency":44100,"channels"= :2,"format":"s16"},"out":{"mixing-engine":true,"fixed-settings":true,"voice= s":2,"frequency":22050,"channels":4,"format":"f32"}}' \ +-spice port=3D0,seamless-migration=3Don \ +-device '{"driver":"cirrus-vga","id":"video0","bus":"pci.0","addr":"0x2"}'= \ -sandbox on,obsolete=3Ddeny,elevateprivileges=3Ddeny,spawn=3Ddeny,resource= control=3Ddeny \ -msg timestamp=3Don diff --git a/tests/qemuxml2argvdata/audio-spice-best.xml b/tests/qemuxml2ar= gvdata/audio-spice-best.xml index f38175a913ee..80594ebca65c 100644 --- a/tests/qemuxml2argvdata/audio-spice-best.xml +++ b/tests/qemuxml2argvdata/audio-spice-best.xml @@ -30,6 +30,9 @@ + + + +