From nobody Thu May 9 02:05:02 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1636052065; cv=none; d=zohomail.com; s=zohoarc; b=dDU3EfTqDENO/Dqb63Dizxv6t3xPPvrkHs1fE3/g7dVZO+LIYQVNZpXlBso/GOzoj3rZEbIF+MYeVXmoK/s/wzB+hDDA7isqzN8Z2fKRKo55Zm6jE0HKXU0+3PbFETDq4ba3VyxDrRt7AghdZH6buF2s0XmuxM5XFIEYS1zclrI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1636052065; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=2UV20vayyjm3I5EgTWdV66HaUFmCL3lSt1Rrh9xjIDQ=; b=QIEgeReywylN/jCGGdEPnJnyhGdfXAv/xmGOdk/HUZZPg2j3WobF0xh7gCxNEy3rP65dUDisT+iCXgHlLnC4urPiReuoXBxUkzAOzfCtKDkfzzY/Hpp6DDAqbIfdRRujcd3XaVr3Fo2hu79zcIxaKdx5RKPl+KRrryqW8B+zwyI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1636052065225652.4828224680343; Thu, 4 Nov 2021 11:54:25 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-259-wFMmJyQ4MC6tZpLCONY_rA-1; Thu, 04 Nov 2021 14:54:20 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B984B800053; Thu, 4 Nov 2021 18:54:13 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 60D9E1002391; Thu, 4 Nov 2021 18:54:10 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 331D81806D03; Thu, 4 Nov 2021 18:54:08 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1A4Is6bZ014160 for ; Thu, 4 Nov 2021 14:54:06 -0400 Received: by smtp.corp.redhat.com (Postfix) id A89791B472; Thu, 4 Nov 2021 18:54:06 +0000 (UTC) Received: from rein.int.mamuti.net (unknown [10.40.195.139]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7CFCF13ABD for ; Thu, 4 Nov 2021 18:54:00 +0000 (UTC) Received: by rein.int.mamuti.net (Postfix, from userid 500) id 70C4B18013D; Thu, 4 Nov 2021 19:53:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636052064; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=2UV20vayyjm3I5EgTWdV66HaUFmCL3lSt1Rrh9xjIDQ=; b=Mm8/M7CXiysaT9B3p91ogKr8d/iSBKGm9k1wLGQq1y3fbhSuK4kBxlbDGK4x1uNYXGXTOF 40voDZVvX7VfGjgh8XywXvc3YRoFfzqm9JE1CRhhvSm/rE3TMkg852wdY8XZfjAfOv0VWU KAdF0x9OwZq4INOvkHVENEUo4dsrHYY= X-MC-Unique: wFMmJyQ4MC6tZpLCONY_rA-1 From: Jiri Denemark To: libvir-list@redhat.com Subject: [libvirt PATCH] util: Avoid null pointer dereference when setting QoS on OVS Date: Thu, 4 Nov 2021 19:53:43 +0100 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1636052066785100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Jiri Denemark Reviewed-by: Michal Privoznik --- src/util/virnetdevopenvswitch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virnetdevopenvswitch.c b/src/util/virnetdevopenvswitc= h.c index 250726a633..5dab545037 100644 --- a/src/util/virnetdevopenvswitch.c +++ b/src/util/virnetdevopenvswitch.c @@ -759,7 +759,7 @@ virNetDevOpenvswitchInterfaceSetQos(const char *ifname, } virCommandAddArgList(cmd, vmid_ex_id, ifname_ex_id, NULL); if (virCommandRun(cmd, NULL) < 0) { - if (*queue_uuid) { + if (queue_uuid && *queue_uuid) { virReportError(VIR_ERR_INTERNAL_ERROR, _("Unable to set queue configuration on por= t %s"), ifname); } else { --=20 2.33.1