From nobody Mon Feb 9 00:07:51 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1614183556; cv=none; d=zohomail.com; s=zohoarc; b=S1gk2MqamAxplRaVIl+pHKVjP5ULKnSoi3JRZYgp6Mq1i1NFq04QlR+V8UcUtUT/R3iR6Chq2XA0Kjie6gCEYtQtPN1KERFg5mx8ZTAoTrmKJm6mYkJXFi3xANfnKmbXQeZHz+tdVkXDSOXz9Uk199NdKESJ50SxA0+ApFJDg8E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614183556; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+UVwHo7iGOMCDbtAC5UUjXmxSjA2hgKRVIfEygZIYkg=; b=TkLoKpxnB6TiqCqqKEvMUlw0HaH0IlLOWwLAFaqT8NuuZ2pC3czk/wYuKpd2dFke2rFQo/fttvGgVSF6n8FUz/KhuEI5i+705b/1XO678Xm5dPnQ9ecmpdEXQMYk/EkABZw9ocGMGznHCg3xNuI1WtoMpaUfQCcNe3t/RFqRd3M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1614183556060675.5921872531818; Wed, 24 Feb 2021 08:19:16 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-597-neq1DEecM2SkfyIGP7Fdvg-1; Wed, 24 Feb 2021 11:18:12 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0A0DD801977; Wed, 24 Feb 2021 16:18:05 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D5BF35D9E3; Wed, 24 Feb 2021 16:18:04 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9450218077D7; Wed, 24 Feb 2021 16:18:04 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 11OGHtl5015818 for ; Wed, 24 Feb 2021 11:17:55 -0500 Received: by smtp.corp.redhat.com (Postfix) id 2540860CDE; Wed, 24 Feb 2021 16:17:55 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7783660D79 for ; Wed, 24 Feb 2021 16:17:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614183555; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=+UVwHo7iGOMCDbtAC5UUjXmxSjA2hgKRVIfEygZIYkg=; b=KdP1QnN75I3uKWLPyXK2lJK1lJyhp2KmOa+spVHR0cQLWSjgLX9aqY2u9KAiWOLzr6lOU5 8qW1PSvDi1wM6H0Dr4miVN66NAkE8ezOzMebJm4fdnuhPyz1sOJYFU2VWG9aYq4OwMXM9U guxsPGfeGsGuSUMXENv1hRMPfxh2WM8= X-MC-Unique: neq1DEecM2SkfyIGP7Fdvg-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 26/33] hyperv: abort() failure of wsmc_fault_new() Date: Wed, 24 Feb 2021 17:17:01 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The function just allocates a helper object. Reporting errors would be pointless when we encounter OOM situation. Signed-off-by: Peter Krempa --- src/hyperv/hyperv_wmi.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c index 8bb6f591f1..2a898cdf03 100644 --- a/src/hyperv/hyperv_wmi.c +++ b/src/hyperv/hyperv_wmi.c @@ -92,12 +92,8 @@ hypervVerifyResponse(WsManClient *client, WsXmlDocH resp= onse, } if (wsmc_check_for_fault(response)) { - fault =3D wsmc_fault_new(); - - if (fault =3D=3D NULL) { - virReportOOMError(); - return -1; - } + if (!(fault =3D wsmc_fault_new())) + abort(); wsmc_get_fault_data(response, fault); --=20 2.29.2