From nobody Mon Feb 9 08:05:26 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1633622205; cv=none; d=zohomail.com; s=zohoarc; b=P4DGokckLch1FEdMAzqB4XX6rNyVJj6nKtssAHGPVy4lHe00U55+J0aa4kTUTLjzErnjT5Kdvgx0MKsR3Cx6+/U03U6+qkdawhlGRwbmLItlKF6XqN2iq5SivHS4VaJoP3WkMljDtC2ePSq+Iw6KgO8nIceI5SvmACunXlLNwV0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1633622205; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=gw++2Ngx2qQba1VW9IzoKGHm+EkXp06E9reEUoHScQU=; b=ckNoSJ3tQlfn3Y0wLbaSfqUBHopMzSJ9ueWhdc4wBrjMb3kzpaqJFqj5owjXdwkTj/bi5i4l/6uxYXLv62INiq79+AesYW+n+PFEhCUFEtpe1WQOADOnx2ybSGsoxoBYuQMoo0Y9XLTJheX0UD62mIm8S5JXmideYX+IPE/s8uM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1633622205709158.93702450025012; Thu, 7 Oct 2021 08:56:45 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-540-NUit5hWZMrS2J-BgMlwMoA-1; Thu, 07 Oct 2021 11:56:43 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0B4C2BAF8A; Thu, 7 Oct 2021 15:50:48 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D59B5258659; Thu, 7 Oct 2021 15:50:08 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 99B7E1806D01; Thu, 7 Oct 2021 15:50:08 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 197FJ6gg023810 for ; Thu, 7 Oct 2021 11:19:06 -0400 Received: by smtp.corp.redhat.com (Postfix) id E33BF5D6BA; Thu, 7 Oct 2021 15:19:06 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.40.208.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id 53D225D740 for ; Thu, 7 Oct 2021 15:19:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633622204; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=gw++2Ngx2qQba1VW9IzoKGHm+EkXp06E9reEUoHScQU=; b=JFQPQoBt9WyQG0JVCsvn5N4scUB75o3BhSSTF3o65EuK6/Scx+sGgizFBHUjOs62H0lr8x da1UX4frxh2HKqOip9PjvOvSyMBls2rGdcUnP24ZyT9Ark9sXDqwiHnyqv3Xd3E+biFspY s5p8f8AIwNuJMj0ogPTTO1D1yVxTiyY= X-MC-Unique: NUit5hWZMrS2J-BgMlwMoA-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 031/103] qemuBuildDeviceAddressPCIStr: Make error messages easier to find Date: Thu, 7 Oct 2021 17:17:19 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1633622207010100001 Content-Type: text/plain; charset="utf-8" Per coding guidelines error messages should not be broken into lines and variables should be separated by apostrophes. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_command.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index aeb04207b2..ee7a9f3060 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -345,9 +345,7 @@ qemuBuildDeviceAddressPCIStr(virBuffer *buf, if (!contAlias) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("Device alias was not set for PCI " - "controller with index %u required " - "for device at address %s"), + _("Device alias was not set for PCI control= ler with index '%u' required for device at address '%s'"), info->addr.pci.bus, devStr); return -1; } @@ -372,9 +370,7 @@ qemuBuildDeviceAddressPCIStr(virBuffer *buf, if (!contAlias) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("Could not find PCI " - "controller with index %u required " - "for device at address %s"), + _("Could not find PCI controller with index '%u' re= quired for device at address '%s'"), info->addr.pci.bus, devStr); return -1; } --=20 2.31.1