From nobody Sun Feb 8 14:07:14 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1557414997; cv=none; d=zoho.com; s=zohoarc; b=P3EJ28yfCc8SCtoew5Mr32wVq5x/YWV7xizKX6uQ779nVMtCZxo9I2kkcIcN+jGBqTR5s/GNak4vEyq6Wg5DVPJtn+ry+BuFcDj0lLOvv/rUmdosZRfCr4yKFnT95gUglGtTtYOt0V4GDQSpEZLgRiysx0tP1kaG1YnpfjZjKtg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1557414997; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=WbJ9DWadyihItzdTfEeZPPxgC/FZ5x6ReVBoc+F1i+s=; b=gOwr8nlC/MbPuWNnSm9kJMDw2VIiwvx5FrwSlzSapru5QdNvd9s/49WfKTCyv00wGaJEMkJnHNrGWb8ILY4TklJtwZD4LPBrEyJFH4gwJFKl7kamBYNRDlnUPxVmDaW9/sKu7yRFphghaCyO9K9V3o85y4EU5ziroyUNmLQZ8+w= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1557414997658881.7567819189406; Thu, 9 May 2019 08:16:37 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9FD2EC070E13; Thu, 9 May 2019 15:16:29 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 41C045DE78; Thu, 9 May 2019 15:16:29 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7FB2D18089D1; Thu, 9 May 2019 15:16:24 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x49FGMws019202 for ; Thu, 9 May 2019 11:16:22 -0400 Received: by smtp.corp.redhat.com (Postfix) id 7A3FB27BCE; Thu, 9 May 2019 15:16:22 +0000 (UTC) Received: from antique-work.brq.redhat.com (unknown [10.43.2.63]) by smtp.corp.redhat.com (Postfix) with ESMTP id 02CBD27BBF for ; Thu, 9 May 2019 15:16:21 +0000 (UTC) From: Pavel Hrdina To: libvir-list@redhat.com Date: Thu, 9 May 2019 17:16:15 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 1/2] node_device_udev: remove deprecated logging function X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 09 May 2019 15:16:36 +0000 (UTC) Content-Type: text/plain; charset="utf-8" The function was deprecated in udev 219 and all the supported OSes don't have older version of udev or systemd. Signed-off-by: Pavel Hrdina Reviewed-by: J=C3=A1n Tomko --- m4/virt-udev.m4 | 5 ---- src/node_device/node_device_udev.c | 41 ------------------------------ 2 files changed, 46 deletions(-) diff --git a/m4/virt-udev.m4 b/m4/virt-udev.m4 index be7dba5d2d..cf977c650b 100644 --- a/m4/virt-udev.m4 +++ b/m4/virt-udev.m4 @@ -30,11 +30,6 @@ AC_DEFUN([LIBVIRT_CHECK_UDEV],[ fi =20 if test "$with_udev" =3D "yes" ; then - PKG_CHECK_EXISTS([libudev >=3D 218], [with_udev_logging=3Dno], [with_= udev_logging=3Dyes]) - if test "$with_udev_logging" =3D "yes" ; then - AC_DEFINE_UNQUOTED([HAVE_UDEV_LOGGING], 1, [whether libudev loggin= g can be used]) - fi - old_CFLAGS=3D"$CFLAGS" old_LIBS=3D"$LIBS" CFLAGS=3D"$CFLAGS $UDEV_CFLAGS" diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_devi= ce_udev.c index 7dd9804a0e..5df2fd72f3 100644 --- a/src/node_device/node_device_udev.c +++ b/src/node_device/node_device_udev.c @@ -318,43 +318,6 @@ udevGenerateDeviceName(struct udev_device *device, } =20 =20 -#if HAVE_UDEV_LOGGING -typedef void -(*udevLogFunctionPtr)(struct udev *udev, - int priority, - const char *file, - int line, - const char *fn, - const char *format, - va_list args); - -static void -ATTRIBUTE_FMT_PRINTF(6, 0) -udevLogFunction(struct udev *udev ATTRIBUTE_UNUSED, - int priority, - const char *file, - int line, - const char *fn, - const char *fmt, - va_list args) -{ - virBuffer buf =3D VIR_BUFFER_INITIALIZER; - char *format =3D NULL; - - virBufferAdd(&buf, fmt, -1); - virBufferTrim(&buf, "\n", -1); - - format =3D virBufferContentAndReset(&buf); - - virLogVMessage(&virLogSelf, - virLogPriorityFromSyslog(priority), - file, line, fn, NULL, format ? format : fmt, args); - - VIR_FREE(format); -} -#endif - - static int udevTranslatePCIIds(unsigned int vendor, unsigned int product, @@ -1872,10 +1835,6 @@ nodeStateInitialize(bool privileged, _("failed to create udev context")); goto cleanup; } -#if HAVE_UDEV_LOGGING - /* cast to get rid of missing-format-attribute warning */ - udev_set_log_fn(udev, (udevLogFunctionPtr) udevLogFunction); -#endif =20 virObjectLock(priv); =20 --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list