From nobody Sun Feb 8 11:59:24 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1638977438; cv=none; d=zohomail.com; s=zohoarc; b=kGbSFlrvDZJy1HJFt6Sn+DHuufF3Z1R4s7xjrnPbY9LqPxzMVdTgsywO05xB8CH+we1rrBUXUno0Ax1d+7A9LFmSpv6Tk1qeup2ZrtxTY3HfhkXtH6cOwiAiwT+sAEJBDgtgbKF3XTIZ1r0yqJ2teK0OxyfX0IJrWaA8eK4UbqU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1638977438; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=x+KQY+WL5ga0STI2sBV8UFOw06vvbsq/vEdXMIInDNo=; b=bAzEDkUEfZJ5excGwoiBWWmCdZjmZX5YlNXDf81JR1OEhHtcUS5ClaciARVcnJ3hgVOelpWwr/Dssz/1aKVBes4U9QyIsrYmqfptYWLiH7C35TSy8pWX5GVUYTJGH++fjQ+4B5egOEKCDqJjkxEJbf4CcZS3VW49osQD602PzTE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1638977438733543.6595965671285; Wed, 8 Dec 2021 07:30:38 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-530-Hcly8yifMZuIgFnCZyJ5uA-1; Wed, 08 Dec 2021 10:30:35 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3C61D101D608; Wed, 8 Dec 2021 15:30:30 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1500960BF1; Wed, 8 Dec 2021 15:30:30 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id DA5991809CB9; Wed, 8 Dec 2021 15:30:29 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1B8FUAGq032183 for ; Wed, 8 Dec 2021 10:30:10 -0500 Received: by smtp.corp.redhat.com (Postfix) id 36EAC794D7; Wed, 8 Dec 2021 15:30:10 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id B2583794D6 for ; Wed, 8 Dec 2021 15:30:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1638977437; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=x+KQY+WL5ga0STI2sBV8UFOw06vvbsq/vEdXMIInDNo=; b=bg7IItWIj2sLhixLy0osyIuUG+sS5aniqfSgw+Q+XJdbAeeNtSDVCTL93O/s64IHAUuEhM xFUdvUyHB3apwlNgHIasMm5Ni7Cho7JiauA4Ys1dzBb696CHbowRcd1V7nISY20Iu7/Os4 x/9FqBJ1KZTG/gfyTWwB9TaAUCKcZVI= X-MC-Unique: Hcly8yifMZuIgFnCZyJ5uA-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH v1 6/7] meson: Require XDR for wireshark Date: Wed, 8 Dec 2021 16:29:08 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1638977439586100001 Content-Type: text/plain; charset="utf-8" The way our wireshark dissector works is by providing decoders for primitive types (like integers, string, double, etc.) and then parsing virsomethingprotocol.x files and generating complex decoders for RPC. This obviously means that XDR is required for the dissector, but corresponding check was missing. Signed-off-by: Michal Privoznik --- meson.build | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/meson.build b/meson.build index cea8bbfa0c..c5f0ee7287 100644 --- a/meson.build +++ b/meson.build @@ -1310,6 +1310,16 @@ endif =20 wireshark_version =3D '2.6.0' wireshark_dep =3D dependency('wireshark', version: '>=3D' + wireshark_vers= ion, required: get_option('wireshark_dissector')) +if wireshark_dep.found() + if not xdr_dep.found() + if get_option('wireshark_dissector').enabled() + error('XDR is required for wireshark plugin') + else + wireshark_dep =3D dependency('', required: false) + endif + endif +endif + if wireshark_dep.found() wireshark_plugindir =3D get_option('wireshark_plugindir') if wireshark_plugindir =3D=3D '' --=20 2.32.0