From nobody Wed Mar 12 17:06:46 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1740587717627152.4453758717259; Wed, 26 Feb 2025 08:35:17 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 821C51723; Wed, 26 Feb 2025 11:35:16 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 8712218EA; Wed, 26 Feb 2025 11:31:48 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 04A9B16B2; Wed, 26 Feb 2025 11:31:40 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 7B3631858 for ; Wed, 26 Feb 2025 11:31:29 -0500 (EST) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-685-dzAMPZfvM5GU14HSez2N7w-1; Wed, 26 Feb 2025 11:31:27 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1481419783B6 for ; Wed, 26 Feb 2025 16:31:27 +0000 (UTC) Received: from speedmetal.lan (unknown [10.44.22.10]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 3B6B1180035E for ; Wed, 26 Feb 2025 16:31:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740587489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/0ZguF+96TwB+VvZI4DB0/lSrP9zZ4q7E21iuptDMYg=; b=AtqmnDGk1sh8kexYZUAzq9D+x6YEOfG48yiG0gdTAG8PCE+5iQp/E+HvO4zOI5/3qjEjUe KqXpTa9vn+tcnzSAfOq4JX0Rl6E2KIslR1VLdCHYY6HBkO9RejUNEiL+Nm905QUMWdyKBp yGB1r9ZA18u4T0de9TIPwwUYY9sIqy0= X-MC-Unique: dzAMPZfvM5GU14HSez2N7w-1 X-Mimecast-MFC-AGG-ID: dzAMPZfvM5GU14HSez2N7w_1740587487 From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 10/10] qemuDomainGetGuestInfo: Remove temporary infrastructure Date: Wed, 26 Feb 2025 17:31:10 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: tELD5CAJ32UV3nobUvIGqm681dMQ3TDqkZn3jkXyaSI_1740587487 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: BCU3ZOKIQLDZ65D22SC3YXEWTHUVEZC4 X-Message-ID-Hash: BCU3ZOKIQLDZ65D22SC3YXEWTHUVEZC4 X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1740587719571019100 Content-Type: text/plain; charset="utf-8" Now that the refactor was completed the helper infrastructure can be removed. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 5d91bd1a93..c69074766b 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -19372,7 +19372,6 @@ qemuDomainGetGuestInfo(virDomainPtr dom, bool format_load =3D false; size_t i; g_autoptr(virTypedParamList) list =3D virTypedParamListNew(); - g_autoptr(virTypedParamList) tmplist =3D NULL; virCheckFlags(0, -1); @@ -19481,11 +19480,6 @@ qemuDomainGetGuestInfo(virDomainPtr dom, virTypedParamListAddDouble(list, load15m, "load.15m"); } - /* temporarily allow the old and new construction style to coexist */ - tmplist =3D virTypedParamListFromParams(params, *nparams); - virTypedParamListConcat(tmplist, &list); - list =3D g_steal_pointer(&tmplist); - if (virTypedParamListSteal(list, params, nparams) < 0) goto cleanup; --=20 2.48.1