From nobody Mon Feb 9 00:50:20 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 174187361371732.813309477146845; Thu, 13 Mar 2025 06:46:53 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 220292151; Thu, 13 Mar 2025 09:46:53 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id AE66D2158; Thu, 13 Mar 2025 09:44:58 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 6FC49212C; Thu, 13 Mar 2025 09:44:55 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 261F41F54 for ; Thu, 13 Mar 2025 09:44:49 -0400 (EDT) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-387-cHhZE95sM-SSKRd1zYP5SQ-1; Thu, 13 Mar 2025 09:44:47 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C819B195608B for ; Thu, 13 Mar 2025 13:44:46 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.3.236]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id F03141955BCB for ; Thu, 13 Mar 2025 13:44:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741873488; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V8FIFWXJq3AtA2ngJTmyijAoGu0YePAa5tX49SuUVDk=; b=TBfxle6sGsRRfgv4WjdTkkvPtofJhhDC6F6c+Bpbo1aTN3V0e9YSNR1tFcQmMsGCzL/Gg7 egi2lJHlkWRC3c9LnUKxnLm7ULiOIoa3e63g9H+3hYdyvltoMHFfKWRrlVGveGJdSAjgId vp5Qs85TPU5j9NmHt9sN3S4zq4gRZj0= X-MC-Unique: cHhZE95sM-SSKRd1zYP5SQ-1 X-Mimecast-MFC-AGG-ID: cHhZE95sM-SSKRd1zYP5SQ_1741873486 From: Michal Privoznik To: devel@lists.libvirt.org Subject: [PATCH 5/6] ch: Unref @cfg in virCHProcessStop() Date: Thu, 13 Mar 2025 14:44:37 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: UtCMWptSZg60Tqf1jai5Bf9KYcKN_xIbgNX_gt70NO8_1741873486 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: Q4X2VWQHXUBQZKUVE3RCGS5B32PICO2Z X-Message-ID-Hash: Q4X2VWQHXUBQZKUVE3RCGS5B32PICO2Z X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1741873615799019000 Content-Type: text/plain; charset="utf-8"; x-default="true" At the beginning of virCHProcessStop() the ref to driver config is obtained (via virCHDriverGetConfig()), but corresponding unref call is lacking. Use g_autoptr() to make sure the config is unrefed always. Signed-off-by: Michal Privoznik Reviewed-by: Peter Krempa --- src/ch/ch_process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ch/ch_process.c b/src/ch/ch_process.c index cbf98faaf0..79f5990cc1 100644 --- a/src/ch/ch_process.c +++ b/src/ch/ch_process.c @@ -997,11 +997,11 @@ virCHProcessStop(virCHDriver *driver, virDomainObj *vm, virDomainShutoffReason reason) { + g_autoptr(virCHDriverConfig) cfg =3D virCHDriverGetConfig(driver); int ret; int retries =3D 0; unsigned int hostdev_flags =3D VIR_HOSTDEV_SP_PCI; virCHDomainObjPrivate *priv =3D vm->privateData; - virCHDriverConfig *cfg =3D virCHDriverGetConfig(driver); virDomainDef *def =3D vm->def; size_t i; =20 --=20 2.48.1