From nobody Wed Dec 17 04:18:48 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1493276547996648.3957735389957; Thu, 27 Apr 2017 00:02:27 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 60943811AC; Thu, 27 Apr 2017 07:02:26 +0000 (UTC) Received: from colo-mx.corp.redhat.com (unknown [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 373DE88D85; Thu, 27 Apr 2017 07:02:26 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E2ACD5EC6B; Thu, 27 Apr 2017 07:02:25 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v3R72AMg007671 for ; Thu, 27 Apr 2017 03:02:10 -0400 Received: by smtp.corp.redhat.com (Postfix) id 5ED0393414; Thu, 27 Apr 2017 07:02:10 +0000 (UTC) Received: from moe.brq.redhat.com (dhcp129-131.brq.redhat.com [10.34.129.131]) by smtp.corp.redhat.com (Postfix) with ESMTP id CA65093406 for ; Thu, 27 Apr 2017 07:02:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 60943811AC Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=libvir-list-bounces@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 60943811AC From: Michal Privoznik To: libvir-list@redhat.com Date: Thu, 27 Apr 2017 09:02:00 +0200 Message-Id: In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 4/4] cpu: Avoid c99 style of assembler X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 27 Apr 2017 07:02:27 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" In c89 - the standard we claim to support - there is no asm() rather than __asm__(). Switch from the former to the latter. Signed-off-by: Michal Privoznik --- src/cpu/cpu_ppc64.c | 4 ++-- src/cpu/cpu_x86.c | 44 ++++++++++++++++++++++---------------------- 2 files changed, 24 insertions(+), 24 deletions(-) diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c index f64592b..5d65929 100644 --- a/src/cpu/cpu_ppc64.c +++ b/src/cpu/cpu_ppc64.c @@ -732,8 +732,8 @@ virCPUppc64GetHost(virCPUDefPtr cpu, data->len =3D 1; =20 #if defined(__powerpc__) || defined(__powerpc64__) - asm("mfpvr %0" - : "=3Dr" (data->pvr[0].value)); + __asm__("mfpvr %0" + : "=3Dr" (data->pvr[0].value)); #endif data->pvr[0].mask =3D 0xfffffffful; =20 diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index 53359ff..c971aa3 100644 --- a/src/cpu/cpu_x86.c +++ b/src/cpu/cpu_x86.c @@ -2085,32 +2085,32 @@ static inline void cpuidCall(virCPUx86CPUID *cpuid) { # if __x86_64__ - asm("xor %%ebx, %%ebx;" /* clear the other registers as some cpuid */ - "xor %%edx, %%edx;" /* functions may use them as additional argume= nts */ - "cpuid;" - : "=3Da" (cpuid->eax), - "=3Db" (cpuid->ebx), - "=3Dc" (cpuid->ecx), - "=3Dd" (cpuid->edx) - : "a" (cpuid->eax_in), - "c" (cpuid->ecx_in)); + __asm__("xor %%ebx, %%ebx;" /* clear the other registers as some cpuid= */ + "xor %%edx, %%edx;" /* functions may use them as additional ar= guments */ + "cpuid;" + : "=3Da" (cpuid->eax), + "=3Db" (cpuid->ebx), + "=3Dc" (cpuid->ecx), + "=3Dd" (cpuid->edx) + : "a" (cpuid->eax_in), + "c" (cpuid->ecx_in)); # else /* we need to avoid direct use of ebx for CPUID output as it is used * for global offset table on i386 with -fPIC */ - asm("push %%ebx;" - "xor %%ebx, %%ebx;" /* clear the other registers as some cpuid */ - "xor %%edx, %%edx;" /* functions may use them as additional argume= nts */ - "cpuid;" - "mov %%ebx, %1;" - "pop %%ebx;" - : "=3Da" (cpuid->eax), - "=3Dr" (cpuid->ebx), - "=3Dc" (cpuid->ecx), - "=3Dd" (cpuid->edx) - : "a" (cpuid->eax_in), - "c" (cpuid->ecx_in) - : "cc"); + __asm__("push %%ebx;" + "xor %%ebx, %%ebx;" /* clear the other registers as some cpuid= */ + "xor %%edx, %%edx;" /* functions may use them as additional ar= guments */ + "cpuid;" + "mov %%ebx, %1;" + "pop %%ebx;" + : "=3Da" (cpuid->eax), + "=3Dr" (cpuid->ebx), + "=3Dc" (cpuid->ecx), + "=3Dd" (cpuid->edx) + : "a" (cpuid->eax_in), + "c" (cpuid->ecx_in) + : "cc"); # endif } =20 --=20 2.10.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list