From nobody Sun Feb 8 14:56:59 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1602074167; cv=none; d=zohomail.com; s=zohoarc; b=HVFdAl0+O+41zsnH8xXqBU2rpARCybbm6P53byGwbCQcYoRM7m3t0ZewEDQz9YUWS/FC6oUILGh9rXx1gilFtH+6TOHWWiJjGznpR4RIlrTlXXk/TjI6s4l1WQcRjylYVxYek15pa+M5nZpFN2rYPvvPJGIYRjuKPMWCBAfTX88= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602074167; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=xoIgAJeZXDhDQ86H8FYbASMdw3Ui364XzgUMTiaGe9s=; b=HH4+VA7KhKIgODEaDQ6Ts+w6pozpXKsSoXz83W7K9t0tYuLRKGfgKkEbCXVJ0NkpRuoIK5xuiq8iePb+NxNK1SZEyctCBC7bcCiJGMdvMaVnnM6xzoL8mS+cyKJps6mBbRKrnh6loNyUDS+ogISGhIWh8zRVuaMglEgKWXZHbh4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1602074167317174.2496290895475; Wed, 7 Oct 2020 05:36:07 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-525-OTPNzLYGP_SS4WtVOuY1XA-1; Wed, 07 Oct 2020 08:36:03 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E42FF10BBEF3; Wed, 7 Oct 2020 12:35:56 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BECCB7664E; Wed, 7 Oct 2020 12:35:56 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8B64718408A1; Wed, 7 Oct 2020 12:35:56 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 097CZiLY012431 for ; Wed, 7 Oct 2020 08:35:44 -0400 Received: by smtp.corp.redhat.com (Postfix) id 4EAF1757DF; Wed, 7 Oct 2020 12:35:44 +0000 (UTC) Received: from hjs.redhat.com (unknown [10.43.2.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id CA869702E7 for ; Wed, 7 Oct 2020 12:35:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602074166; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=xoIgAJeZXDhDQ86H8FYbASMdw3Ui364XzgUMTiaGe9s=; b=fHoPmTOuzeJJoxe6cyloUcuPRvGWh74q+XYA2Kqc77mnq4DnBJK9SZCWXV05IhMXEd9DIL ZUDveRzI5rePH+8cYCLfqMHWHsvxgMv4L1v6qha3oplz/bwCrCuUZyUwSpMlYSBQj1XMIp NYC0YqOwQ1kR9028CbN5LOFtfj5NXGA= X-MC-Unique: OTPNzLYGP_SS4WtVOuY1XA-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCHv2 06/16] qemu: agent: use g_auto for ifname Date: Wed, 7 Oct 2020 14:35:27 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) This lets us conveniently reduce its scope to the outer loop. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Jonathon Jongsma --- src/qemu/qemu_agent.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index 0394a72518..b11f8afde7 100644 --- a/src/qemu/qemu_agent.c +++ b/src/qemu/qemu_agent.c @@ -2127,7 +2127,6 @@ qemuAgentGetInterfaces(qemuAgentPtr agent, size_t ifaces_count =3D 0; virDomainInterfacePtr *ifaces_ret =3D NULL; virHashTablePtr ifaces_store =3D NULL; - char **ifname =3D NULL; =20 /* Hash table to handle the interface alias */ if (!(ifaces_store =3D virHashCreate(ifaces_count, NULL))) { @@ -2158,6 +2157,7 @@ qemuAgentGetInterfaces(qemuAgentPtr agent, virJSONValuePtr ip_addr_arr =3D NULL; const char *hwaddr, *ifname_s, *name =3D NULL; virDomainInterfacePtr iface =3D NULL; + g_auto(GStrv) ifname =3D NULL; size_t addrs_count =3D 0; =20 /* interface name is required to be presented */ @@ -2194,10 +2194,6 @@ qemuAgentGetInterfaces(qemuAgentPtr agent, iface->hwaddr =3D g_strdup(hwaddr); } =20 - /* Has to be freed for each interface. */ - g_strfreev(ifname); - ifname =3D NULL; - /* as well as IP address which - moreover - * can be presented multiple times */ ip_addr_arr =3D virJSONValueObjectGet(tmp_iface, "ip-addresses"); @@ -2242,8 +2238,6 @@ qemuAgentGetInterfaces(qemuAgentPtr agent, virDomainInterfaceFree(ifaces_ret[i]); } VIR_FREE(ifaces_ret); - g_strfreev(ifname); - goto cleanup; } =20 --=20 2.26.2