From nobody Tue Sep 9 18:56:52 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1753279259; cv=none; d=zohomail.com; s=zohoarc; b=fz9AT+AMtWg+5qN8vBLLWQ28uNN8JyZ95jJjEtnyIRJ1tuEkluBr5xzJdnlbxW25ItAJlkjzLpDcvcEnFHTV3CiRAF89GX5vBRdmHlNMcloA/WoNfi4J/UgIWFrOXiA/asbHr0RyAxrEMF5Yeu5NWgkPltNkip8ypCDX8gY1zGk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753279259; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=SPzlQLjB0Re+RrxgHU7y0iyP7LbSbEmj57N8RVwOY2Q=; b=mEvt4huOJJT/ojmLmK2dbbF2O2Hr5wWltv1wXYMIHcz0NlhfgqOpseExdvgDb9x9AvA9pd0uSq9VrZuzPJIK8zvuMKW0MfZLkEXQvzxmuA9OGd5WTHD2Aalkv0oB7BQ3PZ2k6b1KVBj91uUiOEfK4RO5qo0qwoPA+aDEGJxdXeM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1753279259189887.8157215777936; Wed, 23 Jul 2025 07:00:59 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 24C2512A2; Wed, 23 Jul 2025 10:00:58 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 09C7813CB; Wed, 23 Jul 2025 10:00:22 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 2B199D3A; Wed, 23 Jul 2025 10:00:18 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id AAC2ED10 for ; Wed, 23 Jul 2025 10:00:17 -0400 (EDT) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-171-1xVkD8QBOguWSwH4c4-rzg-1; Wed, 23 Jul 2025 10:00:15 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0799A1800878 for ; Wed, 23 Jul 2025 14:00:15 +0000 (UTC) Received: from localhost.localdomain (unknown [10.43.3.236]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4A3FF19560AF for ; Wed, 23 Jul 2025 14:00:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1753279217; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/na/nDNd5TTCGkapnb3ADYihuIUY7XoTGcD1917zgnE=; b=LA59fuiUOtHsIvWj9Yi/gTLnSUzx6tMDTLaDj4E26e3DuNrrziDNfZoQCR7VYLEa6e1m/B lFDbe30uQFpsIerxe4/dCXDtqs1Vl8HnUddIyUwalodDngGT3dESHD8vJyNfEpzMeOznGQ 2/Sk83KFKjNlIZ9bfljBvlcG75wMzWw= X-MC-Unique: 1xVkD8QBOguWSwH4c4-rzg-1 X-Mimecast-MFC-AGG-ID: 1xVkD8QBOguWSwH4c4-rzg_1753279215 To: devel@lists.libvirt.org Subject: [PATCH 3/5] security_dac: Drop needless checks for seclabel->model == "dac" Date: Wed, 23 Jul 2025 16:00:06 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: VW7M7YKpb2_ZMZEBiAk_Bw6VoufrCQ-eDqRvLZ8wZm8_1753279215 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: DUHNOZGQRS76S5XQMC7WZFC64Z5BVUX2 X-Message-ID-Hash: DUHNOZGQRS76S5XQMC7WZFC64Z5BVUX2 X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1753279260116116600 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik In one instance, after virDomainDefGetSecurityLabelDef(SECURITY_DAC_NAME) was called, we take the returned secdef and compare secdef->model against SECURITY_DAC_NAME. This makes no sense because virDomainDefGetSecurityLabelDef() has already done this comparison. Signed-off-by: Michal Privoznik --- src/security/security_dac.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/security/security_dac.c b/src/security/security_dac.c index 2210117f12..8fb26168ca 100644 --- a/src/security/security_dac.c +++ b/src/security/security_dac.c @@ -2404,14 +2404,6 @@ virSecurityDACGenLabel(virSecurityManager *mgr, return rc; } =20 - if (seclabel->model - && STRNEQ(seclabel->model, SECURITY_DAC_NAME)) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("security label model %1$s is not supported with = selinux"), - seclabel->model); - return rc; - } - switch ((virDomainSeclabelType)seclabel->type) { case VIR_DOMAIN_SECLABEL_STATIC: if (seclabel->label =3D=3D NULL) { --=20 2.49.1