From nobody Sun Sep 7 06:47:12 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1757060120; cv=none; d=zohomail.com; s=zohoarc; b=IrjQTa1iWVDPKJDkqYBh5D0/YLvpYr0eDlvM5VDX6BMdPMB4n1RGDjZS7HYHJ/e/0v8KFORygsIzwT6yUbxb4sM+jUxOW2GaF86bkrGdJh+hgHwdv9hv1gnQzrKh/U6DwsXnevoUUk70E8Tltbsbq19kLgI8NLAS5KFlBQhN+YM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757060120; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=+dl+UjClIrrvr3jYWEtYBzneUBhj/CbgeIXsTSsuH/k=; b=KVvSnpMc4Rn9+KQIJaHxRKBF0161MS6OTso39ofzXB8O+48LozI3fzn/9jIfw8W5nuZSrFwpd48nQUT1lvsWUiMVW8As7S52Q58gsZ/sXBnnesIIo0mU7IGg+9i9Saru+VMCGsqdJE+tPUadlBTHg2tP0i2eX1/U3gxMDPzhMHY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1757060120467615.772280194611; Fri, 5 Sep 2025 01:15:20 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 5C57344204; Fri, 5 Sep 2025 04:15:19 -0400 (EDT) Received: from [172.19.199.3] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 4B9CC443BF; Fri, 5 Sep 2025 04:14:15 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 4C9A244198; Fri, 5 Sep 2025 04:14:02 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 8CAB5441EB for ; Fri, 5 Sep 2025 04:14:00 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-288-Z3VaYYmnPQC2vMg7Cdr9fw-1; Fri, 05 Sep 2025 04:13:58 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 45670180029B for ; Fri, 5 Sep 2025 08:13:57 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.45.242.8]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 82BF418004D8 for ; Fri, 5 Sep 2025 08:13:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757060040; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+dl+UjClIrrvr3jYWEtYBzneUBhj/CbgeIXsTSsuH/k=; b=MUz9flwJ5GVNjGjPO8E7k7HqUFk2OkPU8d878E1sZRk6n7yr5qN/zidxNgy4TExs/HoS/t Aiei95Wp5kDXXx4Z/vh1IGnhWTIUntIgmzNS07qDnFsAJ52r9SIxkMjuGJmTjR7H4UNfxN cW6lEq5FWMHo5Tt3DCvQMdjfQ0P00Yg= X-MC-Unique: Z3VaYYmnPQC2vMg7Cdr9fw-1 X-Mimecast-MFC-AGG-ID: Z3VaYYmnPQC2vMg7Cdr9fw_1757060037 To: devel@lists.libvirt.org Subject: [PATCH] qemu: block: Always enable discard forwarding for 'throttle' filter layer Date: Fri, 5 Sep 2025 10:13:54 +0200 Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: __sjevwiD_DJyVHWGTRGmOt-M_Qci9P1EOg1GuAbr7M_1757060037 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: FKVLHTNWPBLGI3X43G7BEWVI4XYHSHVK X-Message-ID-Hash: FKVLHTNWPBLGI3X43G7BEWVI4XYHSHVK X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1757060123443116600 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Discards ought to be forwarded to the protocol nodes where we control if discard actually happens. Unconditionally enable discard=3D'unmap' for the intermediate layer. Closes: https://gitlab.com/libvirt/libvirt/-/issues/810 Signed-off-by: Peter Krempa --- src/qemu/qemu_block.c | 1 + .../qemuxmlconfdata/throttlefilter.x86_64-latest.args | 10 +++++----- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c index daefeb2f45..194f8407e3 100644 --- a/src/qemu/qemu_block.c +++ b/src/qemu/qemu_block.c @@ -2751,6 +2751,7 @@ qemuBlockThrottleFilterGetProps(virDomainThrottleFilt= erDef *filter, "s:node-name", qemuBlockThrottleFilterGetNod= ename(filter), "s:throttle-group", prefixed_group_name, "s:file", parentNodeName, + "s:discard", "unmap", NULL) < 0) return NULL; diff --git a/tests/qemuxmlconfdata/throttlefilter.x86_64-latest.args b/test= s/qemuxmlconfdata/throttlefilter.x86_64-latest.args index 6a37f5835a..95914ef5ce 100644 --- a/tests/qemuxmlconfdata/throttlefilter.x86_64-latest.args +++ b/tests/qemuxmlconfdata/throttlefilter.x86_64-latest.args @@ -34,18 +34,18 @@ XDG_CONFIG_HOME=3D/var/lib/libvirt/qemu/domain--1-QEMUG= uest1/.config \ -device '{"driver":"piix3-usb-uhci","id":"usb","bus":"pci.0","addr":"0x1.0= x2"}' \ -blockdev '{"driver":"host_device","filename":"/dev/HostVG/QEMUGuest1","no= de-name":"libvirt-8-storage","auto-read-only":true,"discard":"unmap","cache= ":{"direct":true,"no-flush":false}}' \ -blockdev '{"node-name":"libvirt-8-format","read-only":false,"cache":{"dir= ect":true,"no-flush":false},"driver":"qcow2","file":"libvirt-8-storage"}' \ --blockdev '{"driver":"throttle","node-name":"libvirt-9-filter","throttle-g= roup":"throttle-limit0","file":"libvirt-8-format"}' \ +-blockdev '{"driver":"throttle","node-name":"libvirt-9-filter","throttle-g= roup":"throttle-limit0","file":"libvirt-8-format","discard":"unmap"}' \ -device '{"driver":"virtio-blk-pci","bus":"pci.0","addr":"0x4","drive":"li= bvirt-9-filter","id":"virtio-disk0","bootindex":1,"write-cache":"on"}' \ -blockdev '{"driver":"host_device","filename":"/dev/HostVG/QEMUGuest2","no= de-name":"libvirt-5-storage","auto-read-only":true,"discard":"unmap","cache= ":{"direct":true,"no-flush":false}}' \ -blockdev '{"node-name":"libvirt-5-format","read-only":false,"cache":{"dir= ect":true,"no-flush":false},"driver":"qcow2","file":"libvirt-5-storage"}' \ --blockdev '{"driver":"throttle","node-name":"libvirt-6-filter","throttle-g= roup":"throttle-limit1","file":"libvirt-5-format"}' \ --blockdev '{"driver":"throttle","node-name":"libvirt-7-filter","throttle-g= roup":"throttle-limit12","file":"libvirt-6-filter"}' \ +-blockdev '{"driver":"throttle","node-name":"libvirt-6-filter","throttle-g= roup":"throttle-limit1","file":"libvirt-5-format","discard":"unmap"}' \ +-blockdev '{"driver":"throttle","node-name":"libvirt-7-filter","throttle-g= roup":"throttle-limit12","file":"libvirt-6-filter","discard":"unmap"}' \ -device '{"driver":"virtio-blk-pci","bus":"pci.0","addr":"0x5","drive":"li= bvirt-7-filter","id":"virtio-disk1","write-cache":"on"}' \ -blockdev '{"driver":"host_device","filename":"/dev/HostVG/QEMUGuest3","no= de-name":"libvirt-2-storage","auto-read-only":true,"discard":"unmap","cache= ":{"direct":true,"no-flush":false}}' \ -blockdev '{"node-name":"libvirt-2-format","read-only":false,"cache":{"dir= ect":true,"no-flush":false},"driver":"qcow2","file":"libvirt-2-storage"}' \ -blockdev '{"driver":"copy-on-read","node-name":"libvirt-CoR-vdc","file":"= libvirt-2-format","discard":"unmap"}' \ --blockdev '{"driver":"throttle","node-name":"libvirt-3-filter","throttle-g= roup":"throttle-limit2","file":"libvirt-CoR-vdc"}' \ --blockdev '{"driver":"throttle","node-name":"libvirt-4-filter","throttle-g= roup":"throttle-limit12","file":"libvirt-3-filter"}' \ +-blockdev '{"driver":"throttle","node-name":"libvirt-3-filter","throttle-g= roup":"throttle-limit2","file":"libvirt-CoR-vdc","discard":"unmap"}' \ +-blockdev '{"driver":"throttle","node-name":"libvirt-4-filter","throttle-g= roup":"throttle-limit12","file":"libvirt-3-filter","discard":"unmap"}' \ -device '{"driver":"virtio-blk-pci","bus":"pci.0","addr":"0x6","drive":"li= bvirt-4-filter","id":"virtio-disk2","write-cache":"on"}' \ -blockdev '{"driver":"host_device","filename":"/dev/HostVG/QEMUGuest4","no= de-name":"libvirt-1-storage","auto-read-only":true,"discard":"unmap","cache= ":{"direct":true,"no-flush":false}}' \ -blockdev '{"node-name":"libvirt-1-format","read-only":false,"cache":{"dir= ect":true,"no-flush":false},"driver":"qcow2","file":"libvirt-1-storage"}' \ --=20 2.51.0