From nobody Sun Feb 8 19:57:04 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1571059026; cv=none; d=zoho.com; s=zohoarc; b=lFcNrpnF7qu6fyeFAPNb8YZzcX8vapPVquY5WQVDTNbTyOttxaSTr3LHhynzriQNS0+85n8PZA0ZZU+gFSeiDQqidgX4uiEyOKjKflNr09LQNimKVrCBFBJ8GaYnNfbXkSJVHNRMKNw7Wgh8hlqFkXMsw+jBnUZP3RfedNYMRrU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1571059026; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=FSXeukGp3ENsUYrdnucPXflIcnxEeCPyOEaBd4vS0f4=; b=B3m6txXq+eq0V3b+24HF2Gz77kqEoG5v3wMPezdrQYhNuvPAR5sSNdB1PUr2BUqeCSq64bE0KpznserOdw/0UQg8+Poosm/1fzcZdANJ5jtGOmOP3WG7Rs9UHVC+xlg+3RIRBOf1aPu/HtpmDZdJxWJwGqy67NbTZ0rpbCufaLQ= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1571059026785509.1522422378574; Mon, 14 Oct 2019 06:17:06 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 756713084295; Mon, 14 Oct 2019 13:17:04 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4EAF11001B07; Mon, 14 Oct 2019 13:17:04 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0BA71180BA9A; Mon, 14 Oct 2019 13:17:04 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x9EDGRwa017448 for ; Mon, 14 Oct 2019 09:16:27 -0400 Received: by smtp.corp.redhat.com (Postfix) id CFBC960127; Mon, 14 Oct 2019 13:16:27 +0000 (UTC) Received: from icr.brq.redhat.com (unknown [10.43.2.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 58B5C600CD for ; Mon, 14 Oct 2019 13:16:27 +0000 (UTC) From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Date: Mon, 14 Oct 2019 15:15:35 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 17/35] network: use G_GNUC_UNUSED X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Mon, 14 Oct 2019 13:17:05 +0000 (UTC) Use G_GNUC_UNUSED from GLib instead of ATTRIBUTE_UNUSED. Signed-off-by: J=C3=A1n Tomko --- src/network/bridge_driver.c | 26 +++++++++++++------------- src/network/bridge_driver_linux.c | 2 +- src/network/bridge_driver_nop.c | 12 ++++++------ 3 files changed, 20 insertions(+), 20 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index d10665efa3..4beb28a5d9 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -662,7 +662,7 @@ networkAutostartConfig(virNetworkObjPtr obj, =20 #ifdef WITH_FIREWALLD static DBusHandlerResult -firewalld_dbus_filter_bridge(DBusConnection *connection ATTRIBUTE_UNUSED, +firewalld_dbus_filter_bridge(DBusConnection *connection G_GNUC_UNUSED, DBusMessage *message, void *user_data) { @@ -709,8 +709,8 @@ firewalld_dbus_filter_bridge(DBusConnection *connection= ATTRIBUTE_UNUSED, */ static int networkStateInitialize(bool privileged, - virStateInhibitCallback callback ATTRIBUTE_UNUSED, - void *opaque ATTRIBUTE_UNUSED) + virStateInhibitCallback callback G_GNUC_UNUSED, + void *opaque G_GNUC_UNUSED) { int ret =3D VIR_DRV_STATE_INIT_ERROR; char *configdir =3D NULL; @@ -932,8 +932,8 @@ networkStateCleanup(void) =20 static virDrvOpenStatus networkConnectOpen(virConnectPtr conn, - virConnectAuthPtr auth ATTRIBUTE_UNUSED, - virConfPtr conf ATTRIBUTE_UNUSED, + virConnectAuthPtr auth G_GNUC_UNUSED, + virConfPtr conf G_GNUC_UNUSED, unsigned int flags) { virCheckFlags(VIR_CONNECT_RO, VIR_DRV_OPEN_ERROR); @@ -955,27 +955,27 @@ networkConnectOpen(virConnectPtr conn, return VIR_DRV_OPEN_SUCCESS; } =20 -static int networkConnectClose(virConnectPtr conn ATTRIBUTE_UNUSED) +static int networkConnectClose(virConnectPtr conn G_GNUC_UNUSED) { return 0; } =20 =20 -static int networkConnectIsSecure(virConnectPtr conn ATTRIBUTE_UNUSED) +static int networkConnectIsSecure(virConnectPtr conn G_GNUC_UNUSED) { /* Trivially secure, since always inside the daemon */ return 1; } =20 =20 -static int networkConnectIsEncrypted(virConnectPtr conn ATTRIBUTE_UNUSED) +static int networkConnectIsEncrypted(virConnectPtr conn G_GNUC_UNUSED) { /* Not encrypted, but remote driver takes care of that */ return 0; } =20 =20 -static int networkConnectIsAlive(virConnectPtr conn ATTRIBUTE_UNUSED) +static int networkConnectIsAlive(virConnectPtr conn G_GNUC_UNUSED) { return 1; } @@ -1131,7 +1131,7 @@ networkDnsmasqConfContents(virNetworkObjPtr obj, const char *pidfile, char **configstr, dnsmasqContext *dctx, - dnsmasqCapsPtr caps ATTRIBUTE_UNUSED) + dnsmasqCapsPtr caps G_GNUC_UNUSED) { virNetworkDefPtr def =3D virNetworkObjGetDef(obj); virBuffer configbuf =3D VIR_BUFFER_INITIALIZER; @@ -2213,7 +2213,7 @@ networkRefreshDaemons(virNetworkDriverStatePtr driver) =20 static int networkReloadFirewallRulesHelper(virNetworkObjPtr obj, - void *opaque ATTRIBUTE_UNUSED) + void *opaque G_GNUC_UNUSED) { virNetworkDefPtr def; =20 @@ -2760,7 +2760,7 @@ networkStartNetworkBridge(virNetworkObjPtr obj) =20 =20 static int -networkShutdownNetworkBridge(virNetworkObjPtr obj ATTRIBUTE_UNUSED) +networkShutdownNetworkBridge(virNetworkObjPtr obj G_GNUC_UNUSED) { virNetworkDefPtr def =3D virNetworkObjGetDef(obj); =20 @@ -2900,7 +2900,7 @@ networkStartNetworkExternal(virNetworkObjPtr obj) =20 =20 static int -networkShutdownNetworkExternal(virNetworkObjPtr obj ATTRIBUTE_UNUSED) +networkShutdownNetworkExternal(virNetworkObjPtr obj G_GNUC_UNUSED) { /* put anything here that needs to be done each time a network of * type BRIDGE, PRIVATE, VEPA, HOSTDEV or PASSTHROUGH is shutdown. On diff --git a/src/network/bridge_driver_linux.c b/src/network/bridge_driver_= linux.c index 35459c10d1..d62fb899b9 100644 --- a/src/network/bridge_driver_linux.c +++ b/src/network/bridge_driver_linux.c @@ -157,7 +157,7 @@ void networkPreReloadFirewallRules(virNetworkDriverStat= ePtr driver, bool startup } =20 =20 -void networkPostReloadFirewallRules(bool startup ATTRIBUTE_UNUSED) +void networkPostReloadFirewallRules(bool startup G_GNUC_UNUSED) { iptablesSetDeletePrivate(true); } diff --git a/src/network/bridge_driver_nop.c b/src/network/bridge_driver_no= p.c index ec7b1ed8b7..08d737511f 100644 --- a/src/network/bridge_driver_nop.c +++ b/src/network/bridge_driver_nop.c @@ -19,27 +19,27 @@ =20 #include =20 -void networkPreReloadFirewallRules(virNetworkDriverStatePtr driver ATTRIBU= TE_UNUSED, - bool startup ATTRIBUTE_UNUSED) +void networkPreReloadFirewallRules(virNetworkDriverStatePtr driver G_GNUC_= UNUSED, + bool startup G_GNUC_UNUSED) { } =20 =20 -void networkPostReloadFirewallRules(bool startup ATTRIBUTE_UNUSED) +void networkPostReloadFirewallRules(bool startup G_GNUC_UNUSED) { } =20 =20 -int networkCheckRouteCollision(virNetworkDefPtr def ATTRIBUTE_UNUSED) +int networkCheckRouteCollision(virNetworkDefPtr def G_GNUC_UNUSED) { return 0; } =20 -int networkAddFirewallRules(virNetworkDefPtr def ATTRIBUTE_UNUSED) +int networkAddFirewallRules(virNetworkDefPtr def G_GNUC_UNUSED) { return 0; } =20 -void networkRemoveFirewallRules(virNetworkDefPtr def ATTRIBUTE_UNUSED) +void networkRemoveFirewallRules(virNetworkDefPtr def G_GNUC_UNUSED) { } --=20 2.19.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list