From nobody Mon Feb 9 00:55:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612186772; cv=none; d=zohomail.com; s=zohoarc; b=nYnjF42gtio+vqZUWs5w7fjCPFqZwMsGAPdDlYmKHE1s/O3MhYNfWtTfNn20B9zSxhTuHAwg6xe+uS8iX/1/ZxzaB2Hi81rSoLD6N9whygTAossk97LdAMFAUhTno1o9qd3yNT8JoyMZXeWD0nTSLXVcb6gtX5GtOHqqO/Xlmno= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612186772; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=UizPWiL3MsSp1hXNWDzUCWsB3exVQQmqnCWl2FjbW0E=; b=hBcKF5wID6BAMiMWu4DtGBf7k7+7aDar/cOY68RAVl+AskMbYkMRTXTT9CQJeUYsgOskU9L+b5LioF/C95Un+Xlb2epEYpa7QxID4//70beD1W3vAIJT2YHIeVv4Tw4PrOnnBNdzVlEhrvHO0sd/7MgCGKOB9jm+juvC3Aa+VaI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1612186772150477.86540561415495; Mon, 1 Feb 2021 05:39:32 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-529-A8TJEvLmONqqFXv0_M86AA-1; Mon, 01 Feb 2021 08:39:28 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4BBAC801B1A; Mon, 1 Feb 2021 13:39:22 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 18BBA6E51F; Mon, 1 Feb 2021 13:39:22 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D36D45003B; Mon, 1 Feb 2021 13:39:21 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 111DdDls023345 for ; Mon, 1 Feb 2021 08:39:13 -0500 Received: by smtp.corp.redhat.com (Postfix) id 4DB8660C68; Mon, 1 Feb 2021 13:39:13 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id A7FAA60C66 for ; Mon, 1 Feb 2021 13:39:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612186771; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=UizPWiL3MsSp1hXNWDzUCWsB3exVQQmqnCWl2FjbW0E=; b=T1sNr+IVJXVrZPlZqOLhv5QY7bAhYlIzveUisIcYcjr+wMCic+ma28FgQMdZkGABNPwkoV yP415P25u7GYTNf1k0vE3u3roJlAZ512D1F9NmLegidsX+Llp0QZd81xpKlPeoggtks+kf VuKA79j1B2RVBVl3xiNuGSmzcMinTO8= X-MC-Unique: A8TJEvLmONqqFXv0_M86AA-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 02/14] libxlMakeDomBuildInfo: Don't use VIR_DISPOSE_N for USB device list Date: Mon, 1 Feb 2021 14:38:54 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The list isn't secret which would need being disposed of. Just expand the array and return failure when adding the NULL terminator similarly to how we expand the list for adding devices in a loop. Signed-off-by: Peter Krempa --- src/libxl/libxl_conf.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 6a8ae27f54..cb1fd7df7d 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -686,7 +686,6 @@ libxlMakeDomBuildInfo(virDomainDefPtr def, /* NULL-terminate usbdevice_list */ if (nusbdevice > 0 && VIR_EXPAND_N(b_info->u.hvm.usbdevice_list, nusbdevice, 1) < 0)= { - VIR_DISPOSE_N(b_info->u.hvm.usbdevice_list, nusbdevice); return -1; } #endif --=20 2.29.2