From nobody Fri May 3 01:29:59 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1526023138644519.0575176530812; Fri, 11 May 2018 00:18:58 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 90DA57F772; Fri, 11 May 2018 07:18:56 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0067F30B7446; Fri, 11 May 2018 07:18:55 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 2F1AB1801245; Fri, 11 May 2018 07:18:53 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w4B7HDaR013742 for ; Fri, 11 May 2018 03:17:13 -0400 Received: by smtp.corp.redhat.com (Postfix) id 044236B59B; Fri, 11 May 2018 07:17:13 +0000 (UTC) Received: from wheatley (unknown [10.34.244.93]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A4B3C6352E for ; Fri, 11 May 2018 07:17:10 +0000 (UTC) Received: from wheatley.cock.kentus.net (wheatley.usersys.redhat.com [127.0.0.1]) by wheatley (Postfix) with ESMTP id C0CD87E003F for ; Thu, 10 May 2018 23:14:50 +0200 (CEST) From: Martin Kletzander To: libvir-list@redhat.com Date: Thu, 10 May 2018 23:13:07 +0200 Message-Id: X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] tests: Fix qemucapsprobemock linking X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Fri, 11 May 2018 07:18:57 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Add libvirt.la into qemucapsprobemock_la_LIBADD because that mock uses bunc= h of libvirt internal functions. Without this patch the following error occurs: $ ./qemucapsprobe /usr/bin/qemu-system-x86_64 ... warning : virQEMUCapsLogProbeFailure:4204 : Failed to probe capabilities = for /usr/bin/qemu-system-x86_64: internal error: Failed to probe QEMU binary = with QMP: /usr/bin/qemu-system-x86_64: symbol lookup error: .../qemucapsprobemock.so: undefined symbol: virJSONValueObjectHasKey Signed-off-by: Martin Kletzander --- TBH I didn't go into details why this is needed. It still seems fishy to m= e. Not only that I get that error above as a libvirt error, but if i add just libvirt_util.la in there, I get: .../qemucapsprobe: symbol lookup error: .../qemucapsprobemock.so: undefined symbol: libvirt_event_poll_update_handle_semaphore If anyone has a better idea how this should be fixed, please suggest that. tests/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 05db6b1192a4..24ea41f5176c 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -619,7 +619,7 @@ qemucapsprobe_LDADD =3D \ qemucapsprobemock_la_SOURCES =3D \ qemucapsprobemock.c qemucapsprobemock_la_LDFLAGS =3D $(MOCKLIBS_LDFLAGS) -qemucapsprobemock_la_LIBADD =3D $(MOCKLIBS_LIBS) +qemucapsprobemock_la_LIBADD =3D $(MOCKLIBS_LIBS) ../src/libvirt.la =20 qemucommandutiltest_SOURCES =3D \ qemucommandutiltest.c \ --=20 2.17.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list