From nobody Sun Feb 8 05:08:35 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1637253254; cv=none; d=zohomail.com; s=zohoarc; b=l2sZZ+X5z9X9G3zT2vofp+F0FgnrbVMYV/gvCUG7In6GK8ZOAN1XshZVXpKswI+ja1BXc0afDlgaMIGKtPRuW/y1rH2/TQz9iTZhDPAe7tea3tW7jP3Hp1QZ+8BNzsB5PXHpTmex8Qnmi1cYMlfxPsD5toRjEjR9vKcEh8kazOg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1637253254; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=utWonSkdjXy9veijF3/S6u3rpgg/vkEdnkwKopUpT9c=; b=PQPCTJxT7iiK/omhtzW8X1Jl92SvX3YGl2bSYdTPV/bRvgTdSnJiv11IhaIBbaZr/+PVn2IYh/XdFxqRfHbWQPKyFkLQIV27drJcdooOR2ZXYqbMDosm4tVkDIvOYDbDNnW2c3ceXo+xSxtEAqrdPlV3rdEaP0SiRng3+7p6qFA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1637253254300224.5345115796764; Thu, 18 Nov 2021 08:34:14 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-394-w5tztWqwPnm97PWYl3J9UA-1; Thu, 18 Nov 2021 11:34:11 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E54818799EF; Thu, 18 Nov 2021 16:34:06 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C76BB179B3; Thu, 18 Nov 2021 16:34:06 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8AF291832DD4; Thu, 18 Nov 2021 16:34:06 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1AIGXnpM028038 for ; Thu, 18 Nov 2021 11:33:49 -0500 Received: by smtp.corp.redhat.com (Postfix) id EA2C51B5C0; Thu, 18 Nov 2021 16:33:49 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.20]) by smtp.corp.redhat.com (Postfix) with ESMTP id 41D34608BA for ; Thu, 18 Nov 2021 16:33:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637253253; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=utWonSkdjXy9veijF3/S6u3rpgg/vkEdnkwKopUpT9c=; b=U5OSvh8p/SWzKVuTKSlpWC51eicZIdXLMfTGj28vvIfGbUHbRgX4fPJdELiz6VH4owGVYV BOCdPyiUhg15g4ycc/G6mGx6Ec+aj36uG2B6grxlavW96A+rqe+OvjiznrJCHQ6RqeU1N7 J0akxawl5TqPOeEjCOJ/AwSp02tZQCQ= X-MC-Unique: w5tztWqwPnm97PWYl3J9UA-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 03/16] qemuMonitorJSONAddDeviceProps: Simplify construction of the command Date: Thu, 18 Nov 2021 17:33:28 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1637253255209100005 Content-Type: text/plain; charset="utf-8" Use 'qemuMonitorJSONMakeCommandInternal' instead of 'qemuMonitorJSONMakeCommand' + 'virJSONValueObjectAppend'. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_monitor_json.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index a3bdfaaf0d..2cfae2276d 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -4154,11 +4154,8 @@ qemuMonitorJSONAddDeviceProps(qemuMonitor *mon, g_autoptr(virJSONValue) cmd =3D NULL; g_autoptr(virJSONValue) reply =3D NULL; - if (!(cmd =3D qemuMonitorJSONMakeCommand("device_add", NULL))) - return -1; - - if (virJSONValueObjectAppend(cmd, "arguments", props) < 0) - return -1; + if (!(cmd =3D qemuMonitorJSONMakeCommandInternal("device_add", props)= )) + return -1; if (qemuMonitorJSONCommand(mon, cmd, &reply) < 0) return -1; --=20 2.31.1