From nobody Mon Feb 9 08:49:31 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1670603412; cv=none; d=zohomail.com; s=zohoarc; b=baI7wXuH1kfMYqYgRPg4bcEIp0rekWkhmSm1q5V5phB47CWZ4tFaFgnpjF+WJGF8eiobTT0FcDwfm6yXmZUlIlfTODMHmf/eNNgMyCwvol5T53sZi8pSy43nv0s7Mea5mVCiiiNMueICTeyD2OMo3zNuPRr4AltVVHpjTHflaxQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1670603412; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=IIc0kklqhDEs03txh59wnUP9hDIl3fpicjPliG2mwxs=; b=F4e1ODv0p0MKrdR6R2Orv1H812/pztGOM7KUZ3U+ubkS2Bv3CM74JzsVnvCgshAVGATCm98KywuFl8Ptvs0vJzWiZfDmjw6TQohIChUkFZYP29MZZJnpKMKkleyKHt3SfhBrU01Cae44xpl4FlknW6HQG+Ng4uFYGAKYeCokEq4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1670603412081502.7918116670828; Fri, 9 Dec 2022 08:30:12 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-343-OCBBsmyjMdOEzo0MFSaiUw-1; Fri, 09 Dec 2022 11:29:18 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 09E4B8026BA; Fri, 9 Dec 2022 16:29:14 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id E248C111F3C1; Fri, 9 Dec 2022 16:29:13 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 63D17194705F; Fri, 9 Dec 2022 16:29:12 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 8B2531947051 for ; Fri, 9 Dec 2022 16:29:10 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 6EFC642222; Fri, 9 Dec 2022 16:29:10 +0000 (UTC) Received: from speedmetal.redhat.com (ovpn-208-20.brq.redhat.com [10.40.208.20]) by smtp.corp.redhat.com (Postfix) with ESMTP id AF1B41759E for ; Fri, 9 Dec 2022 16:29:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670603411; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=IIc0kklqhDEs03txh59wnUP9hDIl3fpicjPliG2mwxs=; b=h8HIgSpUM2/rSepkxfIPglwee6dqC301SQ4V05yJbjdBwaPZLTzhs7F3yWVb5fLLT+igKv /qzObncgn6qzsczBMJNQELrQfeYQ9dXrMq14zLAqxWNI80o11S3fp9vtkcb5Zpx/rHQqVl DcDSRkX50BfbgSzM/L+QnqlSTGDcFvk= X-MC-Unique: OCBBsmyjMdOEzo0MFSaiUw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 05/11] virStorageBackendISCSISetAuth: Use g_strndup to '\0' terminate data Date: Fri, 9 Dec 2022 17:28:57 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1670603413036100003 Content-Type: text/plain; charset="utf-8" Signed-off-by: Peter Krempa --- src/storage/storage_backend_iscsi.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/storage/storage_backend_iscsi.c b/src/storage/storage_back= end_iscsi.c index 78c86e6359..9f9aa01f05 100644 --- a/src/storage/storage_backend_iscsi.c +++ b/src/storage/storage_backend_iscsi.c @@ -281,9 +281,8 @@ virStorageBackendISCSISetAuth(const char *portal, &secret_value, &secret_size) < 0) goto cleanup; - secret_str =3D g_new0(char, secret_size + 1); - memcpy(secret_str, secret_value, secret_size); - secret_str[secret_size] =3D '\0'; + /* '\0' terminate the data into a string */ + secret_str =3D g_strndup((char *) secret_value, secret_size); if (virISCSINodeUpdate(portal, source->devices[0].path, --=20 2.38.1