From nobody Sun Feb 8 17:46:30 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1606841107; cv=none; d=zohomail.com; s=zohoarc; b=nIF17aZDI+0pEsbMIXWZK+TQZPg25HtbLZR7A889UhZKkLC44qLqph2ALQQe9F3HpSaDpf2fd6Oqcy4TYa+ERYXxoIC0Be+2um3MKXpdpHn2znZ2hUMk8pVnzhoqIsGcGaipMxjQbVWDldkXcXeY8Grss+pda4WW4kHuSw7Hxcs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606841107; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=97pKKHJT/bAmOPA156O75fTFC0H2DULsMICQqOclfsc=; b=C0WmVNl97jrsiPNoOQZw0HBo3x9pQK96RCfh6h/48Mvs6+swkMHCM1GkRt/eiWkoY7WsBDWC/Z55s6IOFdh/wJbjkH2d6R6Y1hDUzpf4N0OemmBV9yyEGz++CcsYAF84MLcyT6QSJu4+nZE0qHhIF+iu+sKSNx+JuIaWKoXUaQg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1606841107016233.63289460981412; Tue, 1 Dec 2020 08:45:07 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-59-TfGm6VgGMF-yuWHKlao87g-1; Tue, 01 Dec 2020 11:44:42 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 56B38100C665; Tue, 1 Dec 2020 16:44:35 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2E1775C1B4; Tue, 1 Dec 2020 16:44:35 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id EDF0A4EEEE; Tue, 1 Dec 2020 16:44:34 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0B1GiUHM030686 for ; Tue, 1 Dec 2020 11:44:30 -0500 Received: by smtp.corp.redhat.com (Postfix) id 5C9A410016FF; Tue, 1 Dec 2020 16:44:30 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.194.243]) by smtp.corp.redhat.com (Postfix) with ESMTP id D0B0A10013C1 for ; Tue, 1 Dec 2020 16:44:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606841105; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=97pKKHJT/bAmOPA156O75fTFC0H2DULsMICQqOclfsc=; b=OqkQYjFbrUwFvpLXeSJVfDc93/Wtz1cuwd9zWpnXaqIvDNI8wLIyQfOLZsTfF74sJlHNAp xR8alUBs7pGIx30X2tzLPQ5BplVi+UQbii71bWNv5WOffzOkBRq6fxPApV5+djwTsZPOfr Yd0+JeAPNWm3BaxNMper2mWiY7eoauY= X-MC-Unique: TfGm6VgGMF-yuWHKlao87g-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 2/2] virstring: Drop VIR_AUTOSTRINGLIST Date: Tue, 1 Dec 2020 17:44:23 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Now that no one uses VIR_AUTOSTRINGLIST it can be dropped. Signed-off-by: Michal Privoznik --- src/libvirt_private.syms | 1 - src/util/virstring.c | 10 ---------- src/util/virstring.h | 9 --------- 3 files changed, 20 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 179dcecb0a..2f640ef1c4 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -3227,7 +3227,6 @@ virStringHasSuffix; virStringIsEmpty; virStringIsPrintable; virStringListAdd; -virStringListAutoFree; virStringListFreeCount; virStringListGetFirstWithPrefix; virStringListHasString; diff --git a/src/util/virstring.c b/src/util/virstring.c index 5c49b56f75..5578a5545b 100644 --- a/src/util/virstring.c +++ b/src/util/virstring.c @@ -259,16 +259,6 @@ virStringListMerge(char ***dst, } =20 =20 -void virStringListAutoFree(char ***strings) -{ - if (!*strings) - return; - - g_strfreev(*strings); - *strings =3D NULL; -} - - /** * virStringListFreeCount: * @strings: array of strings to free diff --git a/src/util/virstring.h b/src/util/virstring.h index 561ce0cbc0..210e43a953 100644 --- a/src/util/virstring.h +++ b/src/util/virstring.h @@ -45,7 +45,6 @@ void virStringListRemove(char ***strings, int virStringListMerge(char ***dst, char ***src); =20 -void virStringListAutoFree(char ***strings); void virStringListFreeCount(char **strings, size_t count); =20 @@ -179,11 +178,3 @@ int virStringParsePort(const char *str, int virStringParseYesNo(const char *str, bool *result) G_GNUC_WARN_UNUSED_RESULT; -/** - * VIR_AUTOSTRINGLIST: - * - * Declares a NULL-terminated list of strings which will be automatically = freed - * when the pointer goes out of scope. - */ -#define VIR_AUTOSTRINGLIST \ - __attribute__((cleanup(virStringListAutoFree))) char ** --=20 2.26.2