From nobody Sun Feb 8 18:08:45 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 154808442230295.88408352205602; Mon, 21 Jan 2019 07:27:02 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 94B7388E58; Mon, 21 Jan 2019 15:26:58 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3903A6C21A; Mon, 21 Jan 2019 15:26:57 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A51C93D3A2; Mon, 21 Jan 2019 15:26:56 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x0LFQshP027740 for ; Mon, 21 Jan 2019 10:26:54 -0500 Received: by smtp.corp.redhat.com (Postfix) id 69486648CF; Mon, 21 Jan 2019 15:26:54 +0000 (UTC) Received: from angien.brq.redhat.com (unknown [10.43.2.229]) by smtp.corp.redhat.com (Postfix) with ESMTP id E138060C23 for ; Mon, 21 Jan 2019 15:26:53 +0000 (UTC) From: Peter Krempa To: libvir-list@redhat.com Date: Mon, 21 Jan 2019 16:26:44 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 2/3] lib: Clarify that any block job may block VM save or device detach X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Mon, 21 Jan 2019 15:27:00 +0000 (UTC) Content-Type: text/plain; charset="utf-8" The documentation was only referring to a copy job, but in fact any running blockjob will have the same results. Signed-off-by: Peter Krempa --- src/libvirt-domain.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index c155b36e16..92a095f00b 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -883,8 +883,8 @@ virDomainSave(virDomainPtr domain, const char *to) * virDomainSaveImageGetXMLDesc() and virDomainSaveImageDefineXML(). * * Some hypervisors may prevent this operation if there is a current - * block copy operation; in that case, use virDomainBlockJobAbort() - * to stop the block copy first. + * block job running; in that case, use virDomainBlockJobAbort() + * to stop the block job first. * * Returns 0 in case of success and -1 in case of failure. */ @@ -8297,8 +8297,8 @@ virDomainDetachDevice(virDomainPtr domain, const char= *xml) * persisted device allocation. * * Some hypervisors may prevent this operation if there is a current - * block copy operation on the device being detached; in that case, - * use virDomainBlockJobAbort() to stop the block copy first. + * block job running operation on the device being detached; in that case, + * use virDomainBlockJobAbort() to stop the block job first. * * Beware that depending on the hypervisor and device type, detaching a de= vice * from a running domain may be asynchronous. That is, calling --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list