From nobody Sat May 4 20:07:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1627046762; cv=none; d=zohomail.com; s=zohoarc; b=Xo3Av2gC3HngLuj8aV4QrY6F7p0JdvLme/Y2n4KioxuXKc7oY0tj4I+t46GqKjR2JQZSYFTS0BEb/shf73c6a5b1mL/JwYb94dZ6JldQDj6R/HTrhVJcov6g/otmv4/WUwomM4Te0brVlKU43TStyO5UPIALx1q6XNFvRBPcXVA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1627046762; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=/u1Nl1va9LKn+YYKUIyLgmVpa4jjPnMwsW5kvUEVecc=; b=G+iFtmw5acTpFH2/r6T0i2FtcnMdewppcpWGtJVWaCB/anDTNQ7zAosNxFlQ1f1JbpOVIOafdA+wbILcuNd2XZfrOEZzncbC8DlLl8i0NYsbnQss1v5tNTnRKEM6YD+JR5Ny3HJLbmWoMV0y/xOJAzk3Ti2uqr0OivCHWWq/evQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1627046762875868.9369273169086; Fri, 23 Jul 2021 06:26:02 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-143-GMcZef09PiW55dvSN6SxkA-1; Fri, 23 Jul 2021 09:26:00 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8EDCC87D541; Fri, 23 Jul 2021 13:25:53 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4F4611F4; Fri, 23 Jul 2021 13:25:53 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 10654180B7A2; Fri, 23 Jul 2021 13:25:50 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 16NDPn0m013866 for ; Fri, 23 Jul 2021 09:25:49 -0400 Received: by smtp.corp.redhat.com (Postfix) id AD2605C23A; Fri, 23 Jul 2021 13:25:49 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.38]) by smtp.corp.redhat.com (Postfix) with ESMTP id 16BE85C1D1 for ; Fri, 23 Jul 2021 13:25:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627046761; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=/u1Nl1va9LKn+YYKUIyLgmVpa4jjPnMwsW5kvUEVecc=; b=LDPPckvYpA/7nGj0QUG/M056JGU1fDMWGv7RdLBZ84+WendUMDOwAshHyn0AdBcnAiHjEZ hY4R9xDRh4q6yzZNHdWeZTTwHaxtCM6Twz1bkkq23o+ayLvtYbDgzxYB31X6mJYnHwGBL0 xvqglF7jSO+Kf8GOd3xShiwyCXKUNU4= X-MC-Unique: GMcZef09PiW55dvSN6SxkA-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH] securityselinuxlabeltest: Add debug statements for testUserXattrEnabled return value Date: Fri, 23 Jul 2021 15:25:44 +0200 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1627046764166100001 Content-Type: text/plain; charset="utf-8" I've noticed the test being skipped in my build scenario (tmpfs) and the output doesn't make it clear why it's happening. Add debug statements for the various return values of testUserXattrEnabled. Signed-off-by: Peter Krempa Reviewed-by: Michal Privoznik --- tests/securityselinuxlabeltest.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tests/securityselinuxlabeltest.c b/tests/securityselinuxlabelt= est.c index b1a6735d33..f7dd3c866a 100644 --- a/tests/securityselinuxlabeltest.c +++ b/tests/securityselinuxlabeltest.c @@ -325,10 +325,15 @@ mymain(void) int rc =3D testUserXattrEnabled(); g_autoptr(virQEMUCaps) qemuCaps =3D NULL; - if (rc < 0) + if (rc < 0) { + VIR_TEST_VERBOSE("failed to determine xattr support"); return EXIT_FAILURE; - if (!rc) + } + + if (rc =3D=3D 0) { + VIR_TEST_VERBOSE("xattr unsupported"); return EXIT_AM_SKIP; + } if (!(mgr =3D virSecurityManagerNew("selinux", "QEMU", VIR_SECURITY_MANAGER_DEFAULT_CONFINE= D | --=20 2.31.1