From nobody Sun Dec 22 01:39:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1685027762; cv=none; d=zohomail.com; s=zohoarc; b=Zj/bFEWuc7hyVuFL9qCQqNhH4Lw9K8eX3Iuaca1KhMM/kg5B88627pVPp5KukXfUFoYeC4aiPEJ4pPEl6IPTEu1alBAIKTpIpOH+SvfvALPymyNxyjcRtksXWs1GVgBwmxvIjsFeFU6sTwgsfOubmKvx1zGHuow6p1RWkPA5QHY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1685027762; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ny6AncDTKbDeRi/qksX7XuGpy2d2s/UKAPEqE+Uq0ac=; b=WxikOek2fto6iobrdo3qjIvlMAKTY5CCCYULgagUch3Fu2fuJhuG08LYUBgLUD61Api+PXU5REUmpCS15QvRCnqlbZF29QPYLgoGRaBrngqymgaEtgNzHFsoLK+h8WiFCKD8kXtR1eKpZo4meihF8xJHK7DCE90v7Ktlw8DSGc8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1685027762229899.2066209600259; Thu, 25 May 2023 08:16:02 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-122-fwqxw_qlPjqvwMzyLU-P0Q-1; Thu, 25 May 2023 11:15:54 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 312BA805F30; Thu, 25 May 2023 15:15:30 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1AAFD2029F6D; Thu, 25 May 2023 15:15:30 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id C84031946A46; Thu, 25 May 2023 15:15:29 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 0C60C1946A45 for ; Thu, 25 May 2023 15:14:02 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id E0C1C43E902; Thu, 25 May 2023 15:13:59 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.14]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6BDF2482062 for ; Thu, 25 May 2023 15:13:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685027761; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=ny6AncDTKbDeRi/qksX7XuGpy2d2s/UKAPEqE+Uq0ac=; b=Znnkz+TgLxJtVXmOjWE2Pv+qSTLlcQG/Wbfgl0zxjx88wCgApT0+T4sbQ3OR+vu3uodQY0 Wg2iQN/lVm5NQaLjFdJ/1tJYdxtjo0yZNqJCF2EyJTCIwt+F/nZ99eXf1uTFwF50d6Wh5d ggxCTP/aNfOBYy48uqevc4MHgjB9Yhc= X-MC-Unique: fwqxw_qlPjqvwMzyLU-P0Q-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 15/18] qemumonitorjsontest: Use 'id' instead of deprecated 'device' argument of 'block_set_io_throttle' Date: Thu, 25 May 2023 17:13:42 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1685027763326100001 Content-Type: text/plain; charset="utf-8" The 'device' argument is deprecated. All real usage in the qemu driver already uses 'id' as we populate the 'qomName' for everything except for SD cards where throttling didn't work with libvirt for a very long time. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- tests/qemumonitorjsontest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c index c3963050de..5c05669280 100644 --- a/tests/qemumonitorjsontest.c +++ b/tests/qemumonitorjsontest.c @@ -1870,7 +1870,7 @@ testQemuMonitorJSONqemuMonitorJSONSetBlockIoThrottle(= const void *opaque) if (qemuMonitorTestAddItemVerbatim(test, "{\"execute\":\"block_set_io_thrott= le\"," - " \"arguments\":{\"device\": \"driv= e-virtio-disk1\"," + " \"arguments\":{\"id\": \"drive-vi= rtio-disk1\"," " \"bps\": 1," " \"bps_rd\": 2," " \"bps_wr\": 3," @@ -1904,7 +1904,7 @@ testQemuMonitorJSONqemuMonitorJSONSetBlockIoThrottle(= const void *opaque) goto cleanup; if (qemuMonitorJSONSetBlockIoThrottle(qemuMonitorTestGetMonitor(test), - "drive-virtio-disk1", NULL, &inf= o) < 0) + NULL, "drive-virtio-disk1", &inf= o) < 0) goto cleanup; ret =3D 0; --=20 2.40.1