From nobody Sun Feb 8 19:56:14 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1575453365; cv=none; d=zohomail.com; s=zohoarc; b=hcLYjC6bS1LJCQW+CbrfidPmtOP0cb7Pnmhbf62KtJl9nADoOLDGdFpo9lEKvEJpw7ZZsa+hUD7VXAijPmy7x8cTxPnr0wgv6PZsw4VwjEdUMb1zv6bauj6zEEexjB7a8IrbHvFnOW2UALjwQBXsWYRjVJ1t/6kkHtBnA9H87Jg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1575453365; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+5ejl7ecDJL8fFLJKd1cbRLIA5I6NPAVTHO6q0X2K2Q=; b=mwfbz2OsqeyEl+wf97kbBDbId2efVu0LeAw+TfjSGF27jU5+Bt9J7irMmq6utMOta7uprlFF+yZ2uGqWyKoo9/vtQW2i/tlnqDUaFhPJFkIzDTrLZqIBBsD6LrAH5aY3g9pt8nuUPePs8OayZ3K9dRM3zVypFTgXZDsBlOhY3q4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 157545336571251.83770085688707; Wed, 4 Dec 2019 01:56:05 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-41-O_MXNoDrPwqz1XGUh1o7kw-1; Wed, 04 Dec 2019 04:56:00 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D2473100F045; Wed, 4 Dec 2019 09:55:53 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A6DE25DA7B; Wed, 4 Dec 2019 09:55:53 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 556CC18089D0; Wed, 4 Dec 2019 09:55:53 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xB49tnUN023797 for ; Wed, 4 Dec 2019 04:55:49 -0500 Received: by smtp.corp.redhat.com (Postfix) id 14DFB5DA7B; Wed, 4 Dec 2019 09:55:49 +0000 (UTC) Received: from moe.redhat.com (unknown [10.43.2.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id 90BE35E24D for ; Wed, 4 Dec 2019 09:55:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575453363; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=+5ejl7ecDJL8fFLJKd1cbRLIA5I6NPAVTHO6q0X2K2Q=; b=GAHf6JG1H81E9nUttw2WY4do6n26NBI1CIvlGaQFx3yX3UuKzhE6ya8PQt+L7A3T0WDoho apwO/2ZgqjKVxAw4YkBP45hOO2V7F5+QAibKuaCr73X9KPUU/mteTgV9KMRxGbVy9M2Bh7 62cHpy6UxJgiBEIpUj0tbXKTDQRbhuk= From: Michal Privoznik To: libvir-list@redhat.com Date: Wed, 4 Dec 2019 10:55:34 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 9/9] get_nonnull_domain: Drop useless comment X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: O_MXNoDrPwqz1XGUh1o7kw-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The intent of get_nonnull_domain() is not to validate virDomain as sent by the client but just to construct the virDomain structure. The validation is then done in each API when looking up the domain in our internal hash tables. Signed-off-by: Michal Privoznik --- src/remote/remote_daemon_dispatch.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/remote/remote_daemon_dispatch.c b/src/remote/remote_daemon= _dispatch.c index f369ffb02a..a96e008242 100644 --- a/src/remote/remote_daemon_dispatch.c +++ b/src/remote/remote_daemon_dispatch.c @@ -7240,9 +7240,6 @@ remoteDispatchNetworkPortGetParameters(virNetServerPt= r server G_GNUC_UNUSED, static virDomainPtr get_nonnull_domain(virConnectPtr conn, remote_nonnull_domain domain) { - /* Should we believe the domain.id sent by the client? Maybe - * this should be a check rather than an assignment? XXX - */ return virGetDomain(conn, domain.name, BAD_CAST domain.uuid, domain.id= ); } =20 --=20 2.23.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list