From nobody Wed May 1 22:31:37 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1510150748042616.8941927923688; Wed, 8 Nov 2017 06:19:08 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 84B8877356; Wed, 8 Nov 2017 14:19:05 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 601676BF80; Wed, 8 Nov 2017 14:19:04 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id CE2151800BDC; Wed, 8 Nov 2017 14:19:01 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id vA8EJ0qU030597 for ; Wed, 8 Nov 2017 09:19:00 -0500 Received: by smtp.corp.redhat.com (Postfix) id D3DCC60BE3; Wed, 8 Nov 2017 14:19:00 +0000 (UTC) Received: from angien.brq.redhat.com (unknown [10.43.2.136]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1353060C94; Wed, 8 Nov 2017 14:18:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 84B8877356 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=libvir-list-bounces@redhat.com From: Peter Krempa To: libvir-list@redhat.com Date: Wed, 8 Nov 2017 15:18:37 +0100 Message-Id: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Cc: Peter Krempa Subject: [libvirt] [PATCH] conf: Fix type for @liveStatus in virDomainObjListLoadAllConfigs X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 08 Nov 2017 14:19:06 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Use bool instead of an int. Reviewed-by: Jiri Denemark --- src/bhyve/bhyve_driver.c | 4 ++-- src/conf/virdomainobjlist.c | 2 +- src/conf/virdomainobjlist.h | 2 +- src/libxl/libxl_driver.c | 6 +++--- src/lxc/lxc_driver.c | 6 +++--- src/qemu/qemu_driver.c | 6 +++--- src/uml/uml_driver.c | 4 ++-- 7 files changed, 15 insertions(+), 15 deletions(-) diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c index 5c432b25e..dd6e8abc6 100644 --- a/src/bhyve/bhyve_driver.c +++ b/src/bhyve/bhyve_driver.c @@ -1294,7 +1294,7 @@ bhyveStateInitialize(bool privileged, if (virDomainObjListLoadAllConfigs(bhyve_driver->domains, BHYVE_STATE_DIR, - NULL, 1, + NULL, true, bhyve_driver->caps, bhyve_driver->xmlopt, NULL, NULL) < 0) @@ -1302,7 +1302,7 @@ bhyveStateInitialize(bool privileged, if (virDomainObjListLoadAllConfigs(bhyve_driver->domains, BHYVE_CONFIG_DIR, - BHYVE_AUTOSTART_DIR, 0, + BHYVE_AUTOSTART_DIR, false, bhyve_driver->caps, bhyve_driver->xmlopt, NULL, NULL) < 0) diff --git a/src/conf/virdomainobjlist.c b/src/conf/virdomainobjlist.c index b9f78c572..87a742b1e 100644 --- a/src/conf/virdomainobjlist.c +++ b/src/conf/virdomainobjlist.c @@ -559,7 +559,7 @@ int virDomainObjListLoadAllConfigs(virDomainObjListPtr doms, const char *configDir, const char *autostartDir, - int liveStatus, + bool liveStatus, virCapsPtr caps, virDomainXMLOptionPtr xmlopt, virDomainLoadConfigNotify notify, diff --git a/src/conf/virdomainobjlist.h b/src/conf/virdomainobjlist.h index 60220ca0d..bb186bde3 100644 --- a/src/conf/virdomainobjlist.h +++ b/src/conf/virdomainobjlist.h @@ -72,7 +72,7 @@ void virDomainObjListRemoveLocked(virDomainObjListPtr dom= s, int virDomainObjListLoadAllConfigs(virDomainObjListPtr doms, const char *configDir, const char *autostartDir, - int liveStatus, + bool liveStatus, virCapsPtr caps, virDomainXMLOptionPtr xmlopt, virDomainLoadConfigNotify notify, diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 951937f14..40328a6cb 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -763,7 +763,7 @@ libxlStateInitialize(bool privileged, if (virDomainObjListLoadAllConfigs(libxl_driver->domains, cfg->stateDir, cfg->autostartDir, - 1, + true, cfg->caps, libxl_driver->xmlopt, NULL, NULL) < 0) @@ -775,7 +775,7 @@ libxlStateInitialize(bool privileged, if (virDomainObjListLoadAllConfigs(libxl_driver->domains, cfg->configDir, cfg->autostartDir, - 0, + false, cfg->caps, libxl_driver->xmlopt, NULL, NULL) < 0) @@ -815,7 +815,7 @@ libxlStateReload(void) virDomainObjListLoadAllConfigs(libxl_driver->domains, cfg->configDir, cfg->autostartDir, - 1, + true, cfg->caps, libxl_driver->xmlopt, NULL, libxl_driver); diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index 0069e5e92..b3447100f 100644 --- a/src/lxc/lxc_driver.c +++ b/src/lxc/lxc_driver.c @@ -1679,7 +1679,7 @@ static int lxcStateInitialize(bool privileged, /* Get all the running persistent or transient configs first */ if (virDomainObjListLoadAllConfigs(lxc_driver->domains, cfg->stateDir, - NULL, 1, + NULL, true, caps, lxc_driver->xmlopt, NULL, NULL) < 0) @@ -1690,7 +1690,7 @@ static int lxcStateInitialize(bool privileged, /* Then inactive persistent configs */ if (virDomainObjListLoadAllConfigs(lxc_driver->domains, cfg->configDir, - cfg->autostartDir, 0, + cfg->autostartDir, false, caps, lxc_driver->xmlopt, NULL, NULL) < 0) @@ -1755,7 +1755,7 @@ lxcStateReload(void) virDomainObjListLoadAllConfigs(lxc_driver->domains, cfg->configDir, - cfg->autostartDir, 0, + cfg->autostartDir, false, caps, lxc_driver->xmlopt, lxcNotifyLoadDomain, lxc_driver); diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 47f85b9bf..6132bc4a9 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -911,7 +911,7 @@ qemuStateInitialize(bool privileged, /* Get all the running persistent or transient configs first */ if (virDomainObjListLoadAllConfigs(qemu_driver->domains, cfg->stateDir, - NULL, 1, + NULL, true, qemu_driver->caps, qemu_driver->xmlopt, NULL, NULL) < 0) @@ -933,7 +933,7 @@ qemuStateInitialize(bool privileged, /* Then inactive persistent configs */ if (virDomainObjListLoadAllConfigs(qemu_driver->domains, cfg->configDir, - cfg->autostartDir, 0, + cfg->autostartDir, false, qemu_driver->caps, qemu_driver->xmlopt, NULL, NULL) < 0) @@ -1015,7 +1015,7 @@ qemuStateReload(void) cfg =3D virQEMUDriverGetConfig(qemu_driver); virDomainObjListLoadAllConfigs(qemu_driver->domains, cfg->configDir, - cfg->autostartDir, 0, + cfg->autostartDir, false, caps, qemu_driver->xmlopt, qemuNotifyLoadDomain, qemu_driver); cleanup: diff --git a/src/uml/uml_driver.c b/src/uml/uml_driver.c index 1846835cc..ab7fa7f27 100644 --- a/src/uml/uml_driver.c +++ b/src/uml/uml_driver.c @@ -566,7 +566,7 @@ umlStateInitialize(bool privileged, if (virDomainObjListLoadAllConfigs(uml_driver->domains, uml_driver->configDir, - uml_driver->autostartDir, 0, + uml_driver->autostartDir, false, uml_driver->caps, uml_driver->xmlopt, NULL, NULL) < 0) @@ -634,7 +634,7 @@ umlStateReload(void) umlDriverLock(uml_driver); virDomainObjListLoadAllConfigs(uml_driver->domains, uml_driver->configDir, - uml_driver->autostartDir, 0, + uml_driver->autostartDir, false, uml_driver->caps, uml_driver->xmlopt, umlNotifyLoadDomain, uml_driver); --=20 2.14.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list