From nobody Sat Apr 20 06:49:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1592485845; cv=none; d=zohomail.com; s=zohoarc; b=gR5litfeEpLrNVIC1tRVEcB15MUMENFMJ5AiCwd/QYOkHnYeFJ3rCBRZyxNhGb2djwGxF2amkmpLNvqlyl4CD+OFcK37pJf11HeLnCxyaGP6dteitHxqTulfiMW8Or2Wk6Bjq6rIqimDAFDGBiothxSXL/kcJNSBQE+BPHywOQ0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592485845; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=cb1monlqAUwDjynBANWn8kMoRoLJSrdQZHklXkYAIhY=; b=ce69eqTz1McZhOXeVWYvUpAalkOtH7/1eq/jLcTY0uOQBMqHOBxkfYJZZLAn3mUslTZTS+z3Bg1GFbok2sAy/MEqHBsmc3pMWZcoqy0lJtcfRpsgN/wu+1wagWrUCiIkdrj4HKT7krPcMonFdM2koVK/+JAR+OlQ451Np1YIP08= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 159248584528116.032865069538502; Thu, 18 Jun 2020 06:10:45 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-184-3O0HPLRpMAyy9sCfNsnq1A-1; Thu, 18 Jun 2020 09:10:40 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4AF1991178; Thu, 18 Jun 2020 13:10:34 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CDAEB5D9E5; Thu, 18 Jun 2020 13:10:30 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 5EF881809557; Thu, 18 Jun 2020 13:10:27 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 05IDAPv2002120 for ; Thu, 18 Jun 2020 09:10:25 -0400 Received: by smtp.corp.redhat.com (Postfix) id BF6C61E228B; Thu, 18 Jun 2020 13:10:25 +0000 (UTC) Received: from lpt.redhat.com (unknown [10.40.208.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id D1D851E227D for ; Thu, 18 Jun 2020 13:10:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592485843; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=cb1monlqAUwDjynBANWn8kMoRoLJSrdQZHklXkYAIhY=; b=AvYK7+Gvq6yUmzfXrErhOOdag7dScxu0+OSymVf1AJtBn9YoPBV7W11Ncz5OyyT165NDld LxKz2r+I/NVa1qSKBOFysQTEPeK6ThssKPW5thf5+io29WViTCgR6owc/tBw3yZ3x5GPBH GEwkm1aOIx9iv1bWWiICRKcgEGBXaSY= X-MC-Unique: 3O0HPLRpMAyy9sCfNsnq1A-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH] util: remove outdated comment from virLogFormatString Date: Thu, 18 Jun 2020 15:10:19 +0200 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Introduced by commit 72ab0b6dc8129a388aff260a6e444d48495b0e93 which added some code depending on libvirt's log format string into qemuProcessReadLogOutput. This function was deleted by commit 932534e85f34a479c7eac174e997bfd9c85bd22d later. Drop the comment. Signed-off-by: J=C3=A1n Tomko Closes: https://gitlab.com/libvirt/libvirt/-/issues/35 --- Pushed as trivial. src/util/virlog.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/util/virlog.c b/src/util/virlog.c index e4944d1258..2c18eeed03 100644 --- a/src/util/virlog.c +++ b/src/util/virlog.c @@ -421,13 +421,6 @@ virLogFormatString(char **msg, virLogPriority priority, const char *str) { - /* - * Be careful when changing the following log message formatting, we r= ely - * on it when stripping libvirt debug messages from qemu log files. So= when - * changing this, you might also need to change the code there. - * virLogFormatString() function name is mentioned there so it's suffi= cient - * to just grep for it to find the right place. - */ if ((funcname !=3D NULL)) { *msg =3D g_strdup_printf("%llu: %s : %s:%d : %s\n", virThreadSelfID(), virLogPriorityString(pri= ority), --=20 2.25.4