From nobody Wed Mar 12 17:16:51 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1741015893082267.2274756751375; Mon, 3 Mar 2025 07:31:33 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id ED35C148C; Mon, 3 Mar 2025 10:31:31 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id CE0EA13A3; Mon, 3 Mar 2025 10:31:00 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id A40871392; Mon, 3 Mar 2025 10:30:57 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 2271711CB for ; Mon, 3 Mar 2025 10:30:57 -0500 (EST) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-695-kCAfQBctNPeWSabC_Dj5JA-1; Mon, 03 Mar 2025 10:30:55 -0500 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 22B681944EB0 for ; Mon, 3 Mar 2025 15:30:54 +0000 (UTC) Received: from speedmetal.lan (unknown [10.44.22.15]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 043691956094; Mon, 3 Mar 2025 15:30:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741015856; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NCbYvcnv63M78AXi1iiXWfaek+GW6kWokJfCYr86rro=; b=T0POs55RuzHm4z5G6BT6OgGf0Es13octQVdMp9qw3t4LnJybJNQiQGARC3RXNg1V8dLXpa bVnUVUTmvVjStEA3ZZzY/JE49zLRXnKelE/qcb9lxpnxusa2DWbS5v2q4an3sdxEN9ZWtF Af1Y6IhmaioknToujafajrQw7LP0/J0= X-MC-Unique: kCAfQBctNPeWSabC_Dj5JA-1 X-Mimecast-MFC-AGG-ID: kCAfQBctNPeWSabC_Dj5JA_1741015854 From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH v2 01/11] qemu: Use modern header formatting in 'qemu_command.h' Date: Mon, 3 Mar 2025 16:30:39 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 4p33im5mv81gO4ljNbmICK5TRYl5XE70kZXysOyBX9E_1741015854 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: I2AXTQFIZY7I4JIOKK7BDJT5DXQZJNGM X-Message-ID-Hash: I2AXTQFIZY7I4JIOKK7BDJT5DXQZJNGM X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Stefan Hajnoczi X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1741015898211019100 Content-Type: text/plain; charset="utf-8" The file used intermixed style. Convert the last outliers to the new formatting style. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_command.h | 85 ++++++++++++++++++++++++----------------- 1 file changed, 50 insertions(+), 35 deletions(-) diff --git a/src/qemu/qemu_command.h b/src/qemu/qemu_command.h index 76c514b5f7..7c891a6c98 100644 --- a/src/qemu/qemu_command.h +++ b/src/qemu/qemu_command.h @@ -40,31 +40,37 @@ VIR_ENUM_DECL(qemuVideo); VIR_ENUM_DECL(qemuSoundCodec); -virCommand *qemuBuildCommandLine(virDomainObj *vm, - const char *migrateURI, - virDomainMomentObj *snapshot, - virNetDevVPortProfileOp vmop, - size_t *nnicindexes, - int **nicindexes); +virCommand * +qemuBuildCommandLine(virDomainObj *vm, + const char *migrateURI, + virDomainMomentObj *snapshot, + virNetDevVPortProfileOp vmop, + size_t *nnicindexes, + int **nicindexes); /* Generate the object properties for pr-manager */ -virJSONValue *qemuBuildPRManagerInfoProps(virStorageSource *src); -virJSONValue *qemuBuildPRManagedManagerInfoProps(qemuDomainObjPrivate *pri= v); +virJSONValue * +qemuBuildPRManagerInfoProps(virStorageSource *src); +virJSONValue * +qemuBuildPRManagedManagerInfoProps(qemuDomainObjPrivate *priv); -virJSONValue *qemuBuildDBusVMStateInfoProps(virQEMUDriver *driver, - virDomainObj *vm); +virJSONValue * +qemuBuildDBusVMStateInfoProps(virQEMUDriver *driver, + virDomainObj *vm); /* Generate the object properties for a secret */ -int qemuBuildSecretInfoProps(qemuDomainSecretInfo *secinfo, - virJSONValue **propsret); +int +qemuBuildSecretInfoProps(qemuDomainSecretInfo *secinfo, + virJSONValue **propsret); /* Generate the object properties for a tls-creds-x509 */ -int qemuBuildTLSx509BackendProps(const char *tlspath, - bool isListen, - bool verifypeer, - const char *alias, - const char *secalias, - virJSONValue **propsret); +int +qemuBuildTLSx509BackendProps(const char *tlspath, + bool isListen, + bool verifypeer, + const char *alias, + const char *secalias, + virJSONValue **propsret); /* Open a UNIX socket for chardev FD passing */ int @@ -93,7 +99,8 @@ qemuBuildNicDevProps(virDomainDef *def, virDomainNetDef *net, virQEMUCaps *qemuCaps); -bool qemuDiskBusIsSD(int bus); +bool +qemuDiskBusIsSD(int bus); int qemuBuildStorageSourceAttachPrepareCommon(virStorageSource *src, @@ -134,15 +141,16 @@ qemuBuildControllerDevProps(const virDomainDef *domai= nDef, virQEMUCaps *qemuCaps, virJSONValue **devprops); -int qemuBuildMemoryBackendProps(virJSONValue **backendProps, - const char *alias, - virQEMUDriverConfig *cfg, - qemuDomainObjPrivate *priv, - const virDomainDef *def, - const virDomainMemoryDef *mem, - bool force, - bool systemMemory, - virBitmap **nodemaskRet); +int +qemuBuildMemoryBackendProps(virJSONValue **backendProps, + const char *alias, + virQEMUDriverConfig *cfg, + qemuDomainObjPrivate *priv, + const virDomainDef *def, + const virDomainMemoryDef *mem, + bool force, + bool systemMemory, + virBitmap **nodemaskRet); virJSONValue * qemuBuildMemoryDeviceProps(virQEMUDriverConfig *cfg, @@ -166,8 +174,9 @@ virJSONValue * qemuBuildRNGDevProps(const virDomainDef *def, virDomainRNGDef *dev, virQEMUCaps *qemuCaps); -int qemuBuildRNGBackendProps(virDomainRNGDef *rng, - virJSONValue **props); +int +qemuBuildRNGBackendProps(virDomainRNGDef *rng, + virJSONValue **props); /* Current, best practice */ virJSONValue * @@ -210,10 +219,12 @@ qemuBuildZPCIDevProps(virDomainDeviceInfo *dev); bool qemuDiskConfigBlkdeviotuneEnabled(const virDomainDiskDef *disk); -virJSONValue *qemuBuildHotpluggableCPUProps(const virDomainVcpuDef *vcpu) +virJSONValue * +qemuBuildHotpluggableCPUProps(const virDomainVcpuDef *vcpu) ATTRIBUTE_NONNULL(1); -virJSONValue *qemuBuildShmemBackendMemProps(virDomainShmemDef *shmem) +virJSONValue * +qemuBuildShmemBackendMemProps(virDomainShmemDef *shmem) ATTRIBUTE_NONNULL(1); bool @@ -254,6 +265,10 @@ qemuBuildTPMOpenBackendFDs(const char *tpmdev, int *cancelfd) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3) G_NO_IN= LINE; -const char * qemuAudioDriverTypeToString(virDomainAudioType type); -virDomainAudioType qemuAudioDriverTypeFromString(const char *str); -int qemuVDPAConnect(const char *devicepath) G_NO_INLINE; +const char * +qemuAudioDriverTypeToString(virDomainAudioType type); +virDomainAudioType +qemuAudioDriverTypeFromString(const char *str); + +int +qemuVDPAConnect(const char *devicepath) G_NO_INLINE; --=20 2.48.1