From nobody Mon Feb 9 16:12:30 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1567611628; cv=none; d=zoho.com; s=zohoarc; b=OcovnOT31hYMy6vI9c573Vsa0HLY8klzKV3nwGCUlul9/qN1sWCTxWZ++Rq1MjY0rZzX4EquT2YQm+CtM4vYgZBqszeRkR0C3ZyGYHoh2gnI4vqOZeuy/VWF/dgxvZJlyDHs4DrdeC05CllyPnjswcct6E18V00CqmxzpQUkKt8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1567611628; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=IotVu7T3Gb1le+PHH8M1XwANXGQAegs4k1Xf8mAQ0PI=; b=dnMmdUr2FHiv1FwnVdmKCn5fWOYsVxZi1G4aM6DUr4MLJDCyMYcWvb3Fx5XjU9EQ35iXhxxaB8oSzu2CJMSgNFSfW/sHaJDQuxQMC9MKL9Zcu7wHBrwl/8m2tUL33+rkkbIUcYhGH9Ta9ihf26mIJjsT448f5n5t6AtDtJb2vBg= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1567611628483162.20906470691023; Wed, 4 Sep 2019 08:40:28 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 01D623082B41; Wed, 4 Sep 2019 15:40:27 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9E1C65F7C0; Wed, 4 Sep 2019 15:40:26 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D8BFEE203; Wed, 4 Sep 2019 15:40:25 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x84FdZ21028833 for ; Wed, 4 Sep 2019 11:39:35 -0400 Received: by smtp.corp.redhat.com (Postfix) id 246D960C18; Wed, 4 Sep 2019 15:39:35 +0000 (UTC) Received: from angien.brq.redhat.com (unknown [10.43.2.229]) by smtp.corp.redhat.com (Postfix) with ESMTP id A1CB460BFB for ; Wed, 4 Sep 2019 15:39:34 +0000 (UTC) From: Peter Krempa To: libvir-list@redhat.com Date: Wed, 4 Sep 2019 17:39:28 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 4/4] qemu: migration: Switch to blockdev mode for non-shared storage migration X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Wed, 04 Sep 2019 15:40:27 +0000 (UTC) Content-Type: text/plain; charset="utf-8" When blockdev is used we always should use the blockdev mode for non-shared storage migration. Signed-off-by: Peter Krempa --- src/qemu/qemu_migration.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index c13b21a0bb..6ff956b1f5 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -907,6 +907,7 @@ qemuMigrationSrcNBDStorageCopyOne(virQEMUDriverPtr driv= er, const char *tlsAlias, unsigned int flags) { + qemuDomainObjPrivatePtr priv =3D vm->privateData; qemuDomainDiskPrivatePtr diskPriv =3D QEMU_DOMAIN_DISK_PRIVATE(disk); qemuBlockJobDataPtr job =3D NULL; char *diskAlias =3D NULL; @@ -921,7 +922,8 @@ qemuMigrationSrcNBDStorageCopyOne(virQEMUDriverPtr driv= er, qemuBlockJobSyncBegin(job); - if (flags & VIR_MIGRATE_TLS) { + if (flags & VIR_MIGRATE_TLS || + virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BLOCKDEV)) { rc =3D qemuMigrationSrcNBDStorageCopyBlockdev(driver, vm, disk, diskAlias, host, port, --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list