From nobody Sun Feb 8 21:29:06 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1594894156; cv=none; d=zohomail.com; s=zohoarc; b=h3QRnNssTffchdfKtFqOU9Kum74wJAZ6KfOjQqtDlhJp5GjqreSuGjv87imWs4hOaTGp/dxfOalSJiZ9LKeo+Avtz+6aIKDq/wNs3r/DHAJBKj9WsouvSY3253u0gopR2npw7MJyv5LV1dxIOo1Y7np9YwWhfISyikQkFFdFMLM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594894156; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=5ewOETORjBX+ZErP1s9qAnXqrLPmQRGyaW6fsfKoEU0=; b=m40LVVhWiaLaENMDL8zyDquW4U97tFS+lpCVu6Sa71wk1tmt6Defi0q+G/m2sc8WFTuB4/PQVY5z+Fv9ikGe7bDJIur3FurJFo2mNaJ2FliIO2EqhG+3s9hw60YmKZkIYN8I3O0S7bK16SSQqc8XnAFrB/tFwJdnOeIpmFLwiSY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1594894156538687.9276428599991; Thu, 16 Jul 2020 03:09:16 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-435-YVW5sUbAM2a4u6lKVeOK2A-1; Thu, 16 Jul 2020 06:09:12 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3C3501888AA0; Thu, 16 Jul 2020 10:09:07 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1E0F65C5B7; Thu, 16 Jul 2020 10:09:07 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E37379A30F; Thu, 16 Jul 2020 10:09:06 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 06GA6goT019825 for ; Thu, 16 Jul 2020 06:06:42 -0400 Received: by smtp.corp.redhat.com (Postfix) id 6A1F22B6DC; Thu, 16 Jul 2020 10:06:42 +0000 (UTC) Received: from antique-work.redhat.com (unknown [10.40.194.85]) by smtp.corp.redhat.com (Postfix) with ESMTP id D91792B6DB for ; Thu, 16 Jul 2020 10:06:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594894155; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=5ewOETORjBX+ZErP1s9qAnXqrLPmQRGyaW6fsfKoEU0=; b=LxdWwGrh0Pw+m7NK4yRy+rWLHULT2uF9M5FA0bMh9fmEoZrC09wPOm1uO24NAVEV3UkuVz Xxnxfj+ypiVhjzeJRtQZgO/7XfbEv09lMsbuNc4xUjz0LlCZKSwVqO13GolXPr188x9Uyl YY2jUqKpWDVphfNP29fC6VdFx+RghRM= X-MC-Unique: YVW5sUbAM2a4u6lKVeOK2A-1 From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH 281/351] meson: tests: build commandhelper binary Date: Thu, 16 Jul 2020 11:58:37 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Pavel Hrdina --- tests/Makefile.am | 14 +------------- tests/meson.build | 17 +++++++++++++++++ 2 files changed, 18 insertions(+), 13 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 3bc1a791a16..eaaae0c0568 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -35,7 +35,7 @@ LDADDS =3D \ $(GLIB_LIBS) \ $(NULL) =20 -test_helpers =3D commandhelper ssh +test_helpers =3D ssh test_programs =3D virshtest sockettest \ virhostcputest virbuftest \ commandtest seclabeltest \ @@ -759,18 +759,6 @@ commandtest_SOURCES =3D \ commandtest.c testutils.h testutils.c commandtest_LDADD =3D $(LDADDS) =20 -# Must not link to any libvirt modules - libc only -# otherwise external libraries might unexpectedly leak -# file descriptors into commandhelper invalidating the -# test logic assumptions -commandhelper_SOURCES =3D \ - commandhelper.c -commandhelper_LDADD =3D \ - $(NO_INDIRECT_LDFLAGS) - -commandhelper_LDFLAGS =3D -static - - virkmodtest_SOURCES =3D \ virkmodtest.c testutils.h testutils.c virkmodtest_LDADD =3D $(LDADDS) diff --git a/tests/meson.build b/tests/meson.build index 5cbd3cd2077..fa116a0e249 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -170,3 +170,20 @@ test_file_wrapper_lib =3D static_library( [ 'virfilewrapper.c' ], dependencies: [ tests_dep ], ) + + +# build helpers used by tests + +# Must not link to any libvirt modules - libc only otherwise external +# libraries might unexpectedly leak file descriptors into commandhelper +# invalidating the test logic assumptions. +executable( + 'commandhelper', + [ 'commandhelper.c' ], + dependencies: [ + tests_dep, + ], + link_args: [ + libvirt_no_indirect, + ], +) --=20 2.26.2