From nobody Sun Feb 8 17:47:04 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1663577884; cv=none; d=zohomail.com; s=zohoarc; b=Q7IzoDeJApZoZ3eZ+IDNXUskHUKY1xZScrfstwk+HyTGJ3A8K1u/Knevb1aTQLHPUJ+zcBcqKawwpKdJlFRzEmsCiV+hLWNZZtxB3CTk3Qy9unm/BjQCP5PSxh9kU282vXRgIMW04XRxCS+6horoGRl+R67Iv/QMOwOy1Qw+4LM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1663577884; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=vZ40JzE/s6m5Kh5ddPNuh7KGR79fgY3S6lEYGyee5ts=; b=ShBOhaBtd/4h/D2U+kpW7dSaDZT9GydIEgdbyluALaoh89sPKO57iGj949k+sCNx1zBXN2QBBH4p/dEEPHqwWDMg7cdW5qxf1+cAhEBbaezmZCnGFTPGhla+C20auCFCGxzgsAAq3X06BZqc7CltN0toAmt7MlP/QabddZmrzwo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1663577884008546.9095057541938; Mon, 19 Sep 2022 01:58:04 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-284-j0OfNiM3OYePl2Vs4YMWEg-1; Mon, 19 Sep 2022 04:56:03 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 523A9185A794; Mon, 19 Sep 2022 08:56:00 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3C1D740C2064; Mon, 19 Sep 2022 08:56:00 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 2CCD91946594; Mon, 19 Sep 2022 08:56:00 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id B1B911946586 for ; Mon, 19 Sep 2022 08:55:58 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id A727940C6EC2; Mon, 19 Sep 2022 08:55:58 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id AC970414A81B for ; Mon, 19 Sep 2022 08:55:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663577881; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=vZ40JzE/s6m5Kh5ddPNuh7KGR79fgY3S6lEYGyee5ts=; b=Mi15YyyQ+Z+qJBojJILPDMUIPI3woI5y5hMVgwC1jiAY4Kxzu8dJXDZ9Nh2E/xpjTg5Itm xe1+ySq0sS+WwESyQW/II/qQGpg6cOX48mV8TomK+hlHwSVASRniKOoJfnzatOt9/QHPK5 Al44CkpaZjv0ElclefDbqoxJf3xvd9k= X-MC-Unique: j0OfNiM3OYePl2Vs4YMWEg-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 37/37] virDomainNetDefParseXML: Drop prehistoric error workaround Date: Mon, 19 Sep 2022 10:55:22 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1663577886044100001 Content-Type: text/plain; charset="utf-8" Apart from it being a long time ago the 'openvz' driver is also rarely used. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko Reviewed-by: Laine Stump --- src/conf/domain_conf.c | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d3755547c7..b7be1bae06 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -8998,7 +8998,6 @@ virDomainNetDefParseXML(virDomainXMLOption *xmlopt, VIR_XPATH_NODE_AUTORESTORE(ctxt) int rv; g_autofree char *macaddr =3D NULL; - g_autofree char *dev =3D NULL; g_autofree char *model =3D NULL; g_autofree char *linkstate =3D NULL; g_autofree char *tap =3D NULL; @@ -9120,25 +9119,6 @@ virDomainNetDefParseXML(virDomainXMLOption *xmlopt, break; case VIR_DOMAIN_NET_TYPE_ETHERNET: - /* This clause is only necessary because from 2010 to 2016 it was - * possible (but never documented) to configure the name of the - * guest-side interface of an openvz domain with . - * That was blatant misuse of , so was likely (hopefully) - * never used, but just in case there was somebody using it, we - * need to generate an error. If the openvz driver is ever - * deprecated, this clause can be removed from here. - */ - if (source_node) { - if ((dev =3D virXMLPropString(source_node, "dev"))) { - virReportError(VIR_ERR_XML_ERROR, - _("Invalid attempt to set " - "device name with . " - "Use (for host-side)= " - "or (for guest-side) = instead."), - dev, dev, dev); - return NULL; - } - } parse_filterref =3D true; break; --=20 2.37.1