From nobody Tue Sep 9 09:49:21 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1747057123; cv=none; d=zohomail.com; s=zohoarc; b=Z1ZHJB17Im2JDJgO4peUDRkETX89TO0Dk3IS1wwUz1IBoZugsUL0RaVI90AGr6004AC7yvRknMI9WP3i8HItCmGE5a+xMTuKMUBIaVpijN2VVviIXmZjn9LFeH2p5uXv/Kstjls4u6p1qe1xemx4q2gqDNMCWSpgNtqpFH/DBuE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1747057123; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=qwhzzSTYH4SHYHgMbcZsqwFmdyxvMf0/MMTe0WKYsNc=; b=f/tuUksqZ4J51Zs6AhROSKsAjuZmHYsmVT4SVMsxbkxbQro1NNFB7GA68fPOSsxrXs5CNj01m2pstaOoV01ju7hRC7cqiJo48ldn1ypQ5b3I8EVtpn2P8QfO5gSkONjUQsjrnhUQisDLy5Vsl1WqHvlQKSpQPLLpuxp3nhknHck= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1747057123432106.31131640955516; Mon, 12 May 2025 06:38:43 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 5A10B1290; Mon, 12 May 2025 09:38:42 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 13AAB12F2; Mon, 12 May 2025 09:37:36 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 656E012C2; Mon, 12 May 2025 09:37:30 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 9117D12B4 for ; Mon, 12 May 2025 09:37:25 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-607-GGnX51w3P1-jQZgcKK_EwA-1; Mon, 12 May 2025 09:37:24 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5B1D31800360 for ; Mon, 12 May 2025 13:37:23 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.3.236]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A6DA11801390 for ; Mon, 12 May 2025 13:37:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747057045; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SHW6KXoVtVYQ2se9OxVPhWu8u7mo3eSZ2EYy0Z3XQKs=; b=bTtKS79iJv6VpR7uH3YD95EFzBPT/0Wly6T58uSeBVwd3h3yWfcU1HnxVdZQc8DTMowHMf igdz2HSkzWXPiQrAnRJYJFXoIyImdHuyRk5wMF1gibBZ2U2imqnkYyKPc2Bw23XPb9nFof RJ1WTgxDimR2fksm1YsxtVP+zc2Mr+Q= X-MC-Unique: GGnX51w3P1-jQZgcKK_EwA-1 X-Mimecast-MFC-AGG-ID: GGnX51w3P1-jQZgcKK_EwA_1747057043 To: devel@lists.libvirt.org Subject: [PATCH 3/5] virnetdevbridge.c: Fix comments in virNetDevBridgeSetupVlans() Date: Mon, 12 May 2025 15:37:14 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: NdnUTSdrZT3ES-YinTrA737GN_oXgpp23oidWzYRjpg_1747057043 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 4FKID6ITXVK3VF73XQWSEEG7TZAI75E6 X-Message-ID-Hash: 4FKID6ITXVK3VF73XQWSEEG7TZAI75E6 X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1747057124351116600 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik We still use C89 style of comments. Fix C99 style of comments used in virNetDevBridgeSetupVlans(). Signed-off-by: Michal Privoznik Reviewed-by: Peter Krempa --- src/util/virnetdevbridge.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/util/virnetdevbridge.c b/src/util/virnetdevbridge.c index c79d0c79b7..3b54e2cb1e 100644 --- a/src/util/virnetdevbridge.c +++ b/src/util/virnetdevbridge.c @@ -322,7 +322,7 @@ virNetDevBridgeSetupVlans(const char *ifname, const vir= NetDevVlan *virtVlan) if (!virtVlan || !virtVlan->nTags) return 0; =20 - // The interface will have been automatically added to vlan 1, so remo= ve it + /* The interface will have been automatically added to vlan 1, so remo= ve it. */ if (virNetlinkBridgeVlanFilterSet(ifname, RTM_DELLINK, 0, 1, &error) <= 0) { if (error !=3D 0) { virReportSystemError(-error, @@ -332,7 +332,7 @@ virNetDevBridgeSetupVlans(const char *ifname, const vir= NetDevVlan *virtVlan) return -1; } =20 - // If trunk mode, add the native VLAN then add the others, if any + /* If trunk mode, add the native VLAN then add the others, if any. */ if (virtVlan->trunk) { size_t i; =20 @@ -357,7 +357,7 @@ virNetDevBridgeSetupVlans(const char *ifname, const vir= NetDevVlan *virtVlan) } } } else { - // In native mode, add the single VLAN as pvid untagged + /* In native mode, add the single VLAN as pvid untagged. */ flags =3D BRIDGE_VLAN_INFO_PVID | BRIDGE_VLAN_INFO_UNTAGGED; if (virNetlinkBridgeVlanFilterSet(ifname, RTM_SETLINK, flags, virtVlan->tag[0], &error) < 0) { --=20 2.49.0