From nobody Mon Feb 9 01:01:53 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1689683355; cv=none; d=zohomail.com; s=zohoarc; b=nhp/l/eVjC1KCWYA8+cIhTfgAqM7NratluHMIQEc5ayu2r1q8LR+ObhM0QYKHpwZBD3wRAZPQtHhwOxcltdD83UyN9lm49/ShWdDD30aEebcK4dKKBmaHhbVSviveRDmFTOTZc4DC52xo3iHNxfPHHqfqBiLdB0CD8jFzVUxv58= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1689683355; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=oj+/H9AAeVU0oG9vXSPlGFuP0kwC265ViDLgsNSn/SQ=; b=LlWD9DrtDVOuOOEyr7NOVG2GdE3gGjOl5m3/NY71cVi1Szxm6gGCE0EG/MT3ALtoISMafKn/gGhj8N0x5TBk+txCvNn8MH3RNlDmp7rPTq5xXOqSEjUgoiTgC7/5pFqaK2r4wHPsoaqnRyD9WvVcI0PAoe6+39lmHII1h8zTfCs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1689683355040383.06483268163197; Tue, 18 Jul 2023 05:29:15 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-524-wi72AXjsOXymdQrNGYS0tg-1; Tue, 18 Jul 2023 08:29:11 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D31418870D9; Tue, 18 Jul 2023 12:29:08 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8CDE3C57969; Tue, 18 Jul 2023 12:29:08 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 138B11946A44; Tue, 18 Jul 2023 12:29:03 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id CF017194658F for ; Tue, 18 Jul 2023 12:29:00 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 8A2D34067A22; Tue, 18 Jul 2023 12:29:00 +0000 (UTC) Received: from localhost.localdomain (unknown [10.43.2.36]) by smtp.corp.redhat.com (Postfix) with ESMTP id 31FF040C6CCD for ; Tue, 18 Jul 2023 12:29:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689683354; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=oj+/H9AAeVU0oG9vXSPlGFuP0kwC265ViDLgsNSn/SQ=; b=ALFUYzu8TYRL8EddDzLTHiOVAMo9T5Dr8qJWD1YnlK8e8fHtB0UrBJaYM5XXQZYtQIsBZh qY78CzvjLjuFBfdQbuepkrM3mFV+jf1D12IIWrRtan10cMwCw2ViOwv8sEBeC03bMqyklY wYLN9LQtfodqnOV0q/Zd9IHgP/WnD9A= X-MC-Unique: wi72AXjsOXymdQrNGYS0tg-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 2/2] tests: Refresh valgrind suppressions Date: Tue, 18 Jul 2023 14:28:57 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1689683356430100005 Content-Type: text/plain; charset="utf-8"; x-default="true" Since nobody is expected to run valgrind over scripts now, we can drop plenty of suppressions. Also, there are some old ones that no longer exist and new ones, that are not covered. Signed-off-by: Michal Privoznik Reviewed-by: Peter Krempa --- tests/.valgrind.supp | 188 ++++++++++--------------------------------- 1 file changed, 41 insertions(+), 147 deletions(-) diff --git a/tests/.valgrind.supp b/tests/.valgrind.supp index f78b3b1f72..9ccefab0df 100644 --- a/tests/.valgrind.supp +++ b/tests/.valgrind.supp @@ -1,163 +1,57 @@ { - bashMemoryLeak1 + glib-memory-leak1 Memcheck:Leak - fun:malloc - fun:xmalloc - ... - fun:execute_command_internal + match-leak-kinds: possible + fun:calloc + fun:allocate_dtv + fun:_dl_allocate_tls + fun:pthread_create@@GLIBC_2.34 + fun:g_system_thread_new ... - obj:*/bin/bash + fun:g_task_get_type_once + fun:g_task_get_type + fun:_g_dbus_initialize.part.0 + fun:g_dbus_error_new_for_dbus_error + fun:wrap_g_dbus_connection_call_sync } { - bashMemoryLeak2 + glib-memory-leak2 Memcheck:Leak + match-leak-kinds: possible fun:malloc - fun:xmalloc + fun:tsearch + fun:__add_to_environ + fun:setenv + fun:g_setenv ... - fun:yyparse - fun:parse_command - fun:read_command - ... - obj:*/bin/bash + fun:virTestMain + fun:main } { - bashMemoryLeak3 + commandtest Memcheck:Leak - fun:malloc - fun:xmalloc - fun:array_create - fun:array_copy - fun:run_exit_trap - fun:exit_shell - ... - obj:*/bin/bash + match-leak-kinds: possible + fun:calloc + fun:allocate_dtv + fun:_dl_allocate_tls + fun:pthread_create@@GLIBC_2.34 + fun:virThreadCreateFull + fun:virCommandRunAsync + fun:test21 + fun:virTestRun + fun:mymain + fun:virTestMain + fun:main } { - bashMemoryLeak4 + eventtest Memcheck:Leak - match-leak-kinds: definite - fun:malloc - fun:xmalloc - fun:set_default_locale + match-leak-kinds: possible + fun:calloc + fun:allocate_dtv + fun:_dl_allocate_tls + fun:pthread_create@@GLIBC_2.34 + fun:mymain + fun:virTestMain fun:main - ... - obj:*/bin/bash -} -# -# Failure seen in /usr/lib64/ld-2.15.so -# -{ - dlInitMemoryLeak1 - Memcheck:Leak - fun:?alloc - ... - fun:call_init.part.0 - fun:_dl_init - ... - obj:*/lib*/ld-2.*so* -} -# -# Failure seen in -# p11_kit_registered_module_to_name: /usr/lib64/libp11-kit.so.0.0.0 -# gnutls_pkcs11_init: /usr/lib64/libgnutls.so.26.22.4 -# -{ - gnutlsInitMemoryLeak - Memcheck:Leak - fun:malloc - fun:strdup - fun:p11_kit_registered_module_to_name - fun:gnutls_pkcs11_init - fun:gnutls_global_init - ... - obj:*/lib*/libc-2.*so* -} -# -# Failure seen in eventtest, qemumonitorjsontest, qemuhotplugtest, -# qemuagenttest -# -{ - dlAllocateTlsMemoryLeak - Memcheck:Leak - fun:calloc - fun:_dl_allocate_tls - fun:pthread_create* - ... - fun:mymain - fun:virtTestMain - ... - obj:*/lib*/libc-2.*so* -} -# -# commandtest validates the various threaded commands. The -# virThreadCreate() routine allocates and passes args to the -# new thread which now owns the 'args' and thus cannot be free'd -# -{ - commandtestLeak1 - Memcheck:Leak - fun:calloc - fun:virAlloc - fun:virThreadCreate - fun:mymain - fun:virtTestMain -} -# -# The Error code requires static memory that is never free'd -# for thread local storage to store error message/data -# -{ - commandtestLeak2 - Memcheck:Leak - fun:calloc - fun:virAlloc - ... - fun:vir*LastError* - fun:virEventRunDefaultImpl - fun:virCommandThreadWorker - fun:virThreadHelper - fun:start_thread - fun:clone -} -# -# Some of the commandtests (test0, test1, test4, & test18) cause the -# following traceback although it appears the memory is properly freed -# -{ - commandtestLeak3 - Memcheck:Leak - fun:calloc - fun:virAllocN - fun:virEventPollRunOnce - fun:virEventRunDefaultImpl - fun:virCommandThreadWorker - fun:virThreadHelper - fun:start_thread - fun:clone -} -# -# seclabeltest relies on 'selabel_close' which is not in libvirt -# -{ - seclabeltestcond1 - Memcheck:Cond - obj:/usr/lib64/libselinux.so.1 - fun:selabel_close - fun:virSecuritySELinuxSecurityDriverClose - fun:virSecurityManagerDispose - fun:virObjectUnref - fun:main -} -# -# types registered with GLib are never freed -# -{ - glibTypeRegisterLeak - Memcheck:Leak - match-leak-kinds: possible - ... - fun:g_realloc - obj:*/lib*/libgobject* - fun:g_type_register_static - ... } --=20 2.41.0