From nobody Sun Feb 8 18:14:04 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1675183478; cv=none; d=zohomail.com; s=zohoarc; b=fb1QlJndXU2ZxBBGgTFA3IHpWn3Lyl27YGyH/njtHwg5PaFHxwvxkD5tWZfHvsJh3hjtNQT9TjZyWGWHWa01CUZBBaME9pJhIRgSEHOUK9za3YPs8lNQuL/DiW7EYr8S4TpsbjEXVzhSJEZCGtdFUSHlwmOSpZFBG6deZIBbOrI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1675183478; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=n+EQPwLV9ESsIullAwGmXMLzLsXd8KR5K+Mu9x8NbHw=; b=CXKnb/jD9nt4/rJUXE8fc4W8dYM8yng4Ade8OuQ/8wTHqhEieGusHg5G1uC7Ib5S9hEy4RRyL6FuwzvX1LprpleY8eDMDAImoP5v3WzO51PXUauZ7S+iknALjzegA75OUG9HWv9bEQLRR532bCgSkfd18fZ0Ixu0yw+OjGXUZfY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1675183478150372.73601382527966; Tue, 31 Jan 2023 08:44:38 -0800 (PST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-299-gs0-XeJTPd-PRfpoFce-Kw-1; Tue, 31 Jan 2023 11:44:29 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A5F9E3810B1E; Tue, 31 Jan 2023 16:44:25 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8F96C40C2005; Tue, 31 Jan 2023 16:44:25 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id EB01319465B9; Tue, 31 Jan 2023 16:44:24 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 4B8811946587 for ; Tue, 31 Jan 2023 16:44:24 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 2FD8F492B06; Tue, 31 Jan 2023 16:44:24 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id CC5B7492B05 for ; Tue, 31 Jan 2023 16:44:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675183477; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=n+EQPwLV9ESsIullAwGmXMLzLsXd8KR5K+Mu9x8NbHw=; b=gxxMyGloKKTyDhUkJ2SUY64RyDyTS4G0C6aLVzxnD1tb7w1NKG10J5KappqPwnu/c91mqX PW9yUmdHwQ5D35HF4HCJFan58zOwloadK/EKrRk3DaJS/6kI0gPpzUWrHfjdxW7Q9gGxvp v+aoMC3SJ0JX+W8OrRKl4+q1flBI3Ug= X-MC-Unique: gs0-XeJTPd-PRfpoFce-Kw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 2/7] virDomainNetDefFormat: Rename @attrBuf to @targetAttrBuf Date: Tue, 31 Jan 2023 17:44:16 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1675183478597100001 Content-Type: text/plain; charset="utf-8"; x-default="true" The @attrBuf variable in virDomainNetDefFormat() is named too broadly. It holds attribute buffer to the element. Rename it to @targetAttrBuf then. Signed-off-by: Michal Privoznik --- src/conf/domain_conf.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 0cd6020ea3..382c32db67 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -23685,7 +23685,7 @@ virDomainNetDefFormat(virBuffer *buf, const char *typeStr; virDomainHostdevDef *hostdef =3D NULL; char macstr[VIR_MAC_STRING_BUFLEN]; - g_auto(virBuffer) attrBuf =3D VIR_BUFFER_INITIALIZER; + g_auto(virBuffer) targetAttrBuf =3D VIR_BUFFER_INITIALIZER; const char *prefix =3D xmlopt ? xmlopt->config.netPrefix : NULL; =20 /* publicActual is true if we should report the current state in @@ -23945,14 +23945,14 @@ virDomainNetDefFormat(virBuffer *buf, STRPREFIX(def->ifname, VIR_NET_GENERATED_MACVLAN_PREFIX) || (prefix && STRPREFIX(def->ifname, prefix)))))) { /* Skip auto-generated target names for inactive config. */ - virBufferEscapeString(&attrBuf, " dev=3D'%s'", def->ifname); + virBufferEscapeString(&targetAttrBuf, " dev=3D'%s'", def->ifname); } if (def->managed_tap !=3D VIR_TRISTATE_BOOL_ABSENT) { - virBufferAsprintf(&attrBuf, " managed=3D'%s'", + virBufferAsprintf(&targetAttrBuf, " managed=3D'%s'", virTristateBoolTypeToString(def->managed_tap)); } =20 - virXMLFormatElement(buf, "target", &attrBuf, NULL); + virXMLFormatElement(buf, "target", &targetAttrBuf, NULL); =20 if (def->ifname_guest || def->ifname_guest_actual) { virBufferAddLit(buf, "