From nobody Sun Feb 8 17:47:40 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1644346442; cv=none; d=zohomail.com; s=zohoarc; b=llZipaxrtBq2/0QnEdHz23E1lQtr4ewwIwgfQxVwB+Dc+cQQZa96b7aftu28oax+cwj2LKnkMNwjpEMwiwbJiskWzjTdM+iBdMmDI5oBy1HMwo+owjsVULlGySat0rPUgKZwzAnJouaS3BseLVWdoBNbKkWDOmqiqnd6EYIvPMw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1644346442; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=rh8sRIUIetZJZr5c51TR+BD2VgRM3BhfthbnocGeXc0=; b=BmLmM5W/82IJH4qX4K7aHMPDvU1B6EJjRwZvYNpShO3lRoNfFJQKu0aXx/ejcAyv+vLqlJyCUZeqR3O1roGI0Sa+unlk0af9qYJCZvM4iCx2D3IIflzU1yl0amiFCg+/Ta0PgEY+/8DbF16YaKUL1cHZ2BYooT/aKSDlJ9mf8ac= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1644346442885290.34616709370755; Tue, 8 Feb 2022 10:54:02 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-64-0vJYEVdJO2GsLZOoMI4rQw-1; Tue, 08 Feb 2022 13:53:19 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id ABD5F100C667; Tue, 8 Feb 2022 18:53:13 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8D65A7E123; Tue, 8 Feb 2022 18:53:13 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 5787B1826D18; Tue, 8 Feb 2022 18:53:13 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 217Bsiir032481 for ; Mon, 7 Feb 2022 06:54:44 -0500 Received: by smtp.corp.redhat.com (Postfix) id 579C66F959; Mon, 7 Feb 2022 11:54:44 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.40.208.41]) by smtp.corp.redhat.com (Postfix) with ESMTP id A92E96F9C2 for ; Mon, 7 Feb 2022 11:54:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644346441; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=rh8sRIUIetZJZr5c51TR+BD2VgRM3BhfthbnocGeXc0=; b=a6BYnpA4cnWQMRWXb0+/8k9sOhX7sIIPYN8ThRS6EzjmkL4gTKlxKxca5ana/T++PeioSv DGVKQASn8uGtxKMdSlVLRsaCzfNS2FG2XRBkB5CeKKWnnEoKOk6BxFQTgkfbGTbQ715zvm LcJ5bPbs5pkmkNyM+K50BIxQFzNWe+c= X-MC-Unique: 0vJYEVdJO2GsLZOoMI4rQw-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 5/7] qemu: process: Move cpu flag querying after code probing cpus Date: Mon, 7 Feb 2022 12:53:57 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1644346444870100003 Content-Type: text/plain; charset="utf-8" Upcoming changes will require that we have a proper QOM path for cpus when querying the flags as qemu is going to change it. By moving the flag probing code later we'll already probe the QOM paths so no re-query will be needed. Signed-off-by: Peter Krempa --- src/qemu/qemu_process.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 10e76583cf..f99b14b846 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -7573,10 +7573,6 @@ qemuProcessLaunch(virConnectPtr conn, if (qemuConnectAgent(driver, vm) < 0) goto cleanup; - VIR_DEBUG("Verifying and updating provided guest CPU"); - if (qemuProcessUpdateAndVerifyCPU(driver, vm, asyncJob) < 0) - goto cleanup; - VIR_DEBUG("setting up hotpluggable cpus"); if (qemuDomainHasHotpluggableStartupVcpus(vm->def)) { if (qemuDomainRefreshVcpuInfo(driver, vm, asyncJob, false) < 0) @@ -7598,6 +7594,10 @@ qemuProcessLaunch(virConnectPtr conn, qemuDomainVcpuPersistOrder(vm->def); + VIR_DEBUG("Verifying and updating provided guest CPU"); + if (qemuProcessUpdateAndVerifyCPU(driver, vm, asyncJob) < 0) + goto cleanup; + VIR_DEBUG("Detecting IOThread PIDs"); if (qemuProcessDetectIOThreadPIDs(driver, vm, asyncJob) < 0) goto cleanup; --=20 2.34.1