From nobody Sun Feb 8 16:36:11 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1566305973; cv=none; d=zoho.com; s=zohoarc; b=K7b1IDWjofBLWBg6Uf8/fPuDcbf/Bgoh9kWszTvxZWH/aRqwiKtp9GMQOZPqeiuO3R595F8y0pZazGLaEJoBNf97g0uTrJYNhwhoIsgKDxW/hdXqysVb6Mizks1EUTb6kBAzTAZk42Vl9XZQjHaFTACWYF2WW4HRRyT49lwF+CI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1566305973; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=dAUlaPRxB+RbKnYa8GX2p15Wvfj34oMaWMOsoMZTKq0=; b=XGn/BH5qgVfzkdDO5f4hTRvTqE/rfB8xG2QpjPiQ0bbUW6RxhDqTQKRAE9f84+oBrLp5M/JUT2BCl3g8ZIlKFQNDBUbsmJqN46n/7v7bx/JdQpcOBUvjW0LmzgsC4c7yf2831Z7K/hxA5fANSwPGtUP0XydTeUO1WTkxyihRTzU= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1566305973458601.8718853447435; Tue, 20 Aug 2019 05:59:33 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 39FFD30603AA; Tue, 20 Aug 2019 12:59:32 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 108A5453B; Tue, 20 Aug 2019 12:59:32 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C98652551F; Tue, 20 Aug 2019 12:59:31 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x7KCxNqM023114 for ; Tue, 20 Aug 2019 08:59:23 -0400 Received: by smtp.corp.redhat.com (Postfix) id C55804274; Tue, 20 Aug 2019 12:59:23 +0000 (UTC) Received: from icr.brq.redhat.com (unknown [10.43.2.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4F0CE18B69 for ; Tue, 20 Aug 2019 12:59:23 +0000 (UTC) From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Date: Tue, 20 Aug 2019 14:59:00 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 01/19] qemuBuildSerialChrDeviceStr: rename cmd to buf X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Tue, 20 Aug 2019 12:59:32 +0000 (UTC) We usually use 'cmd' for a virCommand(Ptr) variable. Signed-off-by: J=C3=A1n Tomko --- src/qemu/qemu_command.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index e3f4ef624b..98516d2627 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -10867,7 +10867,7 @@ qemuBuildSerialChrDeviceStr(char **deviceStr, virDomainChrDefPtr serial, virQEMUCapsPtr qemuCaps) { - virBuffer cmd =3D VIR_BUFFER_INITIALIZER; + virBuffer buf =3D VIR_BUFFER_INITIALIZER; virQEMUCapsFlags caps; =20 switch ((virDomainChrSerialTargetModel) serial->targetModel) { @@ -10901,21 +10901,21 @@ qemuBuildSerialChrDeviceStr(char **deviceStr, goto error; } =20 - virBufferAsprintf(&cmd, "%s,chardev=3Dchar%s,id=3D%s", + virBufferAsprintf(&buf, "%s,chardev=3Dchar%s,id=3D%s", virDomainChrSerialTargetModelTypeToString(serial->ta= rgetModel), serial->info.alias, serial->info.alias); =20 - if (qemuBuildDeviceAddressStr(&cmd, def, &serial->info, qemuCaps) < 0) + if (qemuBuildDeviceAddressStr(&buf, def, &serial->info, qemuCaps) < 0) goto error; =20 - if (virBufferCheckError(&cmd) < 0) + if (virBufferCheckError(&buf) < 0) goto error; =20 - *deviceStr =3D virBufferContentAndReset(&cmd); + *deviceStr =3D virBufferContentAndReset(&buf); return 0; =20 error: - virBufferFreeAndReset(&cmd); + virBufferFreeAndReset(&buf); return -1; } =20 --=20 2.19.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list