From nobody Mon Feb 9 07:38:20 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1642171227; cv=none; d=zohomail.com; s=zohoarc; b=Vqi7F8E6SN8299OWvZAZjOQjkEoKlGw+WTyz40sY/yla8qXyDZ6uzW2SkaeyQjrO/jbySOwR4fc8mNlJmo7w6ArD45/icCh807X++Xsl5fhAvFAs7xIa0WcuYCF7ZwUpNbmfGBVAqZ7nMRICsTWxTyGbnDFw81DP+c7UfN4iR8o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1642171227; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=e2qwRbmp1qMZYqbAoXzrZi0wrBV+1U3DuTOxK0Ypie0=; b=hLX1XZhWRDJqNxsrNqWv9QC3azBYANjSFj2TdXoBwESbQ9WB8IQ4XNgWsq2UdLUuZoU+sv8ANi1m6BQ1sht7yR9Hzol69C4yV41bA/GOXYkaO+XUN1zUT4/r4ZoKy2FjNfs6BhUE6CI5V16+nJ+fS9EJ/jqsHAFbMg0B6yr3sXM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1642171227624895.7475795596515; Fri, 14 Jan 2022 06:40:27 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-308-1M8FtY8EM5ufMSSm5BcNOw-1; Fri, 14 Jan 2022 09:40:25 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4E03610144EA; Fri, 14 Jan 2022 14:40:20 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2A32C7E2F3; Fri, 14 Jan 2022 14:40:20 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E7CFD18077BC; Fri, 14 Jan 2022 14:40:19 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 20EEe8bE029209 for ; Fri, 14 Jan 2022 09:40:08 -0500 Received: by smtp.corp.redhat.com (Postfix) id DDABA7B6ED; Fri, 14 Jan 2022 14:40:08 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id 50C8E7B6EB for ; Fri, 14 Jan 2022 14:40:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1642171226; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=e2qwRbmp1qMZYqbAoXzrZi0wrBV+1U3DuTOxK0Ypie0=; b=Nb1blkG+UaLQ9Zga2fbawpBBN/87GPqET4zNYkVPuTj166FO5cOYCc7FFwPhAE11oSjJbI OgPIlsgp7cGk/EwRbVaT5/Ksm2TAXVuX1ZZVCGsblWb7f0wf2JxhouioolHAqVf2PCpCH8 x+b2iJvB/43tigchtpM1Fbx2BzAcNQM= X-MC-Unique: 1M8FtY8EM5ufMSSm5BcNOw-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 01/11] storage_file: Declare virStorageSourceParseRBDColonString only in one header Date: Fri, 14 Jan 2022 15:39:45 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1642171228250100001 Content-Type: text/plain; charset="utf-8" The virStorageSourceParseRBDColonString() function is declared in src/storage_file/storage_source.h and src/storage_file/storage_source_backingstore.h but implemented only in the .c that corresponds to the latter header file. Therefore, drop declaration from storage_source.h as the function is not implemented in its corresponding .c file. Signed-off-by: Michal Privoznik Reviewed-by: J=C3=A1n Tomko --- src/libxl/xen_xl.c | 1 + src/storage_file/storage_source.h | 5 ----- src/storage_file/storage_source_backingstore.h | 3 ++- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/libxl/xen_xl.c b/src/libxl/xen_xl.c index 7604e3d534..94268fb76d 100644 --- a/src/libxl/xen_xl.c +++ b/src/libxl/xen_xl.c @@ -30,6 +30,7 @@ #include "viralloc.h" #include "virstring.h" #include "storage_source.h" +#include "storage_source_backingstore.h" #include "xen_xl.h" #include "libxl_capabilities.h" #include "libxl_conf.h" diff --git a/src/storage_file/storage_source.h b/src/storage_file/storage_s= ource.h index 5aaf4c356a..0ae06f4e7d 100644 --- a/src/storage_file/storage_source.h +++ b/src/storage_file/storage_source.h @@ -66,11 +66,6 @@ int virStorageSourceNewFromBacking(virStorageSource *parent, virStorageSource **backing); =20 -int -virStorageSourceParseRBDColonString(const char *rbdstr, - virStorageSource *src) - ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); - int virStorageSourceGetRelativeBackingPath(virStorageSource *top, virStorageSource *base, diff --git a/src/storage_file/storage_source_backingstore.h b/src/storage_f= ile/storage_source_backingstore.h index f5ec8e9154..e7e2a58eb9 100644 --- a/src/storage_file/storage_source_backingstore.h +++ b/src/storage_file/storage_source_backingstore.h @@ -29,7 +29,8 @@ virStorageSourceParseBackingURI(virStorageSource *src, =20 int virStorageSourceParseRBDColonString(const char *rbdstr, - virStorageSource *src); + virStorageSource *src) + ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); =20 int virStorageSourceParseBackingColon(virStorageSource *src, --=20 2.34.1