From nobody Sun Feb 8 12:13:43 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1601967609; cv=none; d=zohomail.com; s=zohoarc; b=XJhQ62qwXjpEQ+O0mH3UReVZX6uLOkj8jdC+jdbof6Tj8cUYP+s95+uklJONk5kOwaM+Pfy9NI8ycvSZ0e44uxC5Ju0pdbxxU27WY2uBHir94a1uLv1CbaxSuiP31dzOV0Ix9MoTDnVoESe8B+Kkne5/pcZTP9vftG+olYZxvLU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1601967609; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=nsm2CHWpJ11z/KbF+8s6o8yIAkUAmOEc2GWNqpUyFkg=; b=h7Dl/JO9VY15o54GwyeszkygiPNagAH8ecDw53tvpwiUf0wsego0nwxMpOWbxd/Ch5MlN+ZxH8UG4+O0I7lNg31Q0QuLRDeyf9YmHIrwcdsOkWbgDYnwQ6wOmWzlSKPXa/oeyz1EM0kyDjG2coY9re0EQydoZMzEhha1QIipHHA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1601967609222971.2939382488876; Tue, 6 Oct 2020 00:00:09 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-576-XFhu2W6NNOO7n-ap9Pwqpg-1; Tue, 06 Oct 2020 02:59:29 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E7B0910866B7; Tue, 6 Oct 2020 06:59:19 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C356E19C4F; Tue, 6 Oct 2020 06:59:19 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8CEEB181A869; Tue, 6 Oct 2020 06:59:19 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0966x5tV018654 for ; Tue, 6 Oct 2020 02:59:05 -0400 Received: by smtp.corp.redhat.com (Postfix) id 82F085C1BD; Tue, 6 Oct 2020 06:59:05 +0000 (UTC) Received: from hjs.redhat.com (unknown [10.43.2.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0AE145C22B for ; Tue, 6 Oct 2020 06:59:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601967607; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=nsm2CHWpJ11z/KbF+8s6o8yIAkUAmOEc2GWNqpUyFkg=; b=BYhoJu9TpKo+knKZ+y2KHci86aySL1IyNFbIvUcv8K4BltBIfvJGHN5Or2+9RQIXoi5WCb 0XbOFf/8PfXcuOH1W30ZKbiXIzyBZ9s7q2Lr45xzkmES3LHp0u/9wMj8qAFhhegr3B3E/q Ndjbh+6BqgyKZ1EZhC0zyzFG0akj/XU= X-MC-Unique: XFhu2W6NNOO7n-ap9Pwqpg-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 08/14] qemu: agent: simplify access to ifaces_ret Date: Tue, 6 Oct 2020 08:58:44 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) We have a local 'iface' variable that contains the same value eventually. Initialize it early instead of indexing two more times. Signed-off-by: J=C3=A1n Tomko --- src/qemu/qemu_agent.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index d0319cc0c7..7a4f5cd6db 100644 --- a/src/qemu/qemu_agent.c +++ b/src/qemu/qemu_agent.c @@ -2176,15 +2176,13 @@ qemuAgentGetInterfaces(qemuAgentPtr agent, if (VIR_EXPAND_N(ifaces_ret, ifaces_count, 1) < 0) goto error; =20 - ifaces_ret[ifaces_count - 1] =3D g_new0(virDomainInterface, 1); + iface =3D g_new0(virDomainInterface, 1); + ifaces_ret[ifaces_count - 1] =3D iface; =20 - if (virHashAddEntry(ifaces_store, ifname_s, - ifaces_ret[ifaces_count - 1]) < 0) + if (virHashAddEntry(ifaces_store, ifname_s, iface) < 0) goto error; =20 - iface =3D ifaces_ret[ifaces_count - 1]; iface->naddrs =3D 0; - iface->name =3D g_strdup(ifname_s); =20 hwaddr =3D virJSONValueObjectGetString(tmp_iface, "hardware-ad= dress"); --=20 2.26.2