From nobody Fri Dec 19 21:50:30 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1629816366; cv=none; d=zohomail.com; s=zohoarc; b=WvxxvxnIWB+nR+vLQYIiZaQNZhtcTVl14bAN40WrgNSDUwoE1tefLs7NLvZNcjd7Wv6+BPUqAg5b1xsP3SYj4FqTsT1PHny7iJV22guCReRYQUfZGDapCrA5ofbzeynWHmwQUDliRs1nspaD8fIcTe6Jh694c1HxiFKwpliKmxY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1629816366; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=B8hp/ActkkTj5bxCmLWFjjspBYYL7RSOy5eeEfSPBhI=; b=Ac4AuNbBYPxyMIYLjZtofDSRQGteVid8FzsXkhzcGcKLh0aYjiMD7joAtCEokaDB401YJVXQW0VA6Hqc993p3Gmw7/1tnnCjqw8jAGRUvoFNL/ZM08eiEpc+hmjtvJz1AaV1qvvNAbGHKZ2xDQ0CbH8vtKBaysa6VxhglyMubf0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1629816366497822.063574603246; Tue, 24 Aug 2021 07:46:06 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-252-VgKFYeKDPAq8XKYrFvJm6Q-1; Tue, 24 Aug 2021 10:45:09 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EE0EF101C8A6; Tue, 24 Aug 2021 14:45:03 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C06F21017CE8; Tue, 24 Aug 2021 14:45:03 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8FD7C4A7C9; Tue, 24 Aug 2021 14:45:03 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 17OEj2RM005478 for ; Tue, 24 Aug 2021 10:45:02 -0400 Received: by smtp.corp.redhat.com (Postfix) id DF68B6A8FE; Tue, 24 Aug 2021 14:45:02 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.40.208.33]) by smtp.corp.redhat.com (Postfix) with ESMTP id 368016A8F7 for ; Tue, 24 Aug 2021 14:44:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629816365; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=B8hp/ActkkTj5bxCmLWFjjspBYYL7RSOy5eeEfSPBhI=; b=JOVS+9alBsuKGUjAxbUzuir16Sqrxa/pSmZkFsf7c5ogGL1UjTR6bduxqQvyxU0S7SsrhV ZaYXAkcoPPXerosjaTT1nWP0UtsAnvkB4J/8OK4tBOQdfw1u1mL6jCuZE/ahuoq9lUU2ff yfAQKxtCFmV7g+pDJqeH6jNgCFUOVyQ= X-MC-Unique: VgKFYeKDPAq8XKYrFvJm6Q-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 02/22] qemuDomainSetLifecycleAction: Add a note about argument range-check Date: Tue, 24 Aug 2021 16:44:23 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1629816367299100001 Content-Type: text/plain; charset="utf-8" The public API wrapper range-checks the arguments. Save the next reader the hassle of looking it up. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 444e9e5cbc..2de17aaa4e 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -19654,6 +19654,8 @@ qemuDomainSetLifecycleAction(virDomainPtr dom, virDomainDef *persistentDef =3D NULL; int ret =3D -1; + /* note that 'action' and 'type' are range-checked in the public API w= rapper */ + virCheckFlags(VIR_DOMAIN_AFFECT_LIVE | VIR_DOMAIN_AFFECT_CONFIG, -1); --=20 2.31.1