From nobody Sun Feb 8 19:57:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1603359364; cv=none; d=zohomail.com; s=zohoarc; b=FdNKWZklkVACF309gTg0WMZMIIxR9eRxARX7FNVHJZ8RKnReSvtKaTluE8JHeENebT/lpPpyWJZnbs8cmxsCij2v/TcTv8340oKyZrdsuos1FCcXwJ7wErKny8oY7QMP+6sNV4mFlHRD6VeCVYQVMqPJVh2S97+eK7qeStKSNJQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603359364; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qzzvZxraEhP+TWkqxL2cg4XK9cxkyWFNzcPlWcd59ck=; b=DCfAxUsmFNHyAet1uNgZuCH000xkr2CbwTkGx1riCvDkflpSBiRNkVtPWJpGEgfR64+4HvKBfpGdTU+EDXf37YRq3oS79ssGQR4iQcKssibkM75gXRsRueveKlCXQuzVy1K4Td1sWy4qSb59eYE+6zjruvUUvMJ6NV2yWE2NCUg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1603359364362216.1570520923475; Thu, 22 Oct 2020 02:36:04 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-362-mlUenTw6NQKOj09d-qE9oQ-1; Thu, 22 Oct 2020 05:35:46 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9D18B879525; Thu, 22 Oct 2020 09:35:41 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7CD3F6EF75; Thu, 22 Oct 2020 09:35:41 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 499E718184AE; Thu, 22 Oct 2020 09:35:41 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 09M9ZCBB024440 for ; Thu, 22 Oct 2020 05:35:12 -0400 Received: by smtp.corp.redhat.com (Postfix) id B28D25B4A3; Thu, 22 Oct 2020 09:35:12 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.40.208.55]) by smtp.corp.redhat.com (Postfix) with ESMTP id EC6BA5B4B3 for ; Thu, 22 Oct 2020 09:35:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603359363; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=qzzvZxraEhP+TWkqxL2cg4XK9cxkyWFNzcPlWcd59ck=; b=h53hC6SFd9ByjKRIP78B0rSNorKS/RwdPMlTFdkvSCusyC4Y06bQue+S4f593mZuraD4CI tfvyVqcwuQxdfZZ6L984CjvKdOuyQNhd5UXm+muXR9BMenlByHzXfABi3FojMSo92ElN0X PfT8sxS8ef31+1F9zNOSTTkqULt0adM= X-MC-Unique: mlUenTw6NQKOj09d-qE9oQ-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 01/15] virCgroupKillRecursive: Return -1 on failure condition Date: Thu, 22 Oct 2020 11:34:52 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" virCgroupKillRecursive sneakily initializes 'ret' to 0 rather than the usual -1. 401030499bf moved an error condition but didn't actually modify 'ret' return the proper error code. Fixes: 401030499bf Signed-off-by: Peter Krempa Reviewed-by: Pavel Hrdina --- src/util/vircgroup.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index d408e3366f..5f4cb01bc0 100644 --- a/src/util/vircgroup.c +++ b/src/util/vircgroup.c @@ -2591,6 +2591,7 @@ virCgroupKillRecursive(virCgroupPtr group, int signum) if (!backends || !backendAvailable) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("no cgroup backend available")); + ret =3D -1; goto cleanup; } --=20 2.26.2