From nobody Sat May 30 15:29:22 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1779275674; cv=none; d=zohomail.com; s=zohoarc; b=BpWpDuP55e7R8B6QCKBr6fDmBvbOrhCALg4otOPwmGBTBcwqWQWUA6xHfkcCTlDE1ZNhTU9b379rSKnJ2qgj2BQeo409gdntTzekLTUWx/1SZVguIMktMXw6OWu8wtjodA8jIChvdryNTe7Sk3Wx+PncP6sqnYN+x5lssPOVTps= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1779275674; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=r+eOtADdQFUez77g5RfOjjFvEeAv0umiPsBf5CSODEk=; b=iUdyX/HAUi6+tqIeIV6lZ1nf3XKXQtogAoOg5BxYp1ecvXaptXlwBtIVJwy5/nCB3PGeizwMdn5B5b2ehznkd1c2Ukc8hmmwB9XJ9VzVh1Ut5ecLgFsWoCOql6vl6j5OVLNY5DdzfXMH3dBjW8AlyB75SUMgKtMkVOJo2QfnuOE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1779275674128592.1644566313711; Wed, 20 May 2026 04:14:34 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 7FF9741988; Wed, 20 May 2026 07:14:33 -0400 (EDT) Received: from [172.19.199.4] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 1A50741CBB; Wed, 20 May 2026 07:08:54 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 168004197C; Wed, 20 May 2026 07:08:33 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 881EC419ED for ; Wed, 20 May 2026 06:48:33 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-100-bK4SAY5BMQSyux04Z0ONtg-1; Wed, 20 May 2026 06:48:31 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EF82318005B8 for ; Wed, 20 May 2026 10:48:30 +0000 (UTC) Received: from moe (unknown [10.43.3.236]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 50DBD1956053 for ; Wed, 20 May 2026 10:48:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779274113; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=r+eOtADdQFUez77g5RfOjjFvEeAv0umiPsBf5CSODEk=; b=ZxUWUFMa0gagzuVwC6Bf0zR9FFFNZ0M3yIHnGCNjD28WoHLE4jDb1ulM/wLCNNm92qly4W 22RK2LJSB1AjGfMmlIWMIE6MM8HP2pe3vRrcU99CHeDBMVPr4fZybExMTENKSEZnVnMDyi 9cubErcCEiIJI9N370EsoX5cEwmSomg= X-MC-Unique: bK4SAY5BMQSyux04Z0ONtg-1 X-Mimecast-MFC-AGG-ID: bK4SAY5BMQSyux04Z0ONtg_1779274111 To: devel@lists.libvirt.org Subject: [PATCH] conf: Assert virDomainChrDeviceState and virConnectDomainEventAgentLifecycleState enums are in sync Date: Wed, 20 May 2026 12:48:27 +0200 Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: -dn2shmI2Z4wkfpTI4y8c7i-3BE6sktCaYh0vHuw_bM_1779274111 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 5J3HBDT4ZXVVDUDQIQ4SXFKD674TVDOV X-Message-ID-Hash: 5J3HBDT4ZXVVDUDQIQ4SXFKD674TVDOV X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1779275675655154100 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik When QEMU driver emits agent connected/disconnected events (inside of processSerialChangedEvent()) it declares a variable of virDomainChrDeviceState enum, and then passes this variable to virDomainEventAgentLifecycleNewFromObj(). But we document the agent lifecycle state to be of virConnectDomainEventAgentLifecycleState enum. Therefore, make sure values from virConnectDomainEventAgentLifecycleState enum are of the same value as those invirDomainChrDeviceState enum. Signed-off-by: Michal Privoznik Reviewed-by: J=C3=A1n Tomko --- src/conf/domain_conf.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index bdfb99ed1d..d17f6352bd 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -1243,6 +1243,11 @@ typedef enum { VIR_DOMAIN_CHR_DEVICE_STATE_LAST } virDomainChrDeviceState; =20 +G_STATIC_ASSERT((int)VIR_DOMAIN_CHR_DEVICE_STATE_CONNECTED =3D=3D + (int)VIR_CONNECT_DOMAIN_EVENT_AGENT_LIFECYCLE_STATE_CONNEC= TED); +G_STATIC_ASSERT((int)VIR_DOMAIN_CHR_DEVICE_STATE_DISCONNECTED =3D=3D + (int)VIR_CONNECT_DOMAIN_EVENT_AGENT_LIFECYCLE_STATE_DISCON= NECTED); + VIR_ENUM_DECL(virDomainChrDeviceState); =20 typedef enum { --=20 2.53.0