From nobody Mon Feb 9 10:32:28 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1652793429; cv=none; d=zohomail.com; s=zohoarc; b=g6DZSXXyBIuk7NtS8H8LReX82BfVuUuB3UIXXTVBx1nZZfhA2lCqJlCx4feXRrtYmQizTOfCPRtoICE73U1uBpRuf2LWzWHws4p//+nR/KqvQckVdQl61jpQobi76yjdXGduYVJ3/4KIMVdnA40wtMb7yIaEb1IVDzeNqAq2Z/Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652793429; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qGiRhc3hj46GCH0aMfdZYf+J2UcpWaW5Qm7hYgsxXmQ=; b=O02tpKXcmbHQE6pNF8mCpqiohrkkGsZ5Ae4KCX4tVNnbuUfpLP9N5HlQDb19k/S3k5ngGgpj892xm4emX/yhdpaYQsW3bN2LpVm3y4meFlY3sY/P9FkPf1N2lQf5aPKHMApbcFnAEQu08WTT7SGpQxLPyvH6ksBD6pMWjEa7Kso= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1652793428999614.8867003502235; Tue, 17 May 2022 06:17:08 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-416-0zug4WvbPjSynoHg4zJ_cQ-1; Tue, 17 May 2022 09:17:02 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4CAD4100BAC3; Tue, 17 May 2022 13:16:52 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 358B0403151; Tue, 17 May 2022 13:16:52 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id E70FE194705F; Tue, 17 May 2022 13:16:51 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id C9C261947B81 for ; Tue, 17 May 2022 13:16:49 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id B03BF42D4E7; Tue, 17 May 2022 13:16:49 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.21]) by smtp.corp.redhat.com (Postfix) with ESMTP id 01B8D42D4DB for ; Tue, 17 May 2022 13:16:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652793427; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=qGiRhc3hj46GCH0aMfdZYf+J2UcpWaW5Qm7hYgsxXmQ=; b=RbzgpYhaE4WctgeoUhygH9rRgumnYXFc990cIvkjPtplPTkfbDrXisbJN/xbgH6I44ow/H unwZWznYwCkm425MEpmh32DCWG2SglnjtpJdaf+XKwJ+S/asuu/j5ilqmUuzeOVVYa1dth oFf+tPlhs+ABwnhwxRUBdMYOIqzzMrs= X-MC-Unique: 0zug4WvbPjSynoHg4zJ_cQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 02/10] virObjectLockGuard: Require that returned value is used Date: Tue, 17 May 2022 15:16:37 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1652793430823100001 Content-Type: text/plain; charset="utf-8" The returned value is used to unlock the object, so all callers must necessarily make use of the returned value. Signed-off-by: Peter Krempa --- src/util/virobject.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virobject.h b/src/util/virobject.h index a1e16aee77..4b941ac215 100644 --- a/src/util/virobject.h +++ b/src/util/virobject.h @@ -120,7 +120,7 @@ virObjectRWLockableNew(virClass *klass) virLockGuard virObjectLockGuard(void *lockableobj) - ATTRIBUTE_NONNULL(1); + ATTRIBUTE_NONNULL(1) G_GNUC_WARN_UNUSED_RESULT; void virObjectLock(void *lockableobj) --=20 2.35.3