From nobody Sun Feb 8 23:26:50 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1693228304; cv=none; d=zohomail.com; s=zohoarc; b=VQ/ah0iuVDmWPJd6aOo5agW08zTaiA2MwOZUxPHcQi2mLNzwex4MMINd2pk9/5lrbJ5dDgVx0UJ6dxshTjyxYkc8X7WSAJhnyAkSzU7s6aAiF3ezIrkc0i1Hkv6Vsx4uUtvH9LOz1LTLJyfuLsrLqA02OcTjDFuMC88jRSqJVak= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1693228304; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=zxl45kfL1GbxEXaRcsT/3nBcsYni9VDMqEzN4T6KW10=; b=EBbj14LMtDKOOaxM5E+cxpSUUErBT4fdlXXjcnAX3/ztQ1Fw98NUkbn+xOkqdWf3RZ8MMUFQ9uV5VHteeH4yfj4ZzMQ747q+VGmVeXj19UcjyPi2xyM4BzAckR+S/kIVjjL3hJPti4pIdHL7MmWm9Rb7zsHlRQabWsh0S7pZl4I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1693228304870478.62615879380076; Mon, 28 Aug 2023 06:11:44 -0700 (PDT) Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-634-72I5oznBOciJZoW4PJKRXg-1; Mon, 28 Aug 2023 09:11:38 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C9CB53C0FC95; Mon, 28 Aug 2023 13:11:34 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0B4B240C2063; Mon, 28 Aug 2023 13:11:32 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id AA1E519465A8; Mon, 28 Aug 2023 13:11:31 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 284531946587 for ; Mon, 28 Aug 2023 13:11:30 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 0885B2166B26; Mon, 28 Aug 2023 13:11:30 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.22]) by smtp.corp.redhat.com (Postfix) with ESMTP id 822ED2166B25 for ; Mon, 28 Aug 2023 13:11:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1693228303; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=zxl45kfL1GbxEXaRcsT/3nBcsYni9VDMqEzN4T6KW10=; b=J/aPAWyH3PbcZLIo2fspVs4p7lPGuAH7XtQpXKNyKJne2gyN3/Tlz0AFvtNrKdnuUBUYay QWDN7d0+sO+Qg9d8qgUwV91CaNjRGfbCmEl/lib4dSeVKUtfkkR62gGZaBu5Uy0/Z2JIo0 3wrmepyWrLdfquXJ3RmoMqko+NzIMW4= X-MC-Unique: 72I5oznBOciJZoW4PJKRXg-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 1/9] qemu: Rename qemuDomainSupportsNewVcpuHotplug to qemuDomainSupportsVcpuHotplug Date: Mon, 28 Aug 2023 15:11:19 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1693228306815100001 Content-Type: text/plain; charset="utf-8" Support for legacy cpu hotplug was removed a long time ago. At this point this function only checks whether the current machine type supports cpu hotplug. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 4 ++-- src/qemu/qemu_domain.h | 2 +- src/qemu/qemu_hotplug.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index bfeddc7746..49ae44fcbf 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -9998,7 +9998,7 @@ qemuDomainValidateVcpuInfo(virDomainObj *vm) bool -qemuDomainSupportsNewVcpuHotplug(virDomainObj *vm) +qemuDomainSupportsVcpuHotplug(virDomainObj *vm) { qemuDomainObjPrivate *priv =3D vm->privateData; @@ -10035,7 +10035,7 @@ qemuDomainRefreshVcpuInfo(virDomainObj *vm, int rc; int ret =3D -1; - hotplug =3D qemuDomainSupportsNewVcpuHotplug(vm); + hotplug =3D qemuDomainSupportsVcpuHotplug(vm); VIR_DEBUG("Maxvcpus %zu hotplug %d", maxvcpus, hotplug); if (qemuDomainObjEnterMonitorAsync(vm, asyncJob) < 0) diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h index 786f239495..15d1bb4900 100644 --- a/src/qemu/qemu_domain.h +++ b/src/qemu/qemu_domain.h @@ -860,7 +860,7 @@ int qemuDomainSetMaxMemLock(virDomainObj *vm, int qemuDomainDefValidateMemoryHotplug(const virDomainDef *def, const virDomainMemoryDef *mem); -bool qemuDomainSupportsNewVcpuHotplug(virDomainObj *vm); +bool qemuDomainSupportsVcpuHotplug(virDomainObj *vm); bool qemuDomainHasVcpuPids(virDomainObj *vm); pid_t qemuDomainGetVcpuPid(virDomainObj *vm, unsigned int vcpuid); int qemuDomainValidateVcpuInfo(virDomainObj *vm); diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index d7d1db8ecc..d845731aee 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -6400,7 +6400,7 @@ qemuDomainHotplugAddVcpu(virQEMUDriver *driver, size_t i; bool vcpuTidMissing =3D false; - if (!qemuDomainSupportsNewVcpuHotplug(vm)) { + if (!qemuDomainSupportsVcpuHotplug(vm)) { virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", _("cpu hotplug is not supported")); return -1; @@ -6846,7 +6846,7 @@ qemuDomainSetVcpuInternal(virQEMUDriver *driver, g_autoptr(virBitmap) livevcpus =3D NULL; if (def) { - if (!qemuDomainSupportsNewVcpuHotplug(vm)) { + if (!qemuDomainSupportsVcpuHotplug(vm)) { virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", _("this qemu version does not support specific " "vCPU hotplug")); --=20 2.41.0