From nobody Sun Feb 8 21:11:41 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1594818655; cv=none; d=zohomail.com; s=zohoarc; b=ivc3PNfT4Ny0oqcP3oJ+Pr511PEb+lOxwuu7VTUWZqBEk3OWRmymayya4xxSzizswz2ceY5HffSChxIRzsH14r/sy2BP5yB3xpyuBbkp2kB9OCUovsJA2nzP1EGclP5i1tbXJG63yjNtBIgNyUIbqe/a9uo23PFQPxJe/flIQQ4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594818655; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=v2Rh6JbeeruArli3uIvZk1S3okktfPKjxJx5j3VI/CQ=; b=V74o49KqTWxbZSe2rSSk9HGmITXRoMAuUX/kSWJ7Dk4ex3GIoGJmsOy3VHrgCWBo90hlHm82cN78349JezI3pWwHcVHrNY5++sPo+cQHyvtWxOv1QgCUY3c6P8txheq/tUgCh/wzjDfIPSE7SfT7akJtweBzYZhheCip1weTFAY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 15948186557244.4834750473828535; Wed, 15 Jul 2020 06:10:55 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-427-Hhzer-zjMx6xh9xavnuFJA-1; Wed, 15 Jul 2020 09:10:52 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 222A7107ACCA; Wed, 15 Jul 2020 13:10:46 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0327178A53; Wed, 15 Jul 2020 13:10:46 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C1F8518005C5; Wed, 15 Jul 2020 13:10:45 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 06FDANUJ005756 for ; Wed, 15 Jul 2020 09:10:23 -0400 Received: by smtp.corp.redhat.com (Postfix) id 1B33E19079; Wed, 15 Jul 2020 13:10:23 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.40.208.29]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7A81470100 for ; Wed, 15 Jul 2020 13:10:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594818654; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=v2Rh6JbeeruArli3uIvZk1S3okktfPKjxJx5j3VI/CQ=; b=ISn9xIOYeXFoLNc9sMXKirDHzdetQrCxUw351HfQ9asXeVy89Z1Lf4djpqHqjP2F8nTVfZ u7Z14WdIHmTXmtu+TEFZXpcyh8v825MnLFtBmRVgmft72lxcoWfOv7v0fHIKN5JEaIuuMw CfOUkYrM3ZAY9WtLeLddHTGKhdh+AL0= X-MC-Unique: Hhzer-zjMx6xh9xavnuFJA-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 05/10] virDomainSetBlockThreshold: Clarify values of @dev the event is fired for Date: Wed, 15 Jul 2020 15:10:07 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Top level image may get two events, one with the disk target (vda) and one with disk target with index (vda[3]) if the top level image has an index. Signed-off-by: Peter Krempa Reviewed-by: Eric Blake --- src/libvirt-domain.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index ba30d18f65..6c5ff5b0db 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -12370,6 +12370,10 @@ int virDomainGetGuestInfo(virDomainPtr domain, * described by @dev is written beyond the set threshold level. The thresh= old * level is unset once the event fires. The event might not be delivered a= t all * if libvirtd was not running at the moment when the threshold was reache= d. + * Note that if the threshold level is reached for a top level image the e= vent + * is emitted for @dev corresponding to the disk target, and may also be r= eported + * with @dev corresponding to the disk target with an index corresponding = to the + * 'index' attribute of 'source' in the live VM XML if the atribute is pre= sent. * * @dev can either be a disk target name (vda, sda) or disk target with in= dex ( * vda[4]). Without the index the top image in the backing chain will have= the --=20 2.26.2