From nobody Mon Feb 9 09:08:28 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1631177381; cv=none; d=zohomail.com; s=zohoarc; b=KV6Ga2+pZswVcv8TUcL7TszhYB9jyyRM+v9JKWUpWpaoP/yBmB1zmjQtDOKVJLHcsWgb1CjF1kogI6iu/AtjU4K47BUPSVK0d8+/Qq6aIGmjQYtVNNVEV5gTANjf5PAB2j5IPQEALb1MYNqGm57kNc/UB6E/iJXGIqiz4PpSZTM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1631177381; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=MDa51DXmD0+Ym/ZtR/aeQLdTuzgp8+ojhN/WN8fkBTU=; b=P4P8B85UWSSZN5BB4H11feh01pRRCJdS38CWn/V3IDfztObcneWTItymC++p7bSOEergl+P1inLI5LAQ2oqUTYlwwhedJ4iafUSSThgipHqHkhqOKgU2MnDI1gJlh4c8K09duFyew/81co36ro+olOEHpMW9egpSIL2m6PLbTts= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1631177381131821.3996443542903; Thu, 9 Sep 2021 01:49:41 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-8-zARgRZDMOhmF8gPyksVV1Q-1; Thu, 09 Sep 2021 04:49:38 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DD58618358EF; Thu, 9 Sep 2021 08:49:33 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BEE1060C04; Thu, 9 Sep 2021 08:49:33 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8F9824EA29; Thu, 9 Sep 2021 08:49:33 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1898nWGr030056 for ; Thu, 9 Sep 2021 04:49:32 -0400 Received: by smtp.corp.redhat.com (Postfix) id 1082E19D9B; Thu, 9 Sep 2021 08:49:32 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.40.208.16]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7304B19736 for ; Thu, 9 Sep 2021 08:49:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631177380; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=MDa51DXmD0+Ym/ZtR/aeQLdTuzgp8+ojhN/WN8fkBTU=; b=L53S561me5ojgaN1kq0nbPOWCal6PfM1ULzXHTb+C4OLodW4AvFZz41islH+L1IQDFj1HC 0+FH4VrHdnLkHphE/7aJ/aG9xrJvFfBEpidIA15YJT0IOQdlfolSvhf7yoH/1Xc9hoSQ1t CM+367uVP+iAh5z1pCGhhkRK5crZpb0= X-MC-Unique: zARgRZDMOhmF8gPyksVV1Q-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 02/24] virstoragetest: Drop testing of NBD backends via parsing real images Date: Thu, 9 Sep 2021 10:49:02 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1631177382595100003 Content-Type: text/plain; charset="utf-8" We now have specific tests for the backing store parser and previous tests cover the extraction of the backing store string so there's no need for these particular tests. Signed-off-by: Peter Krempa --- tests/virstoragetest.c | 31 ------------------------------- 1 file changed, 31 deletions(-) diff --git a/tests/virstoragetest.c b/tests/virstoragetest.c index ab34f2f3be..f6af1a17ac 100644 --- a/tests/virstoragetest.c +++ b/tests/virstoragetest.c @@ -651,25 +651,6 @@ mymain(void) TEST_CHAIN(absqcow2, VIR_STORAGE_FILE_QCOW2, (&qcow2), EXP_FAIL); - /* Rewrite qcow2 to use an nbd: protocol as backend */ - virCommandFree(cmd); - cmd =3D virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2", - "-F", "raw", "-b", "nbd:example.org:6000:ex= portname=3Dblah", - "qcow2", NULL); - if (virCommandRun(cmd, NULL) < 0) - ret =3D -1; - qcow2.expBackingStoreRaw =3D "nbd:example.org:6000:exportname=3Dblah"; - - /* Qcow2 file with backing protocol instead of file */ - testFileData nbd =3D { - .path =3D "blah", - .type =3D VIR_STORAGE_TYPE_NETWORK, - .format =3D VIR_STORAGE_FILE_RAW, - .protocol =3D VIR_STORAGE_NET_PROTOCOL_NBD, - .hostname =3D "example.org", - }; - TEST_CHAIN(absqcow2, VIR_STORAGE_FILE_QCOW2, (&qcow2, &nbd), EXP_PASS); - /* Rewrite qcow2 to use an nbd: protocol as backend */ virCommandFree(cmd); cmd =3D virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2", @@ -689,18 +670,6 @@ mymain(void) }; TEST_CHAIN(absqcow2, VIR_STORAGE_FILE_QCOW2, (&qcow2, &nbd2), EXP_PASS= ); - /* Rewrite qcow2 to use an nbd: protocol without path as backend */ - virCommandFree(cmd); - cmd =3D virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2", - "-F", "raw", "-b", "nbd://example.org", - "qcow2", NULL); - if (virCommandRun(cmd, NULL) < 0) - ret =3D -1; - qcow2.expBackingStoreRaw =3D "nbd://example.org"; - - nbd2.path =3D NULL; - TEST_CHAIN(absqcow2, VIR_STORAGE_FILE_QCOW2, (&qcow2, &nbd2), EXP_PASS= ); - /* qed file */ testFileData qed =3D { .expBackingStoreRaw =3D absraw, --=20 2.31.1