From nobody Sun Feb 8 18:08:46 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1638452024; cv=none; d=zohomail.com; s=zohoarc; b=nxZRM0DbogCmHlhYbQt7MjBEmwmoYxirmVyhR+CiYRwCed/H3uQ7B+zyZ2fIY/i0zsTUGnA2s6u17s05haYvElieNhKgXIY2LFYMSMn0suIOjXgdQJRJdd4WqC+rcmfDSphaz8kJdkDG4snTYrMZwsAEh0UPvdVGF5vseV2IYeQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1638452024; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=6xiK6GYS1E9AzK9s0fpDMtHU3p8fo7ntpcqo603kTFo=; b=lVBzwuAcXx2qtyucJ54DJF93fFY76c2scGPRA7KBlpSgzqEnARiAGiYebOQR5yxHZQMvXQPf8GF8NDZB/nkZFuFGA6fIP0idQgHAh6uI54n6IXPsW2VLs8l/OicCbdHbyRJx6hk0XKPYEM6jNRqHVlsNKF/lJOe0CdyxwflNeJA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1638452024710769.6995459109879; Thu, 2 Dec 2021 05:33:44 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-427-ewHy8jfNN1a9qItbx6WzPQ-1; Thu, 02 Dec 2021 08:33:40 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7CBA818690E3; Thu, 2 Dec 2021 13:33:34 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7D6AA100E125; Thu, 2 Dec 2021 13:33:33 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C3E0A4CA93; Thu, 2 Dec 2021 13:33:27 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1B2DXPi0020996 for ; Thu, 2 Dec 2021 08:33:25 -0500 Received: by smtp.corp.redhat.com (Postfix) id B57915D9D5; Thu, 2 Dec 2021 13:33:25 +0000 (UTC) Received: from antique-work.lan (unknown [10.40.192.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id 336964EDC1 for ; Thu, 2 Dec 2021 13:33:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1638452023; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=6xiK6GYS1E9AzK9s0fpDMtHU3p8fo7ntpcqo603kTFo=; b=E8t1rnvCWuUPCquBPjmgINgmSfMMPQehNBKZiDMo4YKzmIWovtLPRMSn1JpAS9A7uYPvBS DhHikHthzbauD4RLoQ8ys31wqyFHMNldjYDtlxPrhpl1/XKZ0sd8Ux2kZISAlHw/l00+26 TssqsVFnFZzM5JsvnuPkkv8o6ojS5Gk= X-MC-Unique: ewHy8jfNN1a9qItbx6WzPQ-1 From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH 03/14] qemu_snapshot: revert: use g_autoptr Date: Thu, 2 Dec 2021 14:33:10 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1638452025409100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Pavel Hrdina --- src/qemu/qemu_snapshot.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c index 413b31bae5..5ac1c99a68 100644 --- a/src/qemu/qemu_snapshot.c +++ b/src/qemu/qemu_snapshot.c @@ -1940,8 +1940,8 @@ qemuSnapshotRevert(virDomainObj *vm, int detail; qemuDomainObjPrivate *priv =3D vm->privateData; int rc; - virDomainDef *config =3D NULL; - virDomainDef *inactiveConfig =3D NULL; + g_autoptr(virDomainDef) config =3D NULL; + g_autoptr(virDomainDef) inactiveConfig =3D NULL; g_autoptr(virQEMUDriverConfig) cfg =3D virQEMUDriverGetConfig(driver); qemuDomainSaveCookie *cookie; unsigned int start_flags =3D VIR_QEMU_PROCESS_START_GEN_VMID; @@ -2233,8 +2233,6 @@ qemuSnapshotRevert(virDomainObj *vm, } virObjectEventStateQueue(driver->domainEventState, event); virObjectEventStateQueue(driver->domainEventState, event2); - virDomainDefFree(config); - virDomainDefFree(inactiveConfig); =20 return ret; } --=20 2.31.1