From nobody Fri Dec 19 17:01:26 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1596406395; cv=none; d=zohomail.com; s=zohoarc; b=bxeqsMloKF9sSgYJCPV+/GyoidIP/FCleYwz++voOWlO9/gFl+KYtwH1C8cAtUvTyMzQANjuAja9VO5K8w4/6Wk9222acHpjRjIbMeNF/LJaLPRxLkGLwoopkgsh/nbxn+xyd9Lc2UAiuW0ItSvAVrJamYuooVYtlWtSy2bUZCY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1596406395; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=7Icu1gTh0bAhOnjYM3UmRvc/SdtHb3lbHu1JdF4VwJ4=; b=jgjtneGxM1eXZSNffTLLwMkto0Sl+yw0c2CPCKjxrLXVxScrBBgVd5CnF51qeliNqfoHSg7f/rrAQUwvouHqD4xRT9/Q2ExsnwIDlSPK7avECJ5Ug//y2Zl4mG83Bd6BMKEt/POGuT7LHOQYW4AnbCxOA1rtNpRXNAnw4Sj6uGs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 1596406395854105.9097083797601; Sun, 2 Aug 2020 15:13:15 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-322-7WqjotlmO32-JbjKiF4nLA-1; Sun, 02 Aug 2020 18:12:25 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BBDC910059AA; Sun, 2 Aug 2020 22:12:17 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9717B6115F; Sun, 2 Aug 2020 22:12:17 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6A5269A0FB; Sun, 2 Aug 2020 22:12:17 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 072MBkDR010629 for ; Sun, 2 Aug 2020 18:11:46 -0400 Received: by smtp.corp.redhat.com (Postfix) id D13175FC36; Sun, 2 Aug 2020 22:11:46 +0000 (UTC) Received: from lpt.redhat.com (unknown [10.40.208.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 215F75FC2F for ; Sun, 2 Aug 2020 22:11:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596406394; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=7Icu1gTh0bAhOnjYM3UmRvc/SdtHb3lbHu1JdF4VwJ4=; b=d4iROqo3q/6BxeCEhLf5FE04dM9gnDcMLXvpnEbEYqFs5nSGEYDb8d6na4OdIWMECFqMIT kiNjNQ3LUzuFkcB+bc38vzzAi+7DDnbIP7gKnUFesHSqQvKSoI2XZ4fHNDj1pA61k3OgMx u9n8sDwR6j0/Kj9nDaSBY5fXEkunvb0= X-MC-Unique: 7WqjotlmO32-JbjKiF4nLA-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 6/8] virsh: completer: use signed variable for XPathNodeSet errors Date: Mon, 3 Aug 2020 00:11:29 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Although virXPathNodeSet is unlikely to return -1, we should check for it properly or not at all. Signed-off-by: J=C3=A1n Tomko --- tools/virsh-completer-host.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh-completer-host.c b/tools/virsh-completer-host.c index 35e6bba661..8893888ec2 100644 --- a/tools/virsh-completer-host.c +++ b/tools/virsh-completer-host.c @@ -55,7 +55,7 @@ virshAllocpagesPagesizeCompleter(vshControl *ctl, { g_autoptr(xmlXPathContext) ctxt =3D NULL; virshControlPtr priv =3D ctl->privData; - unsigned int npages =3D 0; + int npages =3D 0; g_autofree xmlNodePtr *pages =3D NULL; g_autoptr(xmlDoc) doc =3D NULL; size_t i =3D 0; @@ -106,7 +106,7 @@ virshCellnoCompleter(vshControl *ctl, { g_autoptr(xmlXPathContext) ctxt =3D NULL; virshControlPtr priv =3D ctl->privData; - unsigned int ncells =3D 0; + int ncells =3D 0; g_autofree xmlNodePtr *cells =3D NULL; g_autoptr(xmlDoc) doc =3D NULL; size_t i =3D 0; --=20 2.26.2