From nobody Sun Feb 8 10:33:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1647876296; cv=none; d=zohomail.com; s=zohoarc; b=ByGcW67sHw0amLJgg1FHQFKy2Ppy4u6+vNLcxvpn59Rni4YseNZlb7HSXw09TWtwq0ZdEwzC69HMoe3SJhygIE8ZV3KJU9ADj/2GUbWVhqe2LYZ51onnTMeHUJ717vYf7dbvtyfsO6O+ckGOkpoYyYeQcEELod4UYqPsRt2C7i0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647876296; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=WwVAVbWV1Zqps1Uff0b0guzlBgLm935pUjA0Bm1Mamw=; b=IjwidSib/85d0qZaKcoyDUsjkeDlCTpe/mHR8Gn+4cPlRn4MynqLjZ93/PRc4e/u938rU5k82ySGpCALeGSMr5iBapqThMrMsFW4sqc0I63bfrHV3n8fdVlT0fw6diN536hfLEAI/DyxYD+Ps85aSa6DCyVh4QTFHmKaINXid2Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 164787629676068.58723418923091; Mon, 21 Mar 2022 08:24:56 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-31-drsiQ9LbMbShTP74O6D64g-1; Mon, 21 Mar 2022 11:24:51 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 31266833979; Mon, 21 Mar 2022 15:24:48 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1974DC26E95; Mon, 21 Mar 2022 15:24:48 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 57C701940352; Mon, 21 Mar 2022 15:24:47 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 49C681940343 for ; Mon, 21 Mar 2022 15:24:46 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 3DBD441D3ED; Mon, 21 Mar 2022 15:24:46 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.35]) by smtp.corp.redhat.com (Postfix) with ESMTP id AAD8641D404 for ; Mon, 21 Mar 2022 15:24:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647876295; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=WwVAVbWV1Zqps1Uff0b0guzlBgLm935pUjA0Bm1Mamw=; b=PG6c9YkbdSBhumqEVzQenVI6Sv3IT2KFRiI+5L6aAphDyZ3vgvlFykpH72DaPdc8jI5yvP FLN31lD55MaQU42T+s2PzRdPmXpZbTdAzJatgTmHc4XNpormSLupUxox2Z2F7r6pF1vO9r j5CetpWi0CoCVEILiZfmCVVdZR8Oin4= X-MC-Unique: drsiQ9LbMbShTP74O6D64g-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 4/7] conf: Introduce VIR_DOMAIN_TAINT_CUSTOM_DEVICE and use it in qemu Date: Mon, 21 Mar 2022 16:24:37 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1647876299003100001 Content-Type: text/plain; charset="utf-8" Taint the domain object when the user requests custom device properties. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 2 ++ src/conf/domain_conf.h | 1 + src/qemu/qemu_domain.c | 3 +++ 3 files changed, 6 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index e0dfc9e45f..902f101996 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -88,6 +88,7 @@ VIR_ENUM_IMPL(virDomainTaint, "custom-ga-command", "custom-hypervisor-feature", "deprecated-config", + "custom-device", ); VIR_ENUM_IMPL(virDomainTaintMessage, @@ -105,6 +106,7 @@ VIR_ENUM_IMPL(virDomainTaintMessage, N_("custom guest agent control commands issued"), N_("hypervisor feature autodetection override"), N_("use of deprecated configuration settings"), + N_("custom device configuration"), ); VIR_ENUM_IMPL(virDomainVirt, diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index a4de46773c..e06188caad 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -3009,6 +3009,7 @@ typedef enum { VIR_DOMAIN_TAINT_CUSTOM_GA_COMMAND, /* Custom guest agent command */ VIR_DOMAIN_TAINT_CUSTOM_HYPERVISOR_FEATURE, /* custom hypervisor featu= re control */ VIR_DOMAIN_TAINT_DEPRECATED_CONFIG, /* Configuration that is marked d= eprecated */ + VIR_DOMAIN_TAINT_CUSTOM_DEVICE, /* hypervisor device config customized= */ VIR_DOMAIN_TAINT_LAST } virDomainTaintFlags; diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 595440173c..a4eef97c95 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -6700,6 +6700,9 @@ void qemuDomainObjCheckTaint(virQEMUDriver *driver, qemuDomainObjTaint(driver, obj, VIR_DOMAIN_TAINT_CUSTOM_ARGV, = logCtxt); if (qemuxmlns->capsadd || qemuxmlns->capsdel) custom_hypervisor_feat =3D true; + + if (qemuxmlns->ndeviceOverride > 0) + qemuDomainObjTaint(driver, obj, VIR_DOMAIN_TAINT_CUSTOM_DEVICE= , logCtxt); } if (custom_hypervisor_feat || --=20 2.35.1