From nobody Sun Feb 8 19:56:11 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1667896225; cv=none; d=zohomail.com; s=zohoarc; b=ASL+lpNFpw7kIWwCy3pOOzNmYTf2tc/SfL6giHygjETPGARv+Ly6iugwO13xzEIWpX6ffqxf1q9boMsh21Ux23oF+QJtrCX/GQITlSFmDh8UMOyXZpBi7Bc+PXDy4cFqy/jeDFeH1yzrMsLlWF6VCQKQF56DdEXnAEy6jYiWUDs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1667896225; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=1v0VmuQe/v0pjT9VRfd7bGAtv0wAkKCXcO9IV839w2g=; b=VGWk60lL2oUoWHW2g1WAeFzabxSTxb528eRPeYw3jQzghLHuteoKkohh0EQjkVBWJp99I6MBaFw3WvvhPZ0tbyV0dtvoPJOHloCOEx35Gu+NOM/fLY8v9+eA25uvV8S+wbcm9zHXfreTDxyk+vS81IM77URzm5H3OP1ysg35jt0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 166789622577462.5820767692594; Tue, 8 Nov 2022 00:30:25 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-187-EUEkv8QmOtilQrC_C1VMrw-1; Tue, 08 Nov 2022 03:30:17 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6E70486C049; Tue, 8 Nov 2022 08:30:10 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 592332028E90; Tue, 8 Nov 2022 08:30:10 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 03EB81946588; Tue, 8 Nov 2022 08:30:10 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 3B64C1946587 for ; Tue, 8 Nov 2022 08:30:08 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 1AFA635429; Tue, 8 Nov 2022 08:30:08 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id B275810197 for ; Tue, 8 Nov 2022 08:30:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667896224; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=1v0VmuQe/v0pjT9VRfd7bGAtv0wAkKCXcO9IV839w2g=; b=R1YdOTBu/bT+byN7AHG64qwIXagjymnGi0YJFE74kwuJ8Pa9xZGvJEEutVrU5x9GU7fIyR XNrhYpXNx19NE+ufQiuMww2WgVrD9d+ENMrFSTH/EWJZ4BIPFnVrwHhZPlvgN8lhnzCeE7 pljdqAH5ea/uL/X5JgGeo7OT5CCXQ6g= X-MC-Unique: EUEkv8QmOtilQrC_C1VMrw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 25/48] qemu: Assume QEMU_CAPS_VIRTIO_NET_RX_QUEUE_SIZE Date: Tue, 8 Nov 2022 09:29:27 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1667896226886100007 Content-Type: text/plain; charset="utf-8"; x-default="true" Introduced in QEMU's commit of v2.8.0-rc0~116^2~26 the .rx_queue_size attribute of virtio-net device is always available for all QEMU versions we support (4.2.0, currently). Therefore, we can assume the capability is always set and thus doesn't need to be checked for. Signed-off-by: Michal Privoznik Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_validate.c | 6 ------ tests/qemuxml2argvtest.c | 4 +--- tests/qemuxml2xmltest.c | 1 - 3 files changed, 1 insertion(+), 10 deletions(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 78c68a99d0..74631378c6 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -1866,12 +1866,6 @@ qemuValidateDomainDeviceDefNetwork(const virDomainNe= tDef *net, _("rx_queue_size has to be a power of two")= ); return -1; } - if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_VIRTIO_NET_RX_QUEUE_SI= ZE)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("virtio rx_queue_size option is not suppo= rted " - "with this QEMU binary")); - return -1; - } } =20 if (net->driver.virtio.tx_queue_size) { diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index dd2460bc0b..98ba6633f8 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -1466,10 +1466,8 @@ mymain(void) DO_TEST_NOCAPS("net-virtio-netdev"); DO_TEST_CAPS_ARCH_LATEST("net-virtio-ccw", "s390x"); DO_TEST("net-virtio-rxtxqueuesize", - QEMU_CAPS_VIRTIO_NET_RX_QUEUE_SIZE, QEMU_CAPS_VIRTIO_NET_TX_QUEUE_SIZE); - DO_TEST_PARSE_ERROR("net-virtio-rxqueuesize-invalid-size", - QEMU_CAPS_VIRTIO_NET_RX_QUEUE_SIZE); + DO_TEST_PARSE_ERROR_NOCAPS("net-virtio-rxqueuesize-invalid-size"); DO_TEST("net-virtio-teaming", QEMU_CAPS_VIRTIO_NET_FAILOVER, QEMU_CAPS_DEVICE_VFIO_PCI); diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c index 45e16ce02d..22397f209f 100644 --- a/tests/qemuxml2xmltest.c +++ b/tests/qemuxml2xmltest.c @@ -468,7 +468,6 @@ mymain(void) DO_TEST_NOCAPS("net-eth-unmanaged-tap"); DO_TEST_NOCAPS("net-virtio-network-portgroup"); DO_TEST("net-virtio-rxtxqueuesize", - QEMU_CAPS_VIRTIO_NET_RX_QUEUE_SIZE, QEMU_CAPS_VIRTIO_NET_TX_QUEUE_SIZE); DO_TEST("net-virtio-teaming", QEMU_CAPS_VIRTIO_NET_FAILOVER, --=20 2.37.4