From nobody Mon Apr 29 10:43:55 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1604920778; cv=none; d=zohomail.com; s=zohoarc; b=ZbshG3USEJfsEHouaPdb8yFRYRmCmXl3R9ZyS8Mj+uFPwjZ1Yr1UORXOL4vXmakOAu9VUuxpiQEq2YIhGONCyPJiUSMaI3YQM9xKezaGvA21BbdVHsHNTmQOvK9ysAG7YIVH2tqBA1Lm59lRciQ6yg2RoTLB0/mwEnwcj8VlSV4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604920778; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=SsHM1eFeLsfI/T4pZ/32BNpUheaJkRjEvZtMBUVTzxE=; b=EDYlyVHvikmMZ5uXN1PTloLOueaewEBrh90OBca2k1RYREisb4pVKiRfvmyt2UZDUDBYsGrA3YIoSL3RUW5yJOk3c0ImsfmMPJiHZ19orMwHsn9OvERVRHdMIO041mdSFcvgQYCoBKFKFkjZjtmeL0z5/wi5FP9bXk+9QTQL470= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1604920778745447.4103332562662; Mon, 9 Nov 2020 03:19:38 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-34-vF5ok5UvPX-XPmEjOuZu7A-1; Mon, 09 Nov 2020 06:19:34 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 01E1C8C3881; Mon, 9 Nov 2020 11:19:24 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EC5F15B4CB; Mon, 9 Nov 2020 11:19:21 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id CC5CDCF5A; Mon, 9 Nov 2020 11:19:16 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0A9BJFqb009669 for ; Mon, 9 Nov 2020 06:19:15 -0500 Received: by smtp.corp.redhat.com (Postfix) id 1BC6660FC2; Mon, 9 Nov 2020 11:19:15 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.194.181]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8F0CD60BF1 for ; Mon, 9 Nov 2020 11:19:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604920777; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=SsHM1eFeLsfI/T4pZ/32BNpUheaJkRjEvZtMBUVTzxE=; b=PjVNoqOu/UcNjEhZL++wbxSBo6mlRSDnl3QarWgtKY0SNC/NjaiP7B5iuTrRiPGJ5xUUvS eTi1sG7wOsbqNlqWbz6d896aNpGEANVDGREZtK2XfY+cZCqzCj4xtXKERtUb/y/Ykya3rL CqhsA660kuPNQSalhwfHvm8o5s/zQaU= X-MC-Unique: vF5ok5UvPX-XPmEjOuZu7A-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH] viridentitytest: Run more frequently Date: Mon, 9 Nov 2020 12:19:09 +0100 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The viridentitytest tests our viridentity module which is compiled on all platforms and OSes. There is no need to have SELinux secdriver as individual test cases are skipped if SELinux is missing. Signed-off-by: Michal Privoznik Reviewed-by: Daniel Henrique Barboza Reviewed-by: J=C3=A1n Tomko --- Successfully build here: https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/213586713 While technically this is a v2 of: https://www.redhat.com/archives/libvir-list/2020-November/msg00308.html it's implementing completely different approach and thus I did not mark it as v2. tests/meson.build | 2 +- tests/viridentitytest.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/meson.build b/tests/meson.build index 8decdfa20c..9f0051303d 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -312,6 +312,7 @@ tests +=3D [ { 'name': 'virfirewalltest' }, { 'name': 'virhostcputest', 'link_whole': [ test_file_wrapper_lib ] }, { 'name': 'virhostdevtest' }, + { 'name': 'viridentitytest' }, { 'name': 'viriscsitest' }, { 'name': 'virkeycodetest' }, { 'name': 'virkmodtest' }, @@ -480,7 +481,6 @@ if conf.has('WITH_SECDRIVER_SELINUX') if conf.has('WITH_LIBATTR') tests +=3D [ { 'name': 'securityselinuxtest' }, - { 'name': 'viridentitytest' }, ] =20 if conf.has('WITH_QEMU') diff --git a/tests/viridentitytest.c b/tests/viridentitytest.c index fd01eeaa80..afb9fdaec4 100644 --- a/tests/viridentitytest.c +++ b/tests/viridentitytest.c @@ -88,8 +88,7 @@ static int testIdentityGetSystem(const void *data) #if !WITH_SELINUX if (context) { VIR_DEBUG("libvirt not compiled with SELinux, skipping this test"); - ret =3D EXIT_AM_SKIP; - return -1; + return EXIT_AM_SKIP; } #endif =20 --=20 2.26.2