From nobody Tue Oct 28 17:34:05 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1760023116; cv=none; d=zohomail.com; s=zohoarc; b=kgNi2xxQm8/HURy314oSb7k0KiFBBpjQikjq7LtYgkaO/lDqF9mYpjUTxsGLt90O/0tzBMhvMfRcwlXHMGbB6qJ1ThxpZe/+LV9YzBA9QfCGJk+SjJeQEDfU56m892UsDTxejJg5EIhdZnGuW51NG/kHmLyw6ucRHD7QGQObLSI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760023116; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=XhUvPxLguKS+XOGsEhonKhKan+E0H7rOSkBK6+XJwGU=; b=EPqDu8srvnF1XTBcISATI1Ydxkh3JxiJpdEZijQNcRUz1mcRtQl04tM12vTcfoE6ijnFNnmU9oLcCO81yQKmzzFcWx6JFjZNrySC/oY+OejV5uC+KorbxudDcpvyvxISK5MMiFOcS3WB5gdofrbDjO8Aml9/32arWvXzhErOAWQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1760023116060777.1431183511747; Thu, 9 Oct 2025 08:18:36 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 5F2BB442BE; Thu, 9 Oct 2025 11:18:30 -0400 (EDT) Received: from [172.19.199.20] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id E496F442DA; Thu, 9 Oct 2025 11:16:44 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 733EC43E6E; Thu, 9 Oct 2025 11:16:23 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id AD2D843E48 for ; Thu, 9 Oct 2025 11:16:22 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-684-GEnJzeWKPUufJQq5eeGl1w-1; Thu, 09 Oct 2025 11:16:21 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2FD97180057B for ; Thu, 9 Oct 2025 15:16:20 +0000 (UTC) Received: from speedmetal.lan (unknown [10.44.22.12]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 62E601955F22 for ; Thu, 9 Oct 2025 15:16:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1760022982; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XhUvPxLguKS+XOGsEhonKhKan+E0H7rOSkBK6+XJwGU=; b=OV+CBo5LN8sNAlUQjIFK+PTTM0di9nZM/wPvda5re8yA8j+he5u6Cs6NN+t4nMawvR+jWa byZvHBl1a8QE6GJzhGzXU9RkDvZZpTA081ehbKSiA6OQzd2J9YOJdURkg4HfPRTeoQvUJp GYwnp5+10ipzMH79iHXN9Ev50F3Y1Nk= X-MC-Unique: GEnJzeWKPUufJQq5eeGl1w-1 X-Mimecast-MFC-AGG-ID: GEnJzeWKPUufJQq5eeGl1w_1760022980 To: devel@lists.libvirt.org Subject: [RFC PATCH 01/16] qemu: monitor: Remove qemuMonitorQueryBlockstats Date: Thu, 9 Oct 2025 17:16:01 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: oShpu3peLeQfSMVRF6rhfkohS1uEkMSlfRfTwGb2Xtc_1760022980 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: MNEST37WCJBD4ZM2SPFRTBA2JC2AEBTW X-Message-ID-Hash: MNEST37WCJBD4ZM2SPFRTBA2JC2AEBTW X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1760023118104116600 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Unused since v8.6.0-154-g75a0fbe420 Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor.c | 15 --------------- src/qemu/qemu_monitor.h | 2 -- src/qemu/qemu_monitor_json.c | 2 +- src/qemu/qemu_monitor_json.h | 3 --- 4 files changed, 1 insertion(+), 21 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 2fc883e8a6..7b09792c5d 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -1967,21 +1967,6 @@ qemuMonitorGetBlockInfo(qemuMonitor *mon) } -/** - * qemuMonitorQueryBlockstats: - * @mon: monitor object - * - * Returns data from a call to 'query-blockstats' without using 'query-nod= es' - */ -virJSONValue * -qemuMonitorQueryBlockstats(qemuMonitor *mon) -{ - QEMU_CHECK_MONITOR_NULL(mon); - - return qemuMonitorJSONQueryBlockstats(mon, false); -} - - /** * qemuMonitorGetAllBlockStatsInfo: * @mon: monitor object diff --git a/src/qemu/qemu_monitor.h b/src/qemu/qemu_monitor.h index 8ef85ceb0a..6427fd42cd 100644 --- a/src/qemu/qemu_monitor.h +++ b/src/qemu/qemu_monitor.h @@ -677,8 +677,6 @@ int qemuMonitorSetMemoryStatsPeriod(qemuMonitor *mon, int qemuMonitorBlockIOStatusToError(const char *status); GHashTable *qemuMonitorGetBlockInfo(qemuMonitor *mon); -virJSONValue *qemuMonitorQueryBlockstats(qemuMonitor *mon); - typedef struct _qemuBlockStats qemuBlockStats; struct _qemuBlockStats { unsigned long long rd_req; diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 9caade7bc9..b459a2f036 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -2463,7 +2463,7 @@ qemuMonitorJSONGetOneBlockStatsNodeInfo(virJSONValue = *dev, } -virJSONValue * +static virJSONValue * qemuMonitorJSONQueryBlockstats(qemuMonitor *mon, bool queryNodes) { diff --git a/src/qemu/qemu_monitor_json.h b/src/qemu/qemu_monitor_json.h index f17769f7fe..5944aec917 100644 --- a/src/qemu/qemu_monitor_json.h +++ b/src/qemu/qemu_monitor_json.h @@ -91,9 +91,6 @@ int qemuMonitorJSONGetBlockInfo(qemuMonitor *mon, GHashTable *table); -virJSONValue * -qemuMonitorJSONQueryBlockstats(qemuMonitor *mon, - bool queryNodes); int qemuMonitorJSONGetAllBlockStatsInfo(qemuMonitor *mon, GHashTable *hash); --=20 2.51.0