From nobody Sun Feb 8 17:04:17 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1570485515; cv=none; d=zoho.com; s=zohoarc; b=LElJg7JBd1uLxViZKbUBPm0e27vmOxlHGtk+u1UQ3c9sFjvB5BFmKPkRu6ugXjPKF+SLE8vKEuqV0QhM0GOhAdMpWHvANQ8fISKKeDl7NWcuSODEV//nMfmUYCLmMshtQ1Qlrds1uf+FOqW3n2GM342Q7LJ0MBZtaRUPXn1KlkA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570485515; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=0X48Fst6Y+m7zz9JriavALw3y9RJkGk65jT/gidieoA=; b=QCZQU1S16WDPlKdG+Zr5g8khzqFOQ0odsfL6cy+pFAeL3AbuMl+s1uGsAcolDQmHtZH33ywEqs53qwr3PU2zU6D3f+sdA9AdZ4El6ACPOCnsAm6/84XtLpM5UNCUHJGVFy1vngwLiYWF3zEptplOwU7UyEti5esf5HC8TntCYFw= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1570485515831520.9491753790431; Mon, 7 Oct 2019 14:58:35 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F0F2964457; Mon, 7 Oct 2019 21:58:33 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 95FC360A35; Mon, 7 Oct 2019 21:58:33 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 032284EE97; Mon, 7 Oct 2019 21:58:32 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x97LosuW015155 for ; Mon, 7 Oct 2019 17:50:55 -0400 Received: by smtp.corp.redhat.com (Postfix) id F03125C224; Mon, 7 Oct 2019 21:50:54 +0000 (UTC) Received: from worklaptop.redhat.com (ovpn-123-156.rdu2.redhat.com [10.10.123.156]) by smtp.corp.redhat.com (Postfix) with ESMTP id 933CB5C1D4; Mon, 7 Oct 2019 21:50:54 +0000 (UTC) From: Cole Robinson To: libvir-list@redhat.com Date: Mon, 7 Oct 2019 17:49:38 -0400 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 24/30] security: dac: Label externalDataStore X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 07 Oct 2019 21:58:34 +0000 (UTC) Content-Type: text/plain; charset="utf-8" We mirror the labeling strategy that was used for its sibling image Signed-off-by: Cole Robinson Reviewed-by: Daniel Henrique Barboza --- src/security/security_dac.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/security/security_dac.c b/src/security/security_dac.c index 326b9b1a3c..2bbf773dd3 100644 --- a/src/security/security_dac.c +++ b/src/security/security_dac.c @@ -882,7 +882,7 @@ virSecurityDACSetImageLabelInternal(virSecurityManagerP= tr mgr, virSecurityDeviceLabelDefPtr parent_seclabel =3D NULL; virSecurityDACDataPtr priv =3D virSecurityManagerGetPrivateData(mgr); bool remember; - bool is_toplevel =3D parent =3D=3D src; + bool is_toplevel =3D parent =3D=3D src || parent->externalDataStore = =3D=3D src; uid_t user; gid_t group; =20 @@ -946,6 +946,14 @@ virSecurityDACSetImageLabelRelative(virSecurityManager= Ptr mgr, if (virSecurityDACSetImageLabelInternal(mgr, def, n, parent) < 0) return -1; =20 + if (n->externalDataStore && + virSecurityDACSetImageLabelRelative(mgr, + def, + n->externalDataStore, + parent, + flags) < 0) + return -1; + if (!(flags & VIR_SECURITY_DOMAIN_IMAGE_LABEL_BACKING_CHAIN)) break; } --=20 2.23.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list