From nobody Mon Feb 2 07:31:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1769443813; cv=none; d=zohomail.com; s=zohoarc; b=QBEhy81uLt4nQ9x1uIwL5teLXUChB4wzoTUXoPBTXwWm4JkfKfJgOng0z5zPyPYTKjTb9wj2XjRydlIhpxmPW/C7wtxQqgYfa13J0dUcKDLy33pP/eX06xM2YHmIko3tAh1pydaKfmNVH+r8xjx2IHhyuQ2f5dhrTL9qck7SP0U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769443813; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=brPGIpL2bUrG35X9d/FMMNTpWjEKh5W4QheYTPZkg/k=; b=P45ASf95zRwI+kLdS8Agj5FRCPVrYPD6V1QMqaId7V7M6jlbT1X4b4ZQskqQBN8MIcLPUZL40RJgxJv7u7bF4GTBJExDpooH0NUr9J9K7EbYQvoMYeHomft3cMHywQEs6tHiuVHju9iP0UdrhdIwPrZHQbXn6tzDrf+1oXx8Ti4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1769443813867139.3017633073854; Mon, 26 Jan 2026 08:10:13 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id F0D8741A6F; Mon, 26 Jan 2026 11:10:12 -0500 (EST) Received: from [172.19.199.3] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id C6F2143E98; Mon, 26 Jan 2026 11:07:21 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id F2A2043E4F; Mon, 26 Jan 2026 11:07:17 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id A627841A09 for ; Mon, 26 Jan 2026 11:07:03 -0500 (EST) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-437-BseS3ieHMYmk4llCCsZQWQ-1; Mon, 26 Jan 2026 11:07:01 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C8AE2180034A for ; Mon, 26 Jan 2026 16:07:00 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.3]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 154A4180049F for ; Mon, 26 Jan 2026 16:06:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769443623; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=brPGIpL2bUrG35X9d/FMMNTpWjEKh5W4QheYTPZkg/k=; b=YeUq8x3JAiPn118cLcA5sJaEetsvvXsyyngrfb4yDnc9gN+GWPONK8LQdlmuK0j8fymLb+ tKKquDoUuQJlKTmVDehzLbUUk5r2AH/QJJoJ5+El3YT7z7kweVnXVmfMXFEqYwV6PdLuot ZilWbUbO8gWHcy9SCsNx1xsScdMVgTI= X-MC-Unique: BseS3ieHMYmk4llCCsZQWQ-1 X-Mimecast-MFC-AGG-ID: BseS3ieHMYmk4llCCsZQWQ_1769443620 To: devel@lists.libvirt.org Subject: [PATCH v2 4/5] virDomainSnapshotDefAssignExternalNames: Improve error message Date: Mon, 26 Jan 2026 17:06:52 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: v_DshJUYPdr_V3w9g6LSmqSTLzLzj8gniP3CwrWR8go_1769443620 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: FGNJYPXESUN6LI6GSBFBCZ5NREST7QY6 X-Message-ID-Hash: FGNJYPXESUN6LI6GSBFBCZ5NREST7QY6 X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1769443814714158500 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Mention the 'path' where the detection failed as well as include the possibility that the 'path' doesn't exist in the message itself. Signed-off-by: Peter Krempa --- src/conf/snapshot_conf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/snapshot_conf.c b/src/conf/snapshot_conf.c index 039ed77b84..4309667a34 100644 --- a/src/conf/snapshot_conf.c +++ b/src/conf/snapshot_conf.c @@ -541,8 +541,8 @@ virDomainSnapshotDefAssignExternalNames(virDomainSnapsh= otDef *def, if (stat(origpath, &sb) < 0 || !S_ISREG(sb.st_mode)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("source for disk '%1$s' is not a regular file= ; refusing to generate external snapshot name"), - disk->name); + _("source for disk '%1$s' (%2$s) doesn't exist = or is not a regular file; refusing to generate external snapshot name"), + disk->name, origpath); return -1; } --=20 2.52.0